ui: Statement/Transactin Page filter selector not properly updated when navigated from Statement Detail Page #70790
Assignees
Labels
A-sql-observability
Related to observability of the SQL layer
C-bug
Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.
Comments
Azhng
added
C-bug
xinhaoz
added a commit
to xinhaoz/cockroach
that referenced
this issue
Oct 5, 2021
Fixes: cockroachdb#70790 Previously, the selected app was derived from a route param on the statements page. All other filters are derived from query search parameters on the page. This commit makes the app name a query search parameter, as is the case in the transactions page. Release note (ui change): The selected app name on the statements page is now a query search parameter instead of a route parameter. E.g., instead of `/statements/movr`, use `/statements?app=movr`
xinhaoz
added a commit
to xinhaoz/cockroach
that referenced
this issue
Oct 5, 2021
Fixes: cockroachdb#70790 Previously, the selected app was derived from a route param on the statements page. All other filters are derived from query search parameters on the page. This commit makes the app name a query search parameter, as is the case in the transactions page. Release note: None
xinhaoz
added a commit
to xinhaoz/cockroach
that referenced
this issue
Oct 6, 2021
Fixes: cockroachdb#70790 Previously, the selected app was derived from a route param on the statements page. All other filters are derived from query search parameters on the page. This commit makes the app name a query search parameter, as is the case in the transactions page. Release note: None
xinhaoz
added a commit
to xinhaoz/cockroach
that referenced
this issue
Oct 7, 2021
Fixes: cockroachdb#70790 Previously, the selected app was derived from a route param on the statements page. All other filters are derived from query search parameters on the page. This commit makes the app name a query search parameter, as is the case in the transactions page. Release note: None
xinhaoz
added a commit
to xinhaoz/cockroach
that referenced
this issue
Oct 7, 2021
Fixes: cockroachdb#70790 Previously, the selected app was derived from a route param on the statements page. All other filters are derived from query search parameters on the page. This commit makes the app name a query search parameter, as is the case in the transactions page. Release note: None
xinhaoz
added a commit
to xinhaoz/cockroach
that referenced
this issue
Oct 11, 2021
Fixes: cockroachdb#70790 Previously, the selected app was derived from a route param on the statements page. All other filters are derived from query search parameters on the page. This commit makes the app name a query search parameter, as is the case in the transactions page. Release note: None
craig bot
pushed a commit
that referenced
this issue
Oct 12, 2021
71140: sql: NFC-normalization on double-quoted identifiers r=rafiss a=e-mbrown Resolves: #55396 There was a lack of NFC-normalization on double-quoted identifiers. This allowed for ambiguous table/db/column names. This change adds normalization and prevents this case. Release note: None 71175: ui/cluster-ui: make app name a query search parameter in stmts page r=maryliag,matthewtodd a=xinhaoz Fixes: #70790 Previously, the selected app was derived from a route param on the statements page. All other filters are derived from query search parameters on the page. This commit makes the app name a query search parameter, as is the case in the transactions page. Release note: None 71405: vendor: bump Pebble to 59007c613a66 r=jbowens a=nicktrav ``` 59007c61 sstable: consolidate checksum types 17635b0a *: address staticcheck lints 11823273 *: address staticcheck lint check U1000 807abfe8 *: address staticcheck lint check S1039 d24dd342 all: remove some unused code 3bdca93a sstable: clarify comment on checksum input 926d23e9 pebble: remove comment related to batching from the table cache 0a6177ae db: tweak ErrClosed documentation ecc685b2 db: expose facility for retrieving batch count b2eb88a7 sstable: remove unused rawBlockIter err field ``` Release note: None. 71419: sqlliveness: session expiry callbacks must be async r=ajwerner,jaylim-crl a=dhartunian Previously, the sqlliveness session expiry callbacks were called in the heartbeatLoop thread which executed the renew/expiry logic. This could cause deadlock since session expiration is used to trigger a shutdown of the SQL instance via `stopper.Stop()`. The stopper would wait for all async tasks to quiesce, but the `heartbeatLoop` would continue, waiting for the callbacks to finish running. In addition, this task would hold a lock on `l.mu` while waiting for the callbacks to run causing other threads to wait if they needed to retrieve the session. This change invokes each callback in its own goroutine to prevent this deadlock. Resolves #71292 Release note: None Co-authored-by: e-mbrown <[email protected]> Co-authored-by: Xin Hao Zhang <[email protected]> Co-authored-by: Nick Travers <[email protected]> Co-authored-by: David Hartunian <[email protected]>
nehageorge
pushed a commit
to nehageorge/cockroach
that referenced
this issue
Oct 12, 2021
Fixes: cockroachdb#70790 Previously, the selected app was derived from a route param on the statements page. All other filters are derived from query search parameters on the page. This commit makes the app name a query search parameter, as is the case in the transactions page. Release note: None
ericharmeling
pushed a commit
to ericharmeling/cockroach
that referenced
this issue
Oct 20, 2021
Fixes: cockroachdb#70790 Previously, the selected app was derived from a route param on the statements page. All other filters are derived from query search parameters on the page. This commit makes the app name a query search parameter, as is the case in the transactions page. Release note: None
maryliag
pushed a commit
to maryliag/cockroach
that referenced
this issue
Oct 27, 2021
Fixes: cockroachdb#70790 Previously, the selected app was derived from a route param on the statements page. All other filters are derived from query search parameters on the page. This commit makes the app name a query search parameter, as is the case in the transactions page. Release note: None
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Screen.Recording.2021-09-27.at.13.02.29.mov
The text was updated successfully, but these errors were encountered: