ui: fix default value of filter to All #71567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A recent commit changed the default value of filter to be an empty string, but we do have transactions that have no associated app names to it, so All and empty string should be treated as different cases. This commit reverse that changes and use All Release note (bug fix): Show All statements when filter All is selected and not only the ones with empty string
|
This change is |
matthewtodd
reviewed
Oct 14, 2021
There was a problem hiding this comment.
Looks like the bug was introduced in response to this comment about ?app=all not working in the query string. Does this change preserve the desired behavior there?
Reviewable status:
complete! 0 of 0 LGTMs obtained
maryliag
commented
Oct 14, 2021
There was a problem hiding this comment.
yes, the issue with the comment was that if you pass "all" it doesn't return results, but using "All" or null works, as long as we don't use empty string
Reviewable status:
matthewtodd
approved these changes
Oct 14, 2021
|
bors r+ |
Azhng
approved these changes
Oct 14, 2021
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A recent commit changed the default value of filter
to be an empty string, but we do have transactions that have
no associated app names to it, so All and empty string
should be treated as different cases. This commit reverse
that changes and use All
Release note (bug fix): Show All statements when filter All is
selected and not only the ones with empty string