Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changefeedccl: disable physical plan debug persistence #126085

Merged
merged 1 commit into from
Jun 24, 2024

Conversation

dt
Copy link
Member

@dt dt commented Jun 23, 2024

Mitigation for #126083.

Release note (ops change): Some debugging-only information about physcial plans is no longer collected in the system.job_info table for changefeeds due to it having the potential to grow very large.

Epic: none.

Mitigation for cockroachdb#126083.

Release note (ops change): Some debugging-only information about physcial plans is no longer collected
in the system.job_info table for changefeeds due to it having the potential to grow very large.

Epic: none.
@dt dt requested review from rharding6373 and msbutler June 23, 2024 19:31
@dt dt requested review from a team as code owners June 23, 2024 19:31
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@dt dt added backport-23.1.x Flags PRs that need to be backported to 23.1 backport-23.2.x Flags PRs that need to be backported to 23.2. labels Jun 23, 2024
Copy link
Collaborator

@stevendanna stevendanna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could consider doing this for PCR as well.

@dt
Copy link
Member Author

dt commented Jun 24, 2024

We could consider doing this for PCR as well.

My thinking is this goes to 23.1 and 23.2, but for 24.x onward #126084 is the answer, which will cover releases in which PCR is GA.

@dt
Copy link
Member Author

dt commented Jun 24, 2024

But we can always open another PR for PCR specifically if we change our mind.

TFTR!

bors r+

@craig craig bot merged commit 45a3d8f into cockroachdb:master Jun 24, 2024
22 checks passed
Copy link

blathers-crl bot commented Jun 24, 2024

Encountered an error creating backports. Some common things that can go wrong:

  1. The backport branch might have already existed.
  2. There was a merge conflict.
  3. The backport branch contained merge commits.

You might need to create your backport manually using the backport tool.


error creating merge commit from 4175c6f to blathers/backport-release-23.1-126085: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict []

you may need to manually resolve merge conflicts with the backport tool.

Backport to branch 23.1.x failed. See errors above.


🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@dt
Copy link
Member Author

dt commented Jun 24, 2024

blathers backport 24.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-23.1.x Flags PRs that need to be backported to 23.1 backport-23.2.x Flags PRs that need to be backported to 23.2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants