Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changefeedccl: disable physical plan debug persistence #126085

Merged
merged 1 commit into from
Jun 24, 2024
Merged

changefeedccl: disable physical plan debug persistence #126085

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion pkg/ccl/changefeedccl/changefeed_dist.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -313,7 +313,9 @@ func startDistChangefeed(
finishedSetupFn = func(flowinfra.Flow) { resultsCh <- tree.Datums(nil) }
}

jobsprofiler.StorePlanDiagram(ctx, execCfg.DistSQLSrv.Stopper, p, execCfg.InternalDB, jobID)
if log.V(1) {
jobsprofiler.StorePlanDiagram(ctx, execCfg.DistSQLSrv.Stopper, p, execCfg.InternalDB, jobID)
}

// Make sure to use special changefeed monitor going forward as the
// parent monitor for the DistSQL infrastructure. This is needed to
Expand Down
13 changes: 8 additions & 5 deletions pkg/jobs/jobsprofiler/profiler_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,11 +77,14 @@ func TestProfilerStorePlanDiagram(t *testing.T) {
sql: "RESTORE TABLE foo FROM LATEST IN 'userfile:///foo' WITH into_db='test'",
typ: jobspb.TypeRestore,
},
{
name: "changefeed",
sql: "CREATE CHANGEFEED FOR foo INTO 'null://sink'",
typ: jobspb.TypeChangefeed,
},
/*
TODO(dt): re-enable this once #126083 is fixed.
{
name: "changefeed",
sql: "CREATE CHANGEFEED FOR foo INTO 'null://sink'",
typ: jobspb.TypeChangefeed,
},
*/
} {
t.Run(tc.name, func(t *testing.T) {
_, err := sqlDB.Exec(tc.sql)
Expand Down
Loading