Skip to content

Commit

Permalink
changefeedccl: disable physical plan debug persistence
Browse files Browse the repository at this point in the history
Mitigation for #126083.

Release note (ops change): Some debugging-only information about physcial plans is no longer collected
in the system.job_info table for changefeeds due to it having the potential to grow very large.

Epic: none.
  • Loading branch information
dt committed Jun 23, 2024
1 parent b56e743 commit 4175c6f
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 6 deletions.
4 changes: 3 additions & 1 deletion pkg/ccl/changefeedccl/changefeed_dist.go
Original file line number Diff line number Diff line change
Expand Up @@ -313,7 +313,9 @@ func startDistChangefeed(
finishedSetupFn = func(flowinfra.Flow) { resultsCh <- tree.Datums(nil) }
}

jobsprofiler.StorePlanDiagram(ctx, execCfg.DistSQLSrv.Stopper, p, execCfg.InternalDB, jobID)
if log.V(1) {
jobsprofiler.StorePlanDiagram(ctx, execCfg.DistSQLSrv.Stopper, p, execCfg.InternalDB, jobID)
}

// Make sure to use special changefeed monitor going forward as the
// parent monitor for the DistSQL infrastructure. This is needed to
Expand Down
13 changes: 8 additions & 5 deletions pkg/jobs/jobsprofiler/profiler_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -77,11 +77,14 @@ func TestProfilerStorePlanDiagram(t *testing.T) {
sql: "RESTORE TABLE foo FROM LATEST IN 'userfile:///foo' WITH into_db='test'",
typ: jobspb.TypeRestore,
},
{
name: "changefeed",
sql: "CREATE CHANGEFEED FOR foo INTO 'null://sink'",
typ: jobspb.TypeChangefeed,
},
/*
TODO(dt): re-enable this once #126083 is fixed.
{
name: "changefeed",
sql: "CREATE CHANGEFEED FOR foo INTO 'null://sink'",
typ: jobspb.TypeChangefeed,
},
*/
} {
t.Run(tc.name, func(t *testing.T) {
_, err := sqlDB.Exec(tc.sql)
Expand Down

0 comments on commit 4175c6f

Please sign in to comment.