-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
jobs: limit number of retained dsp-diag-url info rows #126084
Conversation
I've also opened #126085 as a more conservative change for backports to 23.1 and 23.2.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wowzers. I left some minor nits but overall this looks reasonable.
Release note: none. Epic: none.
Release note: none. Epic: none.
6119408
to
f8fa56f
Compare
I'll revert 126085 in a separate PR on master after this lands, since I want to backport this PR -- sans that revert -- to 24.1 where I don't plan to backport the 126085 in the first place. |
Release note: none. Epic: none.
Release note (ops change): Fixed a bug where collection of debug information for very long-running jobs could use excessive space in the job_info system table and/or cause some interactions with the jobs system to become slow. Epic: none.
TFTR! bors r+ |
blathers backport 24.1 |
Now that these are capped by cockroachdb#126084 it is safe to capture new ones unconditionally. Release note: none. Epic: none.
126278: changefeedccl: re-enable diagram storage r=dt a=dt Now that these are capped by #126084 it is safe to capture new ones unconditionally. Release note: none. Epic: none. Co-authored-by: David Taylor <[email protected]>
Fixes #126083.