Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jobs: limit number of retained dsp-diag-url info rows #126084

Merged
merged 4 commits into from
Jun 24, 2024

Conversation

dt
Copy link
Member

@dt dt commented Jun 23, 2024

Fixes #126083.

@dt dt requested a review from msbutler June 23, 2024 19:26
@dt dt requested review from a team as code owners June 23, 2024 19:26
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@dt
Copy link
Member Author

dt commented Jun 23, 2024

I've also opened #126085 as a more conservative change for backports to 23.1 and 23.2.

I'll plan on rebasing this on that PR and adding a revert of it herein after it merges and backports to 23.x.

Copy link
Collaborator

@stevendanna stevendanna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wowzers. I left some minor nits but overall this looks reasonable.

pkg/jobs/job_info_storage.go Outdated Show resolved Hide resolved
pkg/jobs/jobsprofiler/profiler.go Outdated Show resolved Hide resolved
pkg/jobs/jobsprofiler/profiler.go Outdated Show resolved Hide resolved
dt added 2 commits June 24, 2024 12:36
Release note: none.
Epic: none.
Release note: none.
Epic: none.
@dt dt force-pushed the dsp-diag-limit branch 2 times, most recently from 6119408 to f8fa56f Compare June 24, 2024 12:42
@dt
Copy link
Member Author

dt commented Jun 24, 2024

I'll revert 126085 in a separate PR on master after this lands, since I want to backport this PR -- sans that revert -- to 24.1 where I don't plan to backport the 126085 in the first place.

dt added 2 commits June 24, 2024 14:44
Release note (ops change): Fixed a bug where collection of debug information
for very long-running jobs could use excessive space in the job_info system table
and/or cause some interactions with the jobs system to become slow.

Epic: none.
@dt dt force-pushed the dsp-diag-limit branch from f8fa56f to 69b285c Compare June 24, 2024 14:44
@dt
Copy link
Member Author

dt commented Jun 24, 2024

TFTR!

bors r+

@craig craig bot merged commit 6693f4a into cockroachdb:master Jun 24, 2024
22 checks passed
@dt dt deleted the dsp-diag-limit branch June 24, 2024 18:09
@dt
Copy link
Member Author

dt commented Jun 24, 2024

blathers backport 24.1

dt added a commit to dt/cockroach that referenced this pull request Jun 26, 2024
Now that these are capped by cockroachdb#126084 it is safe to capture new ones unconditionally.

Release note: none.
Epic: none.
craig bot pushed a commit that referenced this pull request Jun 26, 2024
126278: changefeedccl: re-enable diagram storage r=dt a=dt

Now that these are capped by #126084 it is safe to capture new ones unconditionally.

Release note: none.
Epic: none.

Co-authored-by: David Taylor <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

jobs: excessive dsp-diag-url profiler rows
4 participants