upgrades: unskip TestIsAtLeastVersionBuiltin #100345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
chengxiong-ruan
approved these changes
Apr 3, 2023
yuzefovich
approved these changes
Apr 3, 2023
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @rafiss)
pkg/upgrade/upgrades/builtins_test.go line 50 at r1 (raw file):
v := clusterversion.ByKey(clusterversion.V23_1Start).String() // Check that the builtin returns false when comparing against 22.1-2
nit: this comment is stale, maybe just remove it?
rafiss
force-pushed
the
unskip-version-at-least-test
branch
from
7aa3c9d to
d5f2934
Compare
Release note: None
rafiss
force-pushed
the
unskip-version-at-least-test
branch
from
d5f2934 to
2189cb0
Compare
|
tftrs! i adjusted the comment bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
informs: #96751
Release note: None