Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sql schema: remove/fix tests that were ignored from bumping minBinary to V22_2 #96751

Closed
2 tasks done
celiala opened this issue Feb 7, 2023 · 1 comment
Closed
2 tasks done

sql schema: remove/fix tests that were ignored from bumping minBinary to V22_2 #96751

celiala opened this issue Feb 7, 2023 · 1 comment
Assignees
@ajwerner
Labels
branch-release-23.1 Used to mark GA and release blockers, technical advisories, and bugs for 23.1 C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) GA-blocker T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions)

Comments

@celiala
Copy link
Collaborator

celiala commented Feb 7, 2023 •
edited by yuzefovich
Loading

In order to bump minBinary to V22_2, we ignored failing tests for future async removal/fixing

This issue is to track removing/fixing tests as needed for SQL Schema:

pkg/sql

  • TestGatingCreateFunction (SQL Schema)

pkg/upgrade/upgrades: (SQL Schema)

Jira issue: CRDB-24309
@celiala celiala added the C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) label Feb 7, 2023
@celiala celiala mentioned this issue Feb 7, 2023
Closed
@celiala celiala added the T-sql-schema-deprecated Use T-sql-foundations instead label Feb 7, 2023
@ajwerner
Copy link
Contributor

This is associated with #96763. Assigning the same folks.

@ajwerner ajwerner added GA-blocker branch-release-23.1 Used to mark GA and release blockers, technical advisories, and bugs for 23.1 labels Feb 21, 2023
chengxiong-ruan added a commit to chengxiong-ruan/cockroach that referenced this issue Feb 27, 2023
@chengxiong-ruan
sql: remove CREATE FUNCTION 22.2 version gate
0d6452e 
Informs: cockroachdb#96763, cockroachdb#96751

Release note: None.
@chengxiong-ruan chengxiong-ruan mentioned this issue Feb 27, 2023
Merged
craig bot pushed a commit that referenced this issue Feb 28, 2023
@chengxiong-ruan
Merge #97760
227aad0 
97760: sql: remove CREATE FUNCTION 22.2 version gate r=chengxiong-ruan a=chengxiong-ruan

Informs: #96763, #96751

Release note: None.

Co-authored-by: Chengxiong Ruan <[email protected]>
@Xiang-Gu Xiang-Gu mentioned this issue Mar 13, 2023
Merged
Xiang-Gu added a commit to Xiang-Gu/cockroach that referenced this issue Mar 13, 2023
@Xiang-Gu
upgrade: Remove two to-be-deleted-V22_2 cluster versions
be31d22 
This commit removed the following two cluster versions and its associated
upgrade logic and tests:
 - V22_2UpgradeSequenceToBeReferencedByID
 - V22_2UpdateInvalidColumnIDsInSequenceBackReferences

Informs: cockroachdb#96763, cockroachdb#96751
Release Note: None
craig bot pushed a commit that referenced this issue Mar 13, 2023
@erikgrinaker @Xiang-Gu @nvanbenschoten
Merge #98491 #98504 #98508
36d39aa 
98491: roachtest: maybe deflake `change-replicas/mixed-version` r=erikgrinaker a=erikgrinaker

Touches #98429.

Epic: none
Release note: None

98504: upgrade: Remove two to-be-deleted-V22_2 cluster versions r=Xiang-Gu a=Xiang-Gu

This commit removed the following two cluster versions and its associated upgrade logic and tests:
 - V22_2UpgradeSequenceToBeReferencedByID
 - V22_2UpdateInvalidColumnIDsInSequenceBackReferences

Informs: #96763, #96751
Release Note: None

98508: kv: deflake TestAbortCountConflictingWrites r=nvanbenschoten a=nvanbenschoten

Fixes #96839.

The test was made flaky by 5129578. See the comment in #96839 (comment) for an explanation.

This commit resolves that flakiness.

Release note: None

Co-authored-by: Erik Grinaker <[email protected]>
Co-authored-by: Xiang Gu <[email protected]>
Co-authored-by: Nathan VanBenschoten <[email protected]>
This was referenced Mar 31, 2023
Merged
Merged
craig bot pushed a commit that referenced this issue Apr 3, 2023
@rafiss @knz
Merge #99934 #100342 #100345 #100484
6a3422b 
99934: changefeedccl: Remove skipped tests that decayed over time r=miretskiy a=miretskiy

Remove
Fixes #32232
Remove TestChangefeedNodeShutdown.  This test has been disabled since 2018; Other tests exist (e.g. `TestChangefeedHandlesDrainingNodes`) that verify restart behavior.

Fixes #51842
Remove BenchmarkChangefeedTicks benchmark.  This benchmark has been skipped since 2019.  Attempts could be made to revive it; however, this benchmark had a lot of code, which accomplished questionable goals. The benchmark itself was unrepresentative (by using dependency injection), too small to be meaningful (1000 rows), and most likely would be too noise and inconclusive.  We have added other micro benchmarks over time; and we conduct large scale testing, including with roachtests.

Release note: None

100342: upgrades: remove migration that waits for schema changes r=rafiss a=rafiss

We can also remove some skipped tests, since they no longer apply.

informs: #96751
Release note: None

100345: upgrades: unskip TestIsAtLeastVersionBuiltin r=rafiss a=rafiss

informs: #96751
Release note: None

100484: server,testutils: add some extra logging for TestStatusEngineStatsJson r=abarganier a=knz

Informs #99261

Release note: None
Epic: None

Co-authored-by: Yevgeniy Miretskiy <[email protected]>
Co-authored-by: Rafi Shamim <[email protected]>
Co-authored-by: Raphael 'kena' Poss <[email protected]>
@blathers-crl blathers-crl bot mentioned this issue Apr 3, 2023
Merged
@rafiss rafiss closed this as completed Apr 3, 2023
@exalate-issue-sync exalate-issue-sync bot removed the T-sql-schema-deprecated Use T-sql-foundations instead label May 10, 2023
@exalate-issue-sync exalate-issue-sync bot added the T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions) label May 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ajwerner ajwerner

Labels
branch-release-23.1 Used to mark GA and release blockers, technical advisories, and bugs for 23.1 C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) GA-blocker T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@rafiss @ajwerner @celiala @chengxiong-ruan @Xiang-Gu