Merge #99934 #100342 #100345 #100484

99934: changefeedccl: Remove skipped tests that decayed over time r=miretskiy a=miretskiy Remove Fixes #32232 Remove TestChangefeedNodeShutdown. This test has been disabled since 2018; Other tests exist (e.g. `TestChangefeedHandlesDrainingNodes`) that verify restart behavior. Fixes #51842 Remove BenchmarkChangefeedTicks benchmark. This benchmark has been skipped since 2019. Attempts could be made to revive it; however, this benchmark had a lot of code, which accomplished questionable goals. The benchmark itself was unrepresentative (by using dependency injection), too small to be meaningful (1000 rows), and most likely would be too noise and inconclusive. We have added other micro benchmarks over time; and we conduct large scale testing, including with roachtests. Release note: None 100342: upgrades: remove migration that waits for schema changes r=rafiss a=rafiss We can also remove some skipped tests, since they no longer apply. informs: #96751 Release note: None 100345: upgrades: unskip TestIsAtLeastVersionBuiltin r=rafiss a=rafiss informs: #96751 Release note: None 100484: server,testutils: add some extra logging for TestStatusEngineStatsJson r=abarganier a=knz Informs #99261 Release note: None Epic: None Co-authored-by: Yevgeniy Miretskiy <[email protected]> Co-authored-by: Rafi Shamim <[email protected]> Co-authored-by: Raphael 'kena' Poss <[email protected]>
cockroachdb · Apr 3, 2023 · 6a3422b · 6a3422b
5 parents 3e452a4 + 2b40c5e + ccea76c + 2189cb0 + a503765
commit 6a3422b
Show file tree

Hide file tree

Showing 12 changed files with 30 additions and 888 deletions.
diff --git a/pkg/ccl/changefeedccl/BUILD.bazel b/pkg/ccl/changefeedccl/BUILD.bazel
@@ -179,7 +179,6 @@ go_test(
     srcs = [
         "alter_changefeed_test.go",
         "avro_test.go",
-        "bench_test.go",
         "changefeed_test.go",
         "csv_test.go",
         "encoder_test.go",
@@ -212,8 +211,6 @@ go_test(
         "//pkg/ccl/changefeedccl/changefeedbase",
         "//pkg/ccl/changefeedccl/changefeedpb",
         "//pkg/ccl/changefeedccl/kvevent",
-        "//pkg/ccl/changefeedccl/kvfeed",
-        "//pkg/ccl/changefeedccl/schemafeed",
         "//pkg/ccl/kvccl/kvtenantccl",
         "//pkg/ccl/multiregionccl",
         "//pkg/ccl/multiregionccl/multiregionccltestutils",
@@ -222,7 +219,6 @@ go_test(
         "//pkg/ccl/utilccl",
         "//pkg/cloud",
         "//pkg/cloud/impl:cloudimpl",
-        "//pkg/gossip",
         "//pkg/internal/sqlsmith",
         "//pkg/jobs",
         "//pkg/jobs/jobspb",
@@ -276,8 +272,6 @@ go_test(
         "//pkg/sql/sem/volatility",
         "//pkg/sql/sessiondata",
         "//pkg/sql/sessiondatapb",
-        "//pkg/sql/sqlliveness",
-        "//pkg/sql/sqlliveness/sqllivenesstestutils",
         "//pkg/sql/tests",
         "//pkg/sql/types",
         "//pkg/storage",
@@ -305,7 +299,6 @@ go_test(
         "//pkg/util/timeutil",
         "//pkg/util/timeutil/pgdate",
         "//pkg/util/uuid",
-        "//pkg/workload",
         "//pkg/workload/bank",
         "//pkg/workload/ledger",
         "//pkg/workload/workloadsql",