Skip to content

Commit

Permalink
upgrades: unskip TestIsAtLeastVersionBuiltin
Browse files Browse the repository at this point in the history
Release note: None
  • Loading branch information
rafiss committed Apr 3, 2023
1 parent 2e56a48 commit 2189cb0
Showing 1 changed file with 4 additions and 7 deletions.
11 changes: 4 additions & 7 deletions pkg/upgrade/upgrades/builtins_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@ import (
"github.com/cockroachdb/cockroach/pkg/base"
"github.com/cockroachdb/cockroach/pkg/clusterversion"
"github.com/cockroachdb/cockroach/pkg/server"
"github.com/cockroachdb/cockroach/pkg/testutils/skip"
"github.com/cockroachdb/cockroach/pkg/testutils/sqlutils"
"github.com/cockroachdb/cockroach/pkg/testutils/testcluster"
"github.com/cockroachdb/cockroach/pkg/util/leaktest"
Expand All @@ -28,14 +27,12 @@ func TestIsAtLeastVersionBuiltin(t *testing.T) {
defer leaktest.AfterTest(t)()
defer log.Scope(t).Close(t)

skip.WithIssue(t, 95530, "bump minBinary to 22.2. Skip 22.2 mixed-version tests for future cleanup")

clusterArgs := base.TestClusterArgs{
ServerArgs: base.TestServerArgs{
Knobs: base.TestingKnobs{
Server: &server.TestingKnobs{
DisableAutomaticVersionUpgrade: make(chan struct{}),
BinaryVersionOverride: clusterversion.ByKey(clusterversion.TODODelete_V22_1),
BinaryVersionOverride: clusterversion.ByKey(clusterversion.V22_2),
},
},
},
Expand All @@ -49,9 +46,9 @@ func TestIsAtLeastVersionBuiltin(t *testing.T) {
)
defer tc.Stopper().Stop(ctx)

v := clusterversion.ByKey(clusterversion.TODODelete_V22_2Start).String()
// Check that the builtin returns false when comparing against 22.1-2
// version because we are still on 22.1-0.
v := clusterversion.ByKey(clusterversion.V23_1Start).String()
// Check that the builtin returns false when comparing against the new version
// version because we are still on the bootstrap version.
sqlDB.CheckQueryResults(t, "SELECT crdb_internal.is_at_least_version('"+v+"')", [][]string{{"false"}})

// Run the upgrade.
Expand Down

0 comments on commit 2189cb0

Please sign in to comment.