Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ui: change table sort setting on applying new search criteria #99397

Open
xinhaoz opened this issue Mar 23, 2023 · 0 comments · Fixed by #99541
Open

ui: change table sort setting on applying new search criteria #99397

xinhaoz opened this issue Mar 23, 2023 · 0 comments · Fixed by #99541
Assignees
@maryliag
Labels
A-cluster-observability Related to cluster observability C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. T-observability

Comments

@xinhaoz
Copy link
Member

xinhaoz commented Mar 23, 2023 •
edited by maryliag
Loading

With the new search criteria experience, we now apply a server sort (e.g. retrieve top-k by CPU Time, Service Latency etc). When the settings are applied, we should change the current table sort to the applied sort setting so that when results are returned they are ordered by the sort setting in the table.

When a column that is not the "initial" one is selected, a warning should also be added.

Jira issue: CRDB-25862
@xinhaoz xinhaoz added C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. A-cluster-observability Related to cluster observability labels Mar 23, 2023
@maryliag maryliag self-assigned this Mar 24, 2023
@maryliag maryliag mentioned this issue Mar 25, 2023
Merged
maryliag added a commit to maryliag/cockroach that referenced this issue Mar 27, 2023
@maryliag
ui: update sort setting on search criteria
f2e448e 
Fixes cockroachdb#99397
When a new search criteria is applying, the table on Statement
and Transactions are sorted to match the value selected by the
search criteria.
When a new column is selected on the table, a warning is displayed
to let the users know they're looking into a subset od the data.
If the new column selected is one of the options on the search
criteria, we give a suggestion to update the search criteria with
that value instead.

This commit adds the counter per page on the Statement
and Transaction tables.

This commit also adds analytics to the apply button,
sending the information about each criteria.

Release note (ui change): Add a warning when a user select a sorting
column on Statement and Transaction tables that were not the original
selected sorting on the search criteria.
craig bot pushed a commit that referenced this issue Mar 28, 2023
@maryliag @ericharmeling @itsbilal
Merge #99541 #99674 #99695
143b63a 
99541: ui: update sort setting on search criteria r=maryliag a=maryliag

Fixes #99397

When a new search criteria is applied, the table on Statement and Transactions are sorted to match the value selected by the search criteria.
When a new column is selected on the table, a warning is displayed to let the users know they're looking into a subset od the data. If the new column selected is one of the options on the search criteria, we give a suggestion to update the search criteria with that value instead.

<img width="1229" alt="Screenshot 2023-03-24 at 8 27 52 PM" src="https://user-images.githubusercontent.com/1017486/227667529-14c9dc5c-dc00-4dd9-b12d-78058c381fc4.png">

https://www.loom.com/share/e123e4033d95434a8eef20c257c83bbd

This commit adds the counter per page on the Statement and Transaction tables.
<img width="705" alt="Screenshot 2023-03-24 at 8 28 01 PM" src="https://user-images.githubusercontent.com/1017486/227667540-bc7aae81-2121-46c1-ad01-94ceda34960b.png">


This commit also adds analytics to the apply button, sending the information about each criteria.

Release note (ui change): Add a warning when a user select a sorting column on Statement and Transaction tables that were not the original selected sorting on the search criteria.

99674: sql: add explicit column family assignments to persisted stats upgrades r=ericharmeling a=ericharmeling

Fixes #99270.
Part of #99260.

This commit adds explicit column family assignments to the computed column `ADD COLUMN` statements for
system.statement_statistics and system.transaction_statistics version upgrades.

Epic: none

Release note: None

99695: storage: CheckSSTConflicts: fix instance of iterator mismatch r=RaduBerinde a=itsbilal

Previously, in one case, we'd let the sst iterator advance ahead of the engine iterator, which violates an invariant in this function. This change fixes that case.

Fixes #99566.
Fixes #99010.

Epic: none

Release note: None

Co-authored-by: maryliag <[email protected]>
Co-authored-by: Eric Harmeling <[email protected]>
Co-authored-by: Bilal Akhtar <[email protected]>
@craig craig bot closed this as completed in 810547c Mar 28, 2023
maryliag added a commit to maryliag/cockroach that referenced this issue Mar 28, 2023
@maryliag
ui: update sort setting on search criteria
04020f8 
Fixes cockroachdb#99397
When a new search criteria is applying, the table on Statement
and Transactions are sorted to match the value selected by the
search criteria.
When a new column is selected on the table, a warning is displayed
to let the users know they're looking into a subset od the data.
If the new column selected is one of the options on the search
criteria, we give a suggestion to update the search criteria with
that value instead.

This commit adds the counter per page on the Statement
and Transaction tables.

This commit also adds analytics to the apply button,
sending the information about each criteria.

Release note (ui change): Add a warning when a user select a sorting
column on Statement and Transaction tables that were not the original
selected sorting on the search criteria.
@maryliag maryliag mentioned this issue Mar 28, 2023
Merged
maryliag added a commit to maryliag/cockroach that referenced this issue Apr 10, 2023
@maryliag
ui: update sort setting on search criteria
c92d0d9 
Fixes cockroachdb#99397
When a new search criteria is applying, the table on Statement
and Transactions are sorted to match the value selected by the
search criteria.
When a new column is selected on the table, a warning is displayed
to let the users know they're looking into a subset od the data.
If the new column selected is one of the options on the search
criteria, we give a suggestion to update the search criteria with
that value instead.

This commit adds the counter per page on the Statement
and Transaction tables.

This commit also adds analytics to the apply button,
sending the information about each criteria.

Release note (ui change): Add a warning when a user select a sorting
column on Statement and Transaction tables that were not the original
selected sorting on the search criteria.
maryliag added a commit to maryliag/cockroach that referenced this issue Apr 10, 2023
@maryliag
ui: update sort setting on search criteria
7355765 
Fixes cockroachdb#99397
When a new search criteria is applying, the table on Statement
and Transactions are sorted to match the value selected by the
search criteria.
When a new column is selected on the table, a warning is displayed
to let the users know they're looking into a subset od the data.
If the new column selected is one of the options on the search
criteria, we give a suggestion to update the search criteria with
that value instead.

This commit adds the counter per page on the Statement
and Transaction tables.

This commit also adds analytics to the apply button,
sending the information about each criteria.

Release note (ui change): Add a warning when a user select a sorting
column on Statement and Transaction tables that were not the original
selected sorting on the search criteria.
@exalate-issue-sync exalate-issue-sync bot reopened this Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@maryliag maryliag

Labels
A-cluster-observability Related to cluster observability C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. T-observability
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ui: update sort setting on search criteria maryliag/cockroach
2 participants
@maryliag @xinhaoz