-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sql: add explicit column family assignments to persisted stats upgrades #99674
sql: add explicit column family assignments to persisted stats upgrades #99674
Conversation
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed all commit messages.
Reviewable status: complete! 0 of 0 LGTMs obtained (waiting on @ericharmeling)
pkg/upgrade/upgrades/create_computed_indexes_sql_statistics.go
line 155 at r1 (raw file):
` const addP99LatencyComputedColTxnStats = `
Can the upgrade test validate the family? Trying to think of some way to test this.
Part of cockroachdb#99260. This commit adds explicit column family assignments to the computed column `ADD COLUMN` statements for system.statement_statistics and system.transaction_statistics version upgrades. Epic: none Release note: None
14b6b42
to
8c5aee8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: complete! 0 of 0 LGTMs obtained (waiting on @j82w)
pkg/upgrade/upgrades/create_computed_indexes_sql_statistics.go
line 155 at r1 (raw file):
Previously, j82w (Jake) wrote…
Can the upgrade test validate the family? Trying to think of some way to test this.
I ran the systemschema
roach test, which runs in the nightly (how this was caught in the first place). Here's the output (it passes now): systemschema_test_log.txt
Unfortunately, it looks like that's not caught by CI tests, which is how this didn't get caught in the first place.
So I've added another test validation function to TestCreateComputedIndexesOnSystemSQLStatistics
that fails on master and succeeds on this branch.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r1, 3 of 3 files at r2, all commit messages.
Reviewable status: complete! 1 of 0 LGTMs obtained (waiting on @ericharmeling)
bors r+ |
Build failed (retrying...): |
Build succeeded: |
Encountered an error creating backports. Some common things that can go wrong:
You might need to create your backport manually using the backport tool. Backport to branch 23.1.x failed. See errors above. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
Fixes #99270.
Part of #99260.
This commit adds explicit column family assignments to the computed column
ADD COLUMN
statements forsystem.statement_statistics and system.transaction_statistics version upgrades.
Epic: none
Release note: None