Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

roachtest: systemschema/validate-after-version-upgrade failed #99270

Closed
cockroach-teamcity opened this issue Mar 22, 2023 · 6 comments · Fixed by #99674
Closed

roachtest: systemschema/validate-after-version-upgrade failed #99270

cockroach-teamcity opened this issue Mar 22, 2023 · 6 comments · Fixed by #99674
Assignees
@ericharmeling
Labels
branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-roachtest O-robot Originated from a bot. release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked.
Milestone
23.1

Comments

@cockroach-teamcity
Copy link
Member

cockroach-teamcity commented Mar 22, 2023 •
edited by cockroach-jira-scripts
Loading

roachtest.systemschema/validate-after-version-upgrade failed with artifacts on master @ 78bb7696847e1d8abf5d6a199c6dd3414a568691:

 	contention_time FLOAT8 NULL AS ((((statistics->'execution_statistics':::STRING)->'contentionTime':::STRING)->'mean':::STRING)::FLOAT8) STORED,
-	total_estimated_execution_time FLOAT8 NULL AS (((statistics->'statistics':::STRING)->'cnt':::STRING)::FLOAT8 * (((statistics->'statistics':::STRING)->'svcLat':::STRING)->>'mean':::STRING)::FLOAT8) STORED,
+	total_estimated_execution_time FLOAT8 NULL AS (((statistics->'statistics':::STRING)->>'cnt':::STRING)::FLOAT8 * (((statistics->'statistics':::STRING)->'svcLat':::STRING)->>'mean':::STRING)::FLOAT8) STORED,
 	CONSTRAINT "primary" PRIMARY KEY (aggregated_ts ASC, fingerprint_id ASC, transaction_fingerprint_id ASC, plan_hash ASC, app_name ASC, node_id ASC) USING HASH WITH (bucket_count=8),
 	INDEX fingerprint_stats_idx (fingerprint_id ASC, transaction_fingerprint_id ASC),
 	INVERTED INDEX indexes_usage_idx (indexes_usage),
 	INDEX execution_count_idx (aggregated_ts ASC, app_name ASC, execution_count DESC) WHERE app_name NOT LIKE '$ internal%':::STRING,
 	INDEX service_latency_idx (aggregated_ts ASC, app_name ASC, service_latency DESC) WHERE app_name NOT LIKE '$ internal%':::STRING,
 	INDEX cpu_sql_nanos_idx (aggregated_ts ASC, app_name ASC, cpu_sql_nanos DESC) WHERE app_name NOT LIKE '$ internal%':::STRING,
 	INDEX contention_time_idx (aggregated_ts ASC, app_name ASC, contention_time DESC) WHERE app_name NOT LIKE '$ internal%':::STRING,
-	INDEX total_estimated_execution_time_idx (aggregated_ts ASC, app_name ASC, total_estimated_execution_time DESC) WHERE app_name NOT LIKE '$ internal%':::STRING
+	INDEX total_estimated_execution_time_idx (aggregated_ts ASC, app_name ASC, total_estimated_execution_time DESC) WHERE app_name NOT LIKE '$ internal%':::STRING,
+	FAMILY "primary" (crdb_internal_aggregated_ts_app_name_fingerprint_id_node_id_plan_hash_transaction_fingerprint_id_shard_8, aggregated_ts, fingerprint_id, transaction_fingerprint_id, plan_hash, app_name, node_id, agg_interval, metadata, statistics, plan, index_recommendations),
+	FAMILY fam_14_execution_count (execution_count),
+	FAMILY fam_15_service_latency (service_latency),
+	FAMILY fam_16_cpu_sql_nanos (cpu_sql_nanos),
+	FAMILY fam_17_contention_time (contention_time),
+	FAMILY fam_18_total_estimated_execution_time (total_estimated_execution_time)
 );
 CREATE TABLE public.transaction_statistics (
 	aggregated_ts TIMESTAMPTZ NOT NULL,
 	fingerprint_id BYTES NOT NULL,
 	app_name STRING NOT NULL,
@@ -353,18 +359,24 @@
 	crdb_internal_aggregated_ts_app_name_fingerprint_id_node_id_shard_8 INT4 NOT VISIBLE NOT NULL AS (mod(fnv32(crdb_internal.datums_to_bytes(aggregated_ts, app_name, fingerprint_id, node_id)), 8:::INT8)) STORED,
 	execution_count INT8 NULL AS (((statistics->'statistics':::STRING)->'cnt':::STRING)::INT8) STORED,
 	service_latency FLOAT8 NULL AS ((((statistics->'statistics':::STRING)->'svcLat':::STRING)->'mean':::STRING)::FLOAT8) STORED,
 	cpu_sql_nanos FLOAT8 NULL AS ((((statistics->'execution_statistics':::STRING)->'cpuSQLNanos':::STRING)->'mean':::STRING)::FLOAT8) STORED,
 	contention_time FLOAT8 NULL AS ((((statistics->'execution_statistics':::STRING)->'contentionTime':::STRING)->'mean':::STRING)::FLOAT8) STORED,
-	total_estimated_execution_time FLOAT8 NULL AS (((statistics->'statistics':::STRING)->'cnt':::STRING)::FLOAT8 * (((statistics->'statistics':::STRING)->'svcLat':::STRING)->>'mean':::STRING)::FLOAT8) STORED,
+	total_estimated_execution_time FLOAT8 NULL AS (((statistics->'statistics':::STRING)->>'cnt':::STRING)::FLOAT8 * (((statistics->'statistics':::STRING)->'svcLat':::STRING)->>'mean':::STRING)::FLOAT8) STORED,
 	CONSTRAINT "primary" PRIMARY KEY (aggregated_ts ASC, fingerprint_id ASC, app_name ASC, node_id ASC) USING HASH WITH (bucket_count=8),
 	INDEX fingerprint_stats_idx (fingerprint_id ASC),
 	INDEX execution_count_idx (aggregated_ts ASC, app_name ASC, execution_count DESC) WHERE app_name NOT LIKE '$ internal%':::STRING,
 	INDEX service_latency_idx (aggregated_ts ASC, app_name ASC, service_latency DESC) WHERE app_name NOT LIKE '$ internal%':::STRING,
 	INDEX cpu_sql_nanos_idx (aggregated_ts ASC, app_name ASC, cpu_sql_nanos DESC) WHERE app_name NOT LIKE '$ internal%':::STRING,
 	INDEX contention_time_idx (aggregated_ts ASC, app_name ASC, contention_time DESC) WHERE app_name NOT LIKE '$ internal%':::STRING,
-	INDEX total_estimated_execution_time_idx (aggregated_ts ASC, app_name ASC, total_estimated_execution_time DESC) WHERE app_name NOT LIKE '$ internal%':::STRING
+	INDEX total_estimated_execution_time_idx (aggregated_ts ASC, app_name ASC, total_estimated_execution_time DESC) WHERE app_name NOT LIKE '$ internal%':::STRING,
+	FAMILY "primary" (crdb_internal_aggregated_ts_app_name_fingerprint_id_node_id_shard_8, aggregated_ts, fingerprint_id, app_name, node_id, agg_interval, metadata, statistics),
+	FAMILY fam_9_execution_count (execution_count),
+	FAMILY fam_10_service_latency (service_latency),
+	FAMILY fam_11_cpu_sql_nanos (cpu_sql_nanos),
+	FAMILY fam_12_contention_time (contention_time),
+	FAMILY fam_13_total_estimated_execution_time (total_estimated_execution_time)
 );
 CREATE TABLE public.database_role_settings (
 	database_id OID NOT NULL,
 	role_name STRING NOT NULL,
 	settings STRING[] NOT NULL,

Parameters: ROACHTEST_cloud=gce , ROACHTEST_cpu=4 , ROACHTEST_encrypted=false , ROACHTEST_ssd=0

Help

See: roachtest README

See: How To Investigate (internal)

Same failure on other branches

/cc @cockroachdb/sql-schema

This test on roachdash | Improve this report!

Jira issue: CRDB-25866
@cockroach-teamcity cockroach-teamcity added branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-roachtest O-robot Originated from a bot. release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked. labels Mar 22, 2023
@cockroach-teamcity cockroach-teamcity added this to the 23.1 milestone Mar 22, 2023
@blathers-crl blathers-crl bot added the T-sql-schema-deprecated Use T-sql-foundations instead label Mar 22, 2023
@rafiss
Copy link
Collaborator

rafiss commented Mar 23, 2023

Seems related to b6d5bb7; cc @j82w

@rafiss rafiss removed the T-sql-schema-deprecated Use T-sql-foundations instead label Mar 23, 2023
@cockroach-teamcity cockroach-teamcity mentioned this issue Mar 23, 2023
Closed
@cockroach-teamcity
Copy link
Member Author

roachtest.systemschema/validate-after-version-upgrade failed with artifacts on master @ 5493fdfec4e1762c4502fb2f5d42fd28292c9c9d:

 	INVERTED INDEX indexes_usage_idx (indexes_usage),
 	INDEX execution_count_idx (aggregated_ts ASC, app_name ASC, execution_count DESC) WHERE app_name NOT LIKE '$ internal%':::STRING,
 	INDEX service_latency_idx (aggregated_ts ASC, app_name ASC, service_latency DESC) WHERE app_name NOT LIKE '$ internal%':::STRING,
 	INDEX cpu_sql_nanos_idx (aggregated_ts ASC, app_name ASC, cpu_sql_nanos DESC) WHERE app_name NOT LIKE '$ internal%':::STRING,
 	INDEX contention_time_idx (aggregated_ts ASC, app_name ASC, contention_time DESC) WHERE app_name NOT LIKE '$ internal%':::STRING,
 	INDEX total_estimated_execution_time_idx (aggregated_ts ASC, app_name ASC, total_estimated_execution_time DESC) WHERE app_name NOT LIKE '$ internal%':::STRING,
-	INDEX p99_latency_idx (aggregated_ts ASC, app_name ASC, p99_latency DESC) WHERE app_name NOT LIKE '$ internal%':::STRING
+	INDEX p99_latency_idx (aggregated_ts ASC, app_name ASC, p99_latency DESC) WHERE app_name NOT LIKE '$ internal%':::STRING,
+	FAMILY "primary" (crdb_internal_aggregated_ts_app_name_fingerprint_id_node_id_plan_hash_transaction_fingerprint_id_shard_8, aggregated_ts, fingerprint_id, transaction_fingerprint_id, plan_hash, app_name, node_id, agg_interval, metadata, statistics, plan, index_recommendations),
+	FAMILY fam_14_execution_count (execution_count),
+	FAMILY fam_15_service_latency (service_latency),
+	FAMILY fam_16_cpu_sql_nanos (cpu_sql_nanos),
+	FAMILY fam_17_contention_time (contention_time),
+	FAMILY fam_18_total_estimated_execution_time (total_estimated_execution_time),
+	FAMILY fam_19_p99_latency (p99_latency)
 );
 CREATE TABLE public.transaction_statistics (
 	aggregated_ts TIMESTAMPTZ NOT NULL,
 	fingerprint_id BYTES NOT NULL,
 	app_name STRING NOT NULL,
@@ -355,20 +362,27 @@
 	crdb_internal_aggregated_ts_app_name_fingerprint_id_node_id_shard_8 INT4 NOT VISIBLE NOT NULL AS (mod(fnv32(crdb_internal.datums_to_bytes(aggregated_ts, app_name, fingerprint_id, node_id)), 8:::INT8)) STORED,
 	execution_count INT8 NULL AS (((statistics->'statistics':::STRING)->'cnt':::STRING)::INT8) STORED,
 	service_latency FLOAT8 NULL AS ((((statistics->'statistics':::STRING)->'svcLat':::STRING)->'mean':::STRING)::FLOAT8) STORED,
 	cpu_sql_nanos FLOAT8 NULL AS ((((statistics->'execution_statistics':::STRING)->'cpuSQLNanos':::STRING)->'mean':::STRING)::FLOAT8) STORED,
 	contention_time FLOAT8 NULL AS ((((statistics->'execution_statistics':::STRING)->'contentionTime':::STRING)->'mean':::STRING)::FLOAT8) STORED,
-	total_estimated_execution_time FLOAT8 NULL AS (((statistics->'statistics':::STRING)->'cnt':::STRING)::FLOAT8 * (((statistics->'statistics':::STRING)->'svcLat':::STRING)->>'mean':::STRING)::FLOAT8) STORED,
+	total_estimated_execution_time FLOAT8 NULL AS (((statistics->'statistics':::STRING)->>'cnt':::STRING)::FLOAT8 * (((statistics->'statistics':::STRING)->'svcLat':::STRING)->>'mean':::STRING)::FLOAT8) STORED,
 	p99_latency FLOAT8 NULL AS ((((statistics->'statistics':::STRING)->'latencyInfo':::STRING)->'p99':::STRING)::FLOAT8) STORED,
 	CONSTRAINT "primary" PRIMARY KEY (aggregated_ts ASC, fingerprint_id ASC, app_name ASC, node_id ASC) USING HASH WITH (bucket_count=8),
 	INDEX fingerprint_stats_idx (fingerprint_id ASC),
 	INDEX execution_count_idx (aggregated_ts ASC, app_name ASC, execution_count DESC) WHERE app_name NOT LIKE '$ internal%':::STRING,
 	INDEX service_latency_idx (aggregated_ts ASC, app_name ASC, service_latency DESC) WHERE app_name NOT LIKE '$ internal%':::STRING,
 	INDEX cpu_sql_nanos_idx (aggregated_ts ASC, app_name ASC, cpu_sql_nanos DESC) WHERE app_name NOT LIKE '$ internal%':::STRING,
 	INDEX contention_time_idx (aggregated_ts ASC, app_name ASC, contention_time DESC) WHERE app_name NOT LIKE '$ internal%':::STRING,
 	INDEX total_estimated_execution_time_idx (aggregated_ts ASC, app_name ASC, total_estimated_execution_time DESC) WHERE app_name NOT LIKE '$ internal%':::STRING,
-	INDEX p99_latency_idx (aggregated_ts ASC, app_name ASC, p99_latency DESC) WHERE app_name NOT LIKE '$ internal%':::STRING
+	INDEX p99_latency_idx (aggregated_ts ASC, app_name ASC, p99_latency DESC) WHERE app_name NOT LIKE '$ internal%':::STRING,
+	FAMILY "primary" (crdb_internal_aggregated_ts_app_name_fingerprint_id_node_id_shard_8, aggregated_ts, fingerprint_id, app_name, node_id, agg_interval, metadata, statistics),
+	FAMILY fam_9_execution_count (execution_count),
+	FAMILY fam_10_service_latency (service_latency),
+	FAMILY fam_11_cpu_sql_nanos (cpu_sql_nanos),
+	FAMILY fam_12_contention_time (contention_time),
+	FAMILY fam_13_total_estimated_execution_time (total_estimated_execution_time),
+	FAMILY fam_14_p99_latency (p99_latency)
 );
 CREATE TABLE public.database_role_settings (
 	database_id OID NOT NULL,
 	role_name STRING NOT NULL,
 	settings STRING[] NOT NULL,

Parameters: ROACHTEST_cloud=gce , ROACHTEST_cpu=4 , ROACHTEST_encrypted=false , ROACHTEST_fs=ext4 , ROACHTEST_localSSD=true , ROACHTEST_ssd=0

Help

See: roachtest README

See: How To Investigate (internal)

Same failure on other branches

This test on roachdash | Improve this report!

@cockroach-teamcity
Copy link
Member Author

roachtest.systemschema/validate-after-version-upgrade failed with artifacts on master @ 19a6b804d3aff74d74619a75cac3b52338c7aa02:

 	INVERTED INDEX indexes_usage_idx (indexes_usage),
 	INDEX execution_count_idx (aggregated_ts ASC, app_name ASC, execution_count DESC) WHERE app_name NOT LIKE '$ internal%':::STRING,
 	INDEX service_latency_idx (aggregated_ts ASC, app_name ASC, service_latency DESC) WHERE app_name NOT LIKE '$ internal%':::STRING,
 	INDEX cpu_sql_nanos_idx (aggregated_ts ASC, app_name ASC, cpu_sql_nanos DESC) WHERE app_name NOT LIKE '$ internal%':::STRING,
 	INDEX contention_time_idx (aggregated_ts ASC, app_name ASC, contention_time DESC) WHERE app_name NOT LIKE '$ internal%':::STRING,
 	INDEX total_estimated_execution_time_idx (aggregated_ts ASC, app_name ASC, total_estimated_execution_time DESC) WHERE app_name NOT LIKE '$ internal%':::STRING,
-	INDEX p99_latency_idx (aggregated_ts ASC, app_name ASC, p99_latency DESC) WHERE app_name NOT LIKE '$ internal%':::STRING
+	INDEX p99_latency_idx (aggregated_ts ASC, app_name ASC, p99_latency DESC) WHERE app_name NOT LIKE '$ internal%':::STRING,
+	FAMILY "primary" (crdb_internal_aggregated_ts_app_name_fingerprint_id_node_id_plan_hash_transaction_fingerprint_id_shard_8, aggregated_ts, fingerprint_id, transaction_fingerprint_id, plan_hash, app_name, node_id, agg_interval, metadata, statistics, plan, index_recommendations),
+	FAMILY fam_14_execution_count (execution_count),
+	FAMILY fam_15_service_latency (service_latency),
+	FAMILY fam_16_cpu_sql_nanos (cpu_sql_nanos),
+	FAMILY fam_17_contention_time (contention_time),
+	FAMILY fam_18_total_estimated_execution_time (total_estimated_execution_time),
+	FAMILY fam_19_p99_latency (p99_latency)
 );
 CREATE TABLE public.transaction_statistics (
 	aggregated_ts TIMESTAMPTZ NOT NULL,
 	fingerprint_id BYTES NOT NULL,
 	app_name STRING NOT NULL,
@@ -355,20 +362,27 @@
 	crdb_internal_aggregated_ts_app_name_fingerprint_id_node_id_shard_8 INT4 NOT VISIBLE NOT NULL AS (mod(fnv32(crdb_internal.datums_to_bytes(aggregated_ts, app_name, fingerprint_id, node_id)), 8:::INT8)) STORED,
 	execution_count INT8 NULL AS (((statistics->'statistics':::STRING)->'cnt':::STRING)::INT8) STORED,
 	service_latency FLOAT8 NULL AS ((((statistics->'statistics':::STRING)->'svcLat':::STRING)->'mean':::STRING)::FLOAT8) STORED,
 	cpu_sql_nanos FLOAT8 NULL AS ((((statistics->'execution_statistics':::STRING)->'cpuSQLNanos':::STRING)->'mean':::STRING)::FLOAT8) STORED,
 	contention_time FLOAT8 NULL AS ((((statistics->'execution_statistics':::STRING)->'contentionTime':::STRING)->'mean':::STRING)::FLOAT8) STORED,
-	total_estimated_execution_time FLOAT8 NULL AS (((statistics->'statistics':::STRING)->'cnt':::STRING)::FLOAT8 * (((statistics->'statistics':::STRING)->'svcLat':::STRING)->>'mean':::STRING)::FLOAT8) STORED,
+	total_estimated_execution_time FLOAT8 NULL AS (((statistics->'statistics':::STRING)->>'cnt':::STRING)::FLOAT8 * (((statistics->'statistics':::STRING)->'svcLat':::STRING)->>'mean':::STRING)::FLOAT8) STORED,
 	p99_latency FLOAT8 NULL AS ((((statistics->'statistics':::STRING)->'latencyInfo':::STRING)->'p99':::STRING)::FLOAT8) STORED,
 	CONSTRAINT "primary" PRIMARY KEY (aggregated_ts ASC, fingerprint_id ASC, app_name ASC, node_id ASC) USING HASH WITH (bucket_count=8),
 	INDEX fingerprint_stats_idx (fingerprint_id ASC),
 	INDEX execution_count_idx (aggregated_ts ASC, app_name ASC, execution_count DESC) WHERE app_name NOT LIKE '$ internal%':::STRING,
 	INDEX service_latency_idx (aggregated_ts ASC, app_name ASC, service_latency DESC) WHERE app_name NOT LIKE '$ internal%':::STRING,
 	INDEX cpu_sql_nanos_idx (aggregated_ts ASC, app_name ASC, cpu_sql_nanos DESC) WHERE app_name NOT LIKE '$ internal%':::STRING,
 	INDEX contention_time_idx (aggregated_ts ASC, app_name ASC, contention_time DESC) WHERE app_name NOT LIKE '$ internal%':::STRING,
 	INDEX total_estimated_execution_time_idx (aggregated_ts ASC, app_name ASC, total_estimated_execution_time DESC) WHERE app_name NOT LIKE '$ internal%':::STRING,
-	INDEX p99_latency_idx (aggregated_ts ASC, app_name ASC, p99_latency DESC) WHERE app_name NOT LIKE '$ internal%':::STRING
+	INDEX p99_latency_idx (aggregated_ts ASC, app_name ASC, p99_latency DESC) WHERE app_name NOT LIKE '$ internal%':::STRING,
+	FAMILY "primary" (crdb_internal_aggregated_ts_app_name_fingerprint_id_node_id_shard_8, aggregated_ts, fingerprint_id, app_name, node_id, agg_interval, metadata, statistics),
+	FAMILY fam_9_execution_count (execution_count),
+	FAMILY fam_10_service_latency (service_latency),
+	FAMILY fam_11_cpu_sql_nanos (cpu_sql_nanos),
+	FAMILY fam_12_contention_time (contention_time),
+	FAMILY fam_13_total_estimated_execution_time (total_estimated_execution_time),
+	FAMILY fam_14_p99_latency (p99_latency)
 );
 CREATE TABLE public.database_role_settings (
 	database_id OID NOT NULL,
 	role_name STRING NOT NULL,
 	settings STRING[] NOT NULL,

Parameters: ROACHTEST_cloud=gce , ROACHTEST_cpu=4 , ROACHTEST_encrypted=false , ROACHTEST_fs=ext4 , ROACHTEST_localSSD=true , ROACHTEST_ssd=0

Help

See: roachtest README

See: How To Investigate (internal)

Same failure on other branches

This test on roachdash | Improve this report!

@cockroach-teamcity
Copy link
Member Author

roachtest.systemschema/validate-after-version-upgrade failed with artifacts on master @ 0fcc33bc2870961b9387999d8a9fed97fccbb2ae:

 	INVERTED INDEX indexes_usage_idx (indexes_usage),
 	INDEX execution_count_idx (aggregated_ts ASC, app_name ASC, execution_count DESC) WHERE app_name NOT LIKE '$ internal%':::STRING,
 	INDEX service_latency_idx (aggregated_ts ASC, app_name ASC, service_latency DESC) WHERE app_name NOT LIKE '$ internal%':::STRING,
 	INDEX cpu_sql_nanos_idx (aggregated_ts ASC, app_name ASC, cpu_sql_nanos DESC) WHERE app_name NOT LIKE '$ internal%':::STRING,
 	INDEX contention_time_idx (aggregated_ts ASC, app_name ASC, contention_time DESC) WHERE app_name NOT LIKE '$ internal%':::STRING,
 	INDEX total_estimated_execution_time_idx (aggregated_ts ASC, app_name ASC, total_estimated_execution_time DESC) WHERE app_name NOT LIKE '$ internal%':::STRING,
-	INDEX p99_latency_idx (aggregated_ts ASC, app_name ASC, p99_latency DESC) WHERE app_name NOT LIKE '$ internal%':::STRING
+	INDEX p99_latency_idx (aggregated_ts ASC, app_name ASC, p99_latency DESC) WHERE app_name NOT LIKE '$ internal%':::STRING,
+	FAMILY "primary" (crdb_internal_aggregated_ts_app_name_fingerprint_id_node_id_plan_hash_transaction_fingerprint_id_shard_8, aggregated_ts, fingerprint_id, transaction_fingerprint_id, plan_hash, app_name, node_id, agg_interval, metadata, statistics, plan, index_recommendations),
+	FAMILY fam_14_execution_count (execution_count),
+	FAMILY fam_15_service_latency (service_latency),
+	FAMILY fam_16_cpu_sql_nanos (cpu_sql_nanos),
+	FAMILY fam_17_contention_time (contention_time),
+	FAMILY fam_18_total_estimated_execution_time (total_estimated_execution_time),
+	FAMILY fam_19_p99_latency (p99_latency)
 );
 CREATE TABLE public.transaction_statistics (
 	aggregated_ts TIMESTAMPTZ NOT NULL,
 	fingerprint_id BYTES NOT NULL,
 	app_name STRING NOT NULL,
@@ -355,20 +362,27 @@
 	crdb_internal_aggregated_ts_app_name_fingerprint_id_node_id_shard_8 INT4 NOT VISIBLE NOT NULL AS (mod(fnv32(crdb_internal.datums_to_bytes(aggregated_ts, app_name, fingerprint_id, node_id)), 8:::INT8)) STORED,
 	execution_count INT8 NULL AS (((statistics->'statistics':::STRING)->'cnt':::STRING)::INT8) STORED,
 	service_latency FLOAT8 NULL AS ((((statistics->'statistics':::STRING)->'svcLat':::STRING)->'mean':::STRING)::FLOAT8) STORED,
 	cpu_sql_nanos FLOAT8 NULL AS ((((statistics->'execution_statistics':::STRING)->'cpuSQLNanos':::STRING)->'mean':::STRING)::FLOAT8) STORED,
 	contention_time FLOAT8 NULL AS ((((statistics->'execution_statistics':::STRING)->'contentionTime':::STRING)->'mean':::STRING)::FLOAT8) STORED,
-	total_estimated_execution_time FLOAT8 NULL AS (((statistics->'statistics':::STRING)->'cnt':::STRING)::FLOAT8 * (((statistics->'statistics':::STRING)->'svcLat':::STRING)->>'mean':::STRING)::FLOAT8) STORED,
+	total_estimated_execution_time FLOAT8 NULL AS (((statistics->'statistics':::STRING)->>'cnt':::STRING)::FLOAT8 * (((statistics->'statistics':::STRING)->'svcLat':::STRING)->>'mean':::STRING)::FLOAT8) STORED,
 	p99_latency FLOAT8 NULL AS ((((statistics->'statistics':::STRING)->'latencyInfo':::STRING)->'p99':::STRING)::FLOAT8) STORED,
 	CONSTRAINT "primary" PRIMARY KEY (aggregated_ts ASC, fingerprint_id ASC, app_name ASC, node_id ASC) USING HASH WITH (bucket_count=8),
 	INDEX fingerprint_stats_idx (fingerprint_id ASC),
 	INDEX execution_count_idx (aggregated_ts ASC, app_name ASC, execution_count DESC) WHERE app_name NOT LIKE '$ internal%':::STRING,
 	INDEX service_latency_idx (aggregated_ts ASC, app_name ASC, service_latency DESC) WHERE app_name NOT LIKE '$ internal%':::STRING,
 	INDEX cpu_sql_nanos_idx (aggregated_ts ASC, app_name ASC, cpu_sql_nanos DESC) WHERE app_name NOT LIKE '$ internal%':::STRING,
 	INDEX contention_time_idx (aggregated_ts ASC, app_name ASC, contention_time DESC) WHERE app_name NOT LIKE '$ internal%':::STRING,
 	INDEX total_estimated_execution_time_idx (aggregated_ts ASC, app_name ASC, total_estimated_execution_time DESC) WHERE app_name NOT LIKE '$ internal%':::STRING,
-	INDEX p99_latency_idx (aggregated_ts ASC, app_name ASC, p99_latency DESC) WHERE app_name NOT LIKE '$ internal%':::STRING
+	INDEX p99_latency_idx (aggregated_ts ASC, app_name ASC, p99_latency DESC) WHERE app_name NOT LIKE '$ internal%':::STRING,
+	FAMILY "primary" (crdb_internal_aggregated_ts_app_name_fingerprint_id_node_id_shard_8, aggregated_ts, fingerprint_id, app_name, node_id, agg_interval, metadata, statistics),
+	FAMILY fam_9_execution_count (execution_count),
+	FAMILY fam_10_service_latency (service_latency),
+	FAMILY fam_11_cpu_sql_nanos (cpu_sql_nanos),
+	FAMILY fam_12_contention_time (contention_time),
+	FAMILY fam_13_total_estimated_execution_time (total_estimated_execution_time),
+	FAMILY fam_14_p99_latency (p99_latency)
 );
 CREATE TABLE public.database_role_settings (
 	database_id OID NOT NULL,
 	role_name STRING NOT NULL,
 	settings STRING[] NOT NULL,

Parameters: ROACHTEST_cloud=gce , ROACHTEST_cpu=4 , ROACHTEST_encrypted=false , ROACHTEST_fs=ext4 , ROACHTEST_localSSD=true , ROACHTEST_ssd=0

Help

See: roachtest README

See: How To Investigate (internal)

Same failure on other branches

This test on roachdash | Improve this report!

@cockroach-teamcity
Copy link
Member Author

roachtest.systemschema/validate-after-version-upgrade failed with artifacts on master @ d107217dac5d817cc115bc0e97b7e53c0f2878bf:

test artifacts and logs in: /artifacts/systemschema/validate-after-version-upgrade/run_1
(validate_system_schema_after_version_upgrade.go:99).1: After upgrading, ``USE system; SHOW CREATE ALL TABLES;`` does not match expected output after version upgrade.
Diff:
@@ -340,11 +340,18 @@
 	INDEX execution_count_idx (aggregated_ts ASC, app_name ASC, execution_count DESC) WHERE app_name NOT LIKE '$ internal%':::STRING,
 	INDEX service_latency_idx (aggregated_ts ASC, app_name ASC, service_latency DESC) WHERE app_name NOT LIKE '$ internal%':::STRING,
 	INDEX cpu_sql_nanos_idx (aggregated_ts ASC, app_name ASC, cpu_sql_nanos DESC) WHERE app_name NOT LIKE '$ internal%':::STRING,
 	INDEX contention_time_idx (aggregated_ts ASC, app_name ASC, contention_time DESC) WHERE app_name NOT LIKE '$ internal%':::STRING,
 	INDEX total_estimated_execution_time_idx (aggregated_ts ASC, app_name ASC, total_estimated_execution_time DESC) WHERE app_name NOT LIKE '$ internal%':::STRING,
-	INDEX p99_latency_idx (aggregated_ts ASC, app_name ASC, p99_latency DESC) WHERE app_name NOT LIKE '$ internal%':::STRING
+	INDEX p99_latency_idx (aggregated_ts ASC, app_name ASC, p99_latency DESC) WHERE app_name NOT LIKE '$ internal%':::STRING,
+	FAMILY "primary" (crdb_internal_aggregated_ts_app_name_fingerprint_id_node_id_plan_hash_transaction_fingerprint_id_shard_8, aggregated_ts, fingerprint_id, transaction_fingerprint_id, plan_hash, app_name, node_id, agg_interval, metadata, statistics, plan, index_recommendations),
+	FAMILY fam_14_execution_count (execution_count),
+	FAMILY fam_15_service_latency (service_latency),
+	FAMILY fam_16_cpu_sql_nanos (cpu_sql_nanos),
+	FAMILY fam_17_contention_time (contention_time),
+	FAMILY fam_18_total_estimated_execution_time (total_estimated_execution_time),
+	FAMILY fam_19_p99_latency (p99_latency)
 );
 CREATE TABLE public.transaction_statistics (
 	aggregated_ts TIMESTAMPTZ NOT NULL,
 	fingerprint_id BYTES NOT NULL,
 	app_name STRING NOT NULL,
@@ -364,11 +371,18 @@
 	INDEX execution_count_idx (aggregated_ts ASC, app_name ASC, execution_count DESC) WHERE app_name NOT LIKE '$ internal%':::STRING,
 	INDEX service_latency_idx (aggregated_ts ASC, app_name ASC, service_latency DESC) WHERE app_name NOT LIKE '$ internal%':::STRING,
 	INDEX cpu_sql_nanos_idx (aggregated_ts ASC, app_name ASC, cpu_sql_nanos DESC) WHERE app_name NOT LIKE '$ internal%':::STRING,
 	INDEX contention_time_idx (aggregated_ts ASC, app_name ASC, contention_time DESC) WHERE app_name NOT LIKE '$ internal%':::STRING,
 	INDEX total_estimated_execution_time_idx (aggregated_ts ASC, app_name ASC, total_estimated_execution_time DESC) WHERE app_name NOT LIKE '$ internal%':::STRING,
-	INDEX p99_latency_idx (aggregated_ts ASC, app_name ASC, p99_latency DESC) WHERE app_name NOT LIKE '$ internal%':::STRING
+	INDEX p99_latency_idx (aggregated_ts ASC, app_name ASC, p99_latency DESC) WHERE app_name NOT LIKE '$ internal%':::STRING,
+	FAMILY "primary" (crdb_internal_aggregated_ts_app_name_fingerprint_id_node_id_shard_8, aggregated_ts, fingerprint_id, app_name, node_id, agg_interval, metadata, statistics),
+	FAMILY fam_9_execution_count (execution_count),
+	FAMILY fam_10_service_latency (service_latency),
+	FAMILY fam_11_cpu_sql_nanos (cpu_sql_nanos),
+	FAMILY fam_12_contention_time (contention_time),
+	FAMILY fam_13_total_estimated_execution_time (total_estimated_execution_time),
+	FAMILY fam_14_p99_latency (p99_latency)
 );
 CREATE TABLE public.database_role_settings (
 	database_id OID NOT NULL,
 	role_name STRING NOT NULL,
 	settings STRING[] NOT NULL,

Parameters: ROACHTEST_cloud=gce , ROACHTEST_cpu=4 , ROACHTEST_encrypted=false , ROACHTEST_ssd=0

Help

See: roachtest README

See: How To Investigate (internal)

Same failure on other branches

This test on roachdash | Improve this report!

@ericharmeling ericharmeling mentioned this issue Mar 27, 2023
Merged
@cockroach-teamcity
Copy link
Member Author

roachtest.systemschema/validate-after-version-upgrade failed with artifacts on master @ 2bd2c806ab3044569b09e0a205b5bc0452ad4e2b:

test artifacts and logs in: /artifacts/systemschema/validate-after-version-upgrade/run_1
(validate_system_schema_after_version_upgrade.go:99).1: After upgrading, ``USE system; SHOW CREATE ALL TABLES;`` does not match expected output after version upgrade.
Diff:
@@ -340,11 +340,18 @@
 	INDEX execution_count_idx (aggregated_ts ASC, app_name ASC, execution_count DESC) WHERE app_name NOT LIKE '$ internal%':::STRING,
 	INDEX service_latency_idx (aggregated_ts ASC, app_name ASC, service_latency DESC) WHERE app_name NOT LIKE '$ internal%':::STRING,
 	INDEX cpu_sql_nanos_idx (aggregated_ts ASC, app_name ASC, cpu_sql_nanos DESC) WHERE app_name NOT LIKE '$ internal%':::STRING,
 	INDEX contention_time_idx (aggregated_ts ASC, app_name ASC, contention_time DESC) WHERE app_name NOT LIKE '$ internal%':::STRING,
 	INDEX total_estimated_execution_time_idx (aggregated_ts ASC, app_name ASC, total_estimated_execution_time DESC) WHERE app_name NOT LIKE '$ internal%':::STRING,
-	INDEX p99_latency_idx (aggregated_ts ASC, app_name ASC, p99_latency DESC) WHERE app_name NOT LIKE '$ internal%':::STRING
+	INDEX p99_latency_idx (aggregated_ts ASC, app_name ASC, p99_latency DESC) WHERE app_name NOT LIKE '$ internal%':::STRING,
+	FAMILY "primary" (crdb_internal_aggregated_ts_app_name_fingerprint_id_node_id_plan_hash_transaction_fingerprint_id_shard_8, aggregated_ts, fingerprint_id, transaction_fingerprint_id, plan_hash, app_name, node_id, agg_interval, metadata, statistics, plan, index_recommendations),
+	FAMILY fam_14_execution_count (execution_count),
+	FAMILY fam_15_service_latency (service_latency),
+	FAMILY fam_16_cpu_sql_nanos (cpu_sql_nanos),
+	FAMILY fam_17_contention_time (contention_time),
+	FAMILY fam_18_total_estimated_execution_time (total_estimated_execution_time),
+	FAMILY fam_19_p99_latency (p99_latency)
 );
 CREATE TABLE public.transaction_statistics (
 	aggregated_ts TIMESTAMPTZ NOT NULL,
 	fingerprint_id BYTES NOT NULL,
 	app_name STRING NOT NULL,
@@ -364,11 +371,18 @@
 	INDEX execution_count_idx (aggregated_ts ASC, app_name ASC, execution_count DESC) WHERE app_name NOT LIKE '$ internal%':::STRING,
 	INDEX service_latency_idx (aggregated_ts ASC, app_name ASC, service_latency DESC) WHERE app_name NOT LIKE '$ internal%':::STRING,
 	INDEX cpu_sql_nanos_idx (aggregated_ts ASC, app_name ASC, cpu_sql_nanos DESC) WHERE app_name NOT LIKE '$ internal%':::STRING,
 	INDEX contention_time_idx (aggregated_ts ASC, app_name ASC, contention_time DESC) WHERE app_name NOT LIKE '$ internal%':::STRING,
 	INDEX total_estimated_execution_time_idx (aggregated_ts ASC, app_name ASC, total_estimated_execution_time DESC) WHERE app_name NOT LIKE '$ internal%':::STRING,
-	INDEX p99_latency_idx (aggregated_ts ASC, app_name ASC, p99_latency DESC) WHERE app_name NOT LIKE '$ internal%':::STRING
+	INDEX p99_latency_idx (aggregated_ts ASC, app_name ASC, p99_latency DESC) WHERE app_name NOT LIKE '$ internal%':::STRING,
+	FAMILY "primary" (crdb_internal_aggregated_ts_app_name_fingerprint_id_node_id_shard_8, aggregated_ts, fingerprint_id, app_name, node_id, agg_interval, metadata, statistics),
+	FAMILY fam_9_execution_count (execution_count),
+	FAMILY fam_10_service_latency (service_latency),
+	FAMILY fam_11_cpu_sql_nanos (cpu_sql_nanos),
+	FAMILY fam_12_contention_time (contention_time),
+	FAMILY fam_13_total_estimated_execution_time (total_estimated_execution_time),
+	FAMILY fam_14_p99_latency (p99_latency)
 );
 CREATE TABLE public.database_role_settings (
 	database_id OID NOT NULL,
 	role_name STRING NOT NULL,
 	settings STRING[] NOT NULL,

Parameters: ROACHTEST_cloud=gce , ROACHTEST_cpu=4 , ROACHTEST_encrypted=false , ROACHTEST_ssd=0

Help

See: roachtest README

See: How To Investigate (internal)

Same failure on other branches

This test on roachdash | Improve this report!

@ericharmeling ericharmeling self-assigned this Mar 27, 2023
@craig craig bot closed this as completed in #99674 Mar 28, 2023
@craig craig bot closed this as completed in 143b63a Mar 28, 2023
@blathers-crl blathers-crl bot mentioned this issue Mar 28, 2023
Closed
@ericharmeling ericharmeling mentioned this issue Mar 28, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ericharmeling ericharmeling

Labels
branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-roachtest O-robot Originated from a bot. release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked.
Projects
None yet
Milestone
23.1
Development

Successfully merging a pull request may close this issue.

sql: add explicit column family assignments to persisted stats upgrades ericharmeling/cockroach
3 participants
@rafiss @cockroach-teamcity @ericharmeling