Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-23.1: ui: update sort setting on search criteria #99795

Merged
merged 1 commit into from
Mar 28, 2023

Conversation

maryliag
Copy link
Contributor

Backport 1/1 commits from #99541.

/cc @cockroachdb/release


Fixes #99397

When a new search criteria is applied, the table on Statement and Transactions are sorted to match the value selected by the search criteria.
When a new column is selected on the table, a warning is displayed to let the users know they're looking into a subset od the data. If the new column selected is one of the options on the search criteria, we give a suggestion to update the search criteria with that value instead.

Screenshot 2023-03-24 at 8 27 52 PM

https://www.loom.com/share/e123e4033d95434a8eef20c257c83bbd

This commit adds the counter per page on the Statement and Transaction tables.
Screenshot 2023-03-24 at 8 28 01 PM

This commit also adds analytics to the apply button, sending the information about each criteria.

Release note (ui change): Add a warning when a user select a sorting column on Statement and Transaction tables that were not the original selected sorting on the search criteria.


Release justification: small change, big impact

Fixes cockroachdb#99397
When a new search criteria is applying, the table on Statement
and Transactions are sorted to match the value selected by the
search criteria.
When a new column is selected on the table, a warning is displayed
to let the users know they're looking into a subset od the data.
If the new column selected is one of the options on the search
criteria, we give a suggestion to update the search criteria with
that value instead.

This commit adds the counter per page on the Statement
and Transaction tables.

This commit also adds analytics to the apply button,
sending the information about each criteria.

Release note (ui change): Add a warning when a user select a sorting
column on Statement and Transaction tables that were not the original
selected sorting on the search criteria.
@maryliag maryliag requested review from a team March 28, 2023 13:23
@blathers-crl
Copy link

blathers-crl bot commented Mar 28, 2023

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Contributor

@j82w j82w left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 12 files at r1, all commit messages.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants