Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pkg/sql/logictest/tests/fakedist-vec-off/fakedist-vec-off_test: TestLogic_inverted_filter_geospatial failed #95359

Closed
cockroach-teamcity opened this issue Jan 17, 2023 · 3 comments · Fixed by #95406
Closed

pkg/sql/logictest/tests/fakedist-vec-off/fakedist-vec-off_test: TestLogic_inverted_filter_geospatial failed #95359

cockroach-teamcity opened this issue Jan 17, 2023 · 3 comments · Fixed by #95406
Assignees
@cucaroach
Labels
branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot. T-sql-queries SQL Queries Team
Milestone
23.1

Comments

@cockroach-teamcity
Copy link
Member

cockroach-teamcity commented Jan 17, 2023 •
edited by cockroach-jira-scripts
Loading

pkg/sql/logictest/tests/fakedist-vec-off/fakedist-vec-off_test.TestLogic_inverted_filter_geospatial failed with artifacts on master @ 6116ab435ee2cc37af34c99e28dec51b6cfa0eb4:

=== RUN   TestLogic_inverted_filter_geospatial
    test_log_scope.go:161: test logs captured to: /artifacts/tmp/_tmp/8ee417166775d051de542acde5a083e2/logTestLogic_inverted_filter_geospatial2229431385
    test_log_scope.go:79: use -show-logs to present logs inline
    logic.go:3233: 
        
        /home/roach/.cache/bazel/_bazel_roach/c5a4e7d36696d9cd970af2045211a7df/sandbox/processwrapper-sandbox/9502/execroot/com_github_cockroachdb_cockroach/bazel-out/aarch64-fastbuild/bin/pkg/sql/logictest/tests/fakedist-vec-off/fakedist-vec-off_test_/fakedist-vec-off_test.runfiles/com_github_cockroachdb_cockroach/pkg/sql/logictest/testdata/logic_test/inverted_filter_geospatial:52: SELECT k FROM geo_table WHERE 'POINT(3.0 3.0)'::geometry && geom ORDER BY k
        expected success, but found
        (0A000) this box2d comparison operator is experimental
        settings.go:33: in checkExperimentalBox2DComparisonOperatorEnabled()
    logic.go:2907: 
         pq: this box2d comparison operator is experimental
[15:11:13] --- done: /home/roach/.cache/bazel/_bazel_roach/c5a4e7d36696d9cd970af2045211a7df/sandbox/processwrapper-sandbox/9502/execroot/com_github_cockroachdb_cockroach/bazel-out/aarch64-fastbuild/bin/pkg/sql/logictest/tests/fakedist-vec-off/fakedist-vec-off_test_/fakedist-vec-off_test.runfiles/com_github_cockroachdb_cockroach/pkg/sql/logictest/testdata/logic_test/inverted_filter_geospatial with config fakedist-vec-off: 9 tests, 2 failures
    logic.go:4025: 
        /home/roach/.cache/bazel/_bazel_roach/c5a4e7d36696d9cd970af2045211a7df/sandbox/processwrapper-sandbox/9502/execroot/com_github_cockroachdb_cockroach/bazel-out/aarch64-fastbuild/bin/pkg/sql/logictest/tests/fakedist-vec-off/fakedist-vec-off_test_/fakedist-vec-off_test.runfiles/com_github_cockroachdb_cockroach/pkg/sql/logictest/testdata/logic_test/inverted_filter_geospatial:58: error while processing
    logic.go:4025: /home/roach/.cache/bazel/_bazel_roach/c5a4e7d36696d9cd970af2045211a7df/sandbox/processwrapper-sandbox/9502/execroot/com_github_cockroachdb_cockroach/bazel-out/aarch64-fastbuild/bin/pkg/sql/logictest/tests/fakedist-vec-off/fakedist-vec-off_test_/fakedist-vec-off_test.runfiles/com_github_cockroachdb_cockroach/pkg/sql/logictest/testdata/logic_test/inverted_filter_geospatial:58: too many errors encountered, skipping the rest of the input
    panic.go:522: -- test log scope end --
test logs left over in: /artifacts/tmp/_tmp/8ee417166775d051de542acde5a083e2/logTestLogic_inverted_filter_geospatial2229431385
--- FAIL: TestLogic_inverted_filter_geospatial (1.37s)
Help

See also: How To Investigate a Go Test Failure (internal)

/cc @cockroachdb/sql-queries

This test on roachdash | Improve this report!

Jira issue: CRDB-23480
@cockroach-teamcity cockroach-teamcity added branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot. labels Jan 17, 2023
@cockroach-teamcity cockroach-teamcity added this to the 23.1 milestone Jan 17, 2023
@blathers-crl blathers-crl bot added the T-sql-queries SQL Queries Team label Jan 17, 2023
@cucaroach
Copy link
Contributor

This doesn't repro, looks like a setting flake as the test sets the setting right before this test but apparently it was set or was reset somehow.

This was referenced Jan 17, 2023
Closed
Closed
@renatolabs
Copy link
Contributor

This does seem to reproduce fairly easily under stress. I did a quick bisection and it seems to point to #93377 as the PR that introduced the failure (specifically, 5a5f339).

@cucaroach
Copy link
Contributor

@yuzefovich explained that in a distsql situation the cluster setting is asynchronously set on other nodes and this query should have a retry clause.

@cucaroach cucaroach mentioned this issue Jan 17, 2023
Merged
@yuzefovich yuzefovich mentioned this issue Jan 18, 2023
Closed
craig bot pushed a commit that referenced this issue Jan 18, 2023
@lidorcarmel @cucaroach @HonoreDB
Merge #95248 #95406 #95453
075b319 
95248: streamingest: add a replication lag metric r=lidorcarmel a=lidorcarmel

Add a metric to track the lag of the replication frontier, in seconds.

Informs: #92959

Epic: CRDB-18752

Release note: None

95406: sql: retry query requiring cluster setting propagation r=cucaroach a=cucaroach

Fixes: #95359
Release note: None
Epic: none


95453: changefeedccl: nilsafe kafkaSink.Close r=[miretskiy] a=HonoreDB

We were tolerating nils in other parts of Close, but not here, which can create a race condition if a sink gets closed before being fully initialized resulting in a panic.

Fixes #95278
Release note: None

Co-authored-by: Lidor Carmel <[email protected]>
Co-authored-by: Tommy Reilly <[email protected]>
Co-authored-by: Aaron Zinger <[email protected]>
@craig craig bot closed this as completed in 9e5bca6 Jan 18, 2023
blathers-crl bot pushed a commit that referenced this issue Jan 18, 2023
@cucaroach
sql: retry query requiring cluster setting propagation
dcacf62 
Fixes: #95359
Release note: None
Epic: none
@blathers-crl blathers-crl bot mentioned this issue Jan 18, 2023
Closed
@blathers-crl blathers-crl bot mentioned this issue Jan 18, 2023
Closed
cucaroach added a commit that referenced this issue Jan 19, 2023
@cucaroach
sql: retry query requiring cluster setting propagation
8bb0122 
Fixes: #95359
Release note: None
Epic: none
@yuzefovich yuzefovich mentioned this issue Jan 19, 2023
Closed
@mgartner mgartner moved this to Done in SQL Queries Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cucaroach cucaroach

Labels
branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot. T-sql-queries SQL Queries Team
Projects
SQL Queries
Archived in project
Milestone
23.1
Development

Successfully merging a pull request may close this issue.

sql: retry query requiring cluster setting propagation cucaroach/cockroach
3 participants
@cockroach-teamcity @cucaroach @renatolabs