Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

roachtest: cdc/sink-chaos failed #95278

Closed
cockroach-teamcity opened this issue Jan 16, 2023 · 2 comments · Fixed by #95453
Closed

roachtest: cdc/sink-chaos failed #95278

cockroach-teamcity opened this issue Jan 16, 2023 · 2 comments · Fixed by #95453
Assignees
@HonoreDB
Labels
branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-roachtest O-robot Originated from a bot. release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked. T-cdc
Milestone
23.1

Comments

@cockroach-teamcity
Copy link
Member

cockroach-teamcity commented Jan 16, 2023 •
edited by exalate-issue-sync bot
Loading

roachtest.cdc/sink-chaos failed with artifacts on master @ a9e5ebbd2834886b4e9c800f47d44483c30de8b6:

test artifacts and logs in: /artifacts/cdc/sink-chaos/run_1
(cluster.go:1933).Run: output in run_091939.043771969_n4_workload_run_tpcc: ./workload run tpcc --warehouses=100 --duration=30m  {pgurl:1-3}  returned: context canceled
(cdc.go:283).Close: error shutting down prometheus/grafana: context canceled

Parameters: ROACHTEST_cloud=gce , ROACHTEST_cpu=16 , ROACHTEST_encrypted=false , ROACHTEST_fs=ext4 , ROACHTEST_localSSD=true , ROACHTEST_ssd=0

Help

See: roachtest README

See: How To Investigate (internal)

/cc @cockroachdb/cdc

This test on roachdash | Improve this report!

Jira issue: CRDB-23442

Epic CRDB-11732
@cockroach-teamcity cockroach-teamcity added branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-roachtest O-robot Originated from a bot. release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked. labels Jan 16, 2023
@cockroach-teamcity cockroach-teamcity added this to the 23.1 milestone Jan 16, 2023
@blathers-crl blathers-crl bot added the T-cdc label Jan 16, 2023
@cockroach-teamcity
Copy link
Member Author

roachtest.cdc/sink-chaos failed with artifacts on master @ 43cd78ecd87591d9b1d3b142f29ddfd76013b276:

test artifacts and logs in: /artifacts/cdc/sink-chaos/run_1
(cluster.go:1933).Run: output in run_092022.273965490_n4_workload_run_tpcc: ./workload run tpcc --warehouses=100 --duration=30m  {pgurl:1-3}  returned: COMMAND_PROBLEM: exit status 1
(cdc.go:283).Close: error shutting down prometheus/grafana: context canceled

Parameters: ROACHTEST_cloud=gce , ROACHTEST_cpu=16 , ROACHTEST_encrypted=false , ROACHTEST_fs=ext4 , ROACHTEST_localSSD=true , ROACHTEST_ssd=0

Help

See: roachtest README

See: How To Investigate (internal)

This test on roachdash | Improve this report!

@cockroach-teamcity
Copy link
Member Author

roachtest.cdc/sink-chaos failed with artifacts on master @ 4ec5a5f43980583eff8b8f8dff1b23090c7e2304:

test artifacts and logs in: /artifacts/cdc/sink-chaos/run_1
(cluster.go:1933).Run: output in run_092649.949484935_n4_workload_run_tpcc: ./workload run tpcc --warehouses=100 --duration=30m  {pgurl:1-3}  returned: COMMAND_PROBLEM: exit status 1
(cdc.go:283).Close: error shutting down prometheus/grafana: context canceled

Parameters: ROACHTEST_cloud=gce , ROACHTEST_cpu=16 , ROACHTEST_encrypted=false , ROACHTEST_fs=ext4 , ROACHTEST_localSSD=true , ROACHTEST_ssd=0

Help

See: roachtest README

See: How To Investigate (internal)

This test on roachdash | Improve this report!

@HonoreDB HonoreDB self-assigned this Jan 18, 2023
@HonoreDB HonoreDB mentioned this issue Jan 18, 2023
Merged
craig bot pushed a commit that referenced this issue Jan 18, 2023
@lidorcarmel @cucaroach @HonoreDB
Merge #95248 #95406 #95453
075b319 
95248: streamingest: add a replication lag metric r=lidorcarmel a=lidorcarmel

Add a metric to track the lag of the replication frontier, in seconds.

Informs: #92959

Epic: CRDB-18752

Release note: None

95406: sql: retry query requiring cluster setting propagation r=cucaroach a=cucaroach

Fixes: #95359
Release note: None
Epic: none


95453: changefeedccl: nilsafe kafkaSink.Close r=[miretskiy] a=HonoreDB

We were tolerating nils in other parts of Close, but not here, which can create a race condition if a sink gets closed before being fully initialized resulting in a panic.

Fixes #95278
Release note: None

Co-authored-by: Lidor Carmel <[email protected]>
Co-authored-by: Tommy Reilly <[email protected]>
Co-authored-by: Aaron Zinger <[email protected]>
@craig craig bot closed this as completed in 0572cf5 Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@HonoreDB HonoreDB

Labels
branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-roachtest O-robot Originated from a bot. release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked. T-cdc
Projects
None yet
Milestone
23.1
Development

Successfully merging a pull request may close this issue.

changefeedccl: nilsafe kafkaSink.Close HonoreDB/cockroach
2 participants
@HonoreDB @cockroach-teamcity