Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

c2c: add top-level metrics to the replication job #92959

Closed
2 tasks
adityamaru opened this issue Dec 2, 2022 · 2 comments · Fixed by #95629
Closed
2 tasks

c2c: add top-level metrics to the replication job #92959

adityamaru opened this issue Dec 2, 2022 · 2 comments · Fixed by #95629
Assignees
Labels
A-disaster-recovery C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-disaster-recovery

Comments

@adityamaru
Copy link
Contributor

adityamaru commented Dec 2, 2022

  • Replication Lag: Add a metric that tracks the difference between now() and the frontier timestamp on the destination cluster. This tracks how far behind the replication is from the current time on the destination cluster.

  • Replicated Physical Bytes: Add a metric that tracks the physical bytes ingested by the destination cluster.

Epic: CRDB-18752

Jira issue: CRDB-22068

@adityamaru adityamaru added C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) A-disaster-recovery labels Dec 2, 2022
@blathers-crl
Copy link

blathers-crl bot commented Dec 2, 2022

cc @cockroachdb/disaster-recovery

@blathers-crl
Copy link

blathers-crl bot commented Dec 2, 2022

cc @cockroachdb/disaster-recovery

lidorcarmel added a commit to lidorcarmel/cockroach that referenced this issue Jan 17, 2023
Add a metric to track the lag of the replication frontier, in seconds.

Informs: cockroachdb#92959

Epic: CRDB-18752

Release note: None
lidorcarmel added a commit to lidorcarmel/cockroach that referenced this issue Jan 18, 2023
Add a metric to track the lag of the replication frontier, in seconds.

Informs: cockroachdb#92959

Epic: CRDB-18752

Release note: None
craig bot pushed a commit that referenced this issue Jan 18, 2023
95248: streamingest: add a replication lag metric r=lidorcarmel a=lidorcarmel

Add a metric to track the lag of the replication frontier, in seconds.

Informs: #92959

Epic: CRDB-18752

Release note: None

95406: sql: retry query requiring cluster setting propagation r=cucaroach a=cucaroach

Fixes: #95359
Release note: None
Epic: none


95453: changefeedccl: nilsafe kafkaSink.Close r=[miretskiy] a=HonoreDB

We were tolerating nils in other parts of Close, but not here, which can create a race condition if a sink gets closed before being fully initialized resulting in a panic.

Fixes #95278
Release note: None

Co-authored-by: Lidor Carmel <[email protected]>
Co-authored-by: Tommy Reilly <[email protected]>
Co-authored-by: Aaron Zinger <[email protected]>
craig bot pushed a commit that referenced this issue Jan 23, 2023
95552: gossip: Remove creation time dependency on grpc r=rharding6373,erikgrinaker a=andrewbaptist

    Create gossip objects without a grpc depencency. The rpcContext is
    injected during Start instead. This removes some code tangles and
    simplifies the usage of gossip in tests.

    Epic: none
    Release note: None

95591: docgen: update SQL diagrams for SQL docs refactor r=rytaft a=taroface

Updated existing & added some new SQL diagrams. These will be used in the SQL docs being refactored as per https://cockroachlabs.atlassian.net/browse/DOC-5850

Release note: none

95629: streamingest,bulk,roachpb: add a metric for bytes streamed, compressed r=lidorcarmel a=lidorcarmel

We currently have a mteric for the logical bytes written to SSTs, pre-compression, and this PR adds a metric for the "physical" bytes sent to KV in SSTs, post compression.

Epic: CRDB-18752

Fixes: #92959

Release note: None

For example:
<img width="1012" alt="Screenshot 2023-01-20 at 2 15 31 PM" src="https://user-images.githubusercontent.com/51982110/213814907-13ebdde1-82c4-4597-b9f9-d02a8bc1a112.png">


Co-authored-by: Andrew Baptist <[email protected]>
Co-authored-by: Ryan Kuo <[email protected]>
Co-authored-by: Lidor Carmel <[email protected]>
@craig craig bot closed this as completed in d794429 Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-disaster-recovery C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-disaster-recovery
Projects
No open projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants