Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release-22.1: sql: retry query requiring cluster setting propagation #95471

Closed
wants to merge 1 commit into from
Closed

release-22.1: sql: retry query requiring cluster setting propagation #95471

wants to merge 1 commit into from

Conversation

blathers-crl[bot]
Copy link

@blathers-crl blathers-crl bot commented Jan 18, 2023

Backport 1/1 commits from #95406 on behalf of @cucaroach.

/cc @cockroachdb/release

Fixes: #95359
Release note: None
Epic: none

Release justification:

@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-22.1-95406 branch from f71eda4 to dcacf62 Compare January 18, 2023 22:44
@blathers-crl
Copy link
Author

blathers-crl bot commented Jan 18, 2023

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@blathers-crl blathers-crl bot requested review from mgartner and rytaft January 18, 2023 22:44
@blathers-crl blathers-crl bot added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels Jan 18, 2023
@cockroach-teamcity
Copy link
Member

This change is Reviewable

rytaft
rytaft approved these changes Jan 19, 2023
View reviewed changes
Copy link
Collaborator

@rytaft rytaft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @mgartner)

@github-actions
Copy link

Reminder: it has been 3 weeks please merge or close your backport!

@mgartner
Copy link
Collaborator

mgartner commented Oct 3, 2023

@cucaroach Should we just close this?

@github-actions
Copy link

Reminder: it has been 3 weeks please merge or close your backport!

@mgartner mgartner closed this Oct 25, 2023
@mgartner mgartner deleted the blathers/backport-release-22.1-95406 branch October 25, 2023 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rytaft rytaft rytaft approved these changes

@mgartner mgartner Awaiting requested review from mgartner

Assignees

@cucaroach cucaroach

Labels
blathers-backport This is a backport that Blathers created automatically. no-backport-pr-activity O-robot Originated from a bot.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cockroach-teamcity @mgartner @rytaft @cucaroach