-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
opt: v22.2.0-alpha.4: index out of range when resolving a function #89046
Comments
@chengxiong-ruan looks like it's possible to call |
@rytaft thanks for letting me know. Is there a way to get the query causing this panic so we can repro? In theory a function name, if exists, should have at least one overload. I'll take a deeper look on Monday if this is not urgent. But I have a theory that this is a bug in the I'll have a fix for it on Monday. |
Usually sentry includes the statement fingerprint, but this one doesn't for some reason. Seems like we might want to consider this a GA blocker, so I'll add the label. But definitely no need to look at this before Monday. Thanks for taking a look! |
Backport fixes: cockroachdb#89046 Previously we just remove an overload from the slice when dropping a function. This is problematic if there's zero overloads left after the drop because it pretends that there is some function with the name but actually nothing. So we need to delete the key if there is not overload for the name. Release note: None Release justification: GA blocker bug fix.
yeah, I was able to repro with:
having a fix for it with #89184 |
88944: sql/covering: make OverlapCoveringMerge benchmark deterministic r=cucaroach a=cucaroach Previously we seeded RNG with time and benchmark results varied widely. In order to make sure this doesn't make noise when comparing different versions make the seed a constant. Fixes: #88919 Release note: None 89184: sql: delete function name key from schema if no overload left after drop r=chengxiong-ruan a=chengxiong-ruan Backport fixes: #89046 Previously we just remove an overload from the slice when dropping a function. This is problematic if there's zero overloads left after the drop because it pretends that there is some function with the name but actually nothing. So we need to delete the key if there is not overload for the name. Release note: None Release justification: GA blocker bug fix. 89189: opgen: ensure GC jobs for temp indexes have proper description r=postamar a=postamar Fixes #82169. Release note: None Co-authored-by: Tommy Reilly <[email protected]> Co-authored-by: Chengxiong Ruan <[email protected]> Co-authored-by: Marius Posta <[email protected]>
Backport fixes: cockroachdb#89046 Previously we just remove an overload from the slice when dropping a function. This is problematic if there's zero overloads left after the drop because it pretends that there is some function with the name but actually nothing. So we need to delete the key if there is not overload for the name. Release note: None Release justification: GA blocker bug fix.
closed with #89219 |
This issue was autofiled by Sentry. It represents a crash or reported error on a live cluster with telemetry enabled.
Sentry link: https://sentry.io/organizations/cockroach-labs/issues/3632953670/?referrer=webhooks_plugin
Panic message:
Stacktrace (expand for inline code snippets):
cockroach/pkg/util/errorutil/catch.go
Lines 28 to 30 in aac413c
cockroach/pkg/sql/opt/optbuilder/builder.go
Lines 191 to 193 in aac413c
GOROOT/src/runtime/panic.go#L883-L885 in runtime.gopanic
GOROOT/src/runtime/panic.go#L112-L114 in runtime.goPanicIndex
cockroach/pkg/sql/sem/tree/function_definition.go
Lines 329 to 331 in aac413c
cockroach/pkg/sql/opt/optbuilder/groupby.go
Lines 897 to 899 in aac413c
cockroach/pkg/sql/opt/optbuilder/groupby.go
Lines 889 to 891 in aac413c
cockroach/pkg/sql/opt/optbuilder/scope.go
Lines 1060 to 1062 in aac413c
cockroach/pkg/sql/sem/tree/walk.go
Lines 823 to 825 in aac413c
cockroach/pkg/sql/opt/optbuilder/scope.go
Lines 427 to 429 in aac413c
cockroach/pkg/sql/opt/optbuilder/scope.go
Lines 466 to 468 in aac413c
cockroach/pkg/sql/opt/optbuilder/project.go
Lines 159 to 161 in aac413c
cockroach/pkg/sql/opt/optbuilder/project.go
Lines 93 to 95 in aac413c
cockroach/pkg/sql/opt/optbuilder/select.go
Lines 1058 to 1060 in aac413c
cockroach/pkg/sql/opt/optbuilder/select.go
Lines 995 to 997 in aac413c
cockroach/pkg/sql/opt/optbuilder/select.go
Lines 964 to 966 in aac413c
cockroach/pkg/sql/opt/optbuilder/with.go
Lines 114 to 116 in aac413c
cockroach/pkg/sql/opt/optbuilder/select.go
Lines 963 to 965 in aac413c
cockroach/pkg/sql/opt/optbuilder/builder.go
Lines 304 to 306 in aac413c
cockroach/pkg/sql/opt/optbuilder/builder.go
Lines 251 to 253 in aac413c
cockroach/pkg/sql/opt/optbuilder/builder.go
Lines 225 to 227 in aac413c
cockroach/pkg/sql/plan_opt.go
Lines 561 to 563 in aac413c
cockroach/pkg/sql/plan_opt.go
Lines 232 to 234 in aac413c
cockroach/pkg/sql/conn_executor_exec.go
Lines 1431 to 1433 in aac413c
cockroach/pkg/sql/conn_executor_exec.go
Lines 1057 to 1059 in aac413c
cockroach/pkg/sql/conn_executor_exec.go
Lines 686 to 688 in aac413c
cockroach/pkg/sql/conn_executor_exec.go
Lines 128 to 130 in aac413c
cockroach/pkg/sql/conn_executor_exec.go
Lines 2381 to 2383 in aac413c
cockroach/pkg/sql/conn_executor_exec.go
Lines 127 to 129 in aac413c
cockroach/pkg/sql/conn_executor.go
Lines 1918 to 1920 in aac413c
cockroach/pkg/sql/conn_executor.go
Lines 1922 to 1924 in aac413c
cockroach/pkg/sql/conn_executor.go
Lines 1844 to 1846 in aac413c
v22.2.0-alpha.4
Jira issue: CRDB-20083
The text was updated successfully, but these errors were encountered: