sql/covering: make OverlapCoveringMerge benchmark deterministic #88944
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
cucaroach
force-pushed
the
fix-overlap-bench
branch
from
2f7a813 to
8ecdaec
Compare
yuzefovich
approved these changes
Sep 28, 2022
There was a problem hiding this comment.
nit: add backport labels to 22.1 and 22.2.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @cucaroach)
Previously we seeded RNG with time and benchmark results varied widely. In order to make sure this doesn't make noise when comparing different versions make the seed a constant. Fixes: cockroachdb#88919 Release note: None
cucaroach
force-pushed
the
fix-overlap-bench
branch
from
8ecdaec to
dc2daea
Compare
|
bors r+ |
|
Build succeeded: |
This was referenced Oct 3, 2022
16 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we seeded RNG with time and benchmark results varied widely.
In order to make sure this doesn't make noise when comparing different
versions make the seed a constant.
Fixes: #88919
Release note: None