Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sql/schemachanger: proper job description for GC Job dropping temporary index #82169

Closed
ajwerner opened this issue May 31, 2022 · 1 comment · Fixed by #89189
Closed

sql/schemachanger: proper job description for GC Job dropping temporary index #82169

ajwerner opened this issue May 31, 2022 · 1 comment · Fixed by #89189
Assignees
@postamar
Labels
branch-release-22.2 Used to mark GA and release blockers, technical advisories, and bugs for 22.2 C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) E-easy Easy issue to tackle, requires little or no CockroachDB experience GA-blocker T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions)

Comments

@ajwerner
Copy link
Contributor

ajwerner commented May 31, 2022 •
edited
Loading

Is your feature request related to a problem? Please describe.

Right now it just has the sad string "GC for". This comes indirectly from not populating the below field. We probably need a bit more sophistication to get it right.

cockroach/pkg/sql/schemachanger/scop/mutation.go

Line 131 in 1b01f41

StatementForDropJob

The solution here is to ensure that we only create a single GC job. The current thinking is to model the GC job explicitly.

Jira issue: CRDB-16234
@ajwerner ajwerner added the C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) label May 31, 2022
@ajwerner ajwerner self-assigned this May 31, 2022
@blathers-crl blathers-crl bot added the T-sql-schema-deprecated Use T-sql-foundations instead label May 31, 2022
@ajwerner ajwerner mentioned this issue May 31, 2022
Merged
@ajwerner ajwerner removed their assignment Jul 5, 2022
@postamar postamar added the E-easy Easy issue to tackle, requires little or no CockroachDB experience label Jul 5, 2022
@blathers-crl
Copy link

blathers-crl bot commented Aug 16, 2022

Hi @ajwerner, please add branch-* labels to identify which branch(es) this release-blocker affects.

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan.

@ajwerner ajwerner added the branch-release-22.2 Used to mark GA and release blockers, technical advisories, and bugs for 22.2 label Aug 16, 2022
@postamar postamar mentioned this issue Sep 29, 2022
Closed
postamar pushed a commit to postamar/cockroach that referenced this issue Sep 30, 2022
schemachanger: add & adopt data elements
0707849 
This commit attaches db/table/index GC jobs to elements representing
their data. This allows leveraging the rules system to create a minimum
of necessary GC jobs in the same non-revertible mutation stage.

Fixes cockroachdb#82169.

Release note: None
@postamar postamar mentioned this issue Oct 3, 2022
Merged
postamar pushed a commit to postamar/cockroach that referenced this issue Oct 3, 2022
opgen: ensure GC jobs for temp indexes have proper description
e370582 
Fixes cockroachdb#82169.

Release note: None
@postamar postamar mentioned this issue Oct 3, 2022
Merged
postamar pushed a commit to postamar/cockroach that referenced this issue Oct 3, 2022
opgen: ensure GC jobs for temp indexes have proper description
e1cfe36 
Fixes cockroachdb#82169.

Release note: None
craig bot pushed a commit that referenced this issue Oct 3, 2022
@cucaroach @chengxiong-ruan
Merge #88944 #89184 #89189
9794be4 
88944: sql/covering: make OverlapCoveringMerge benchmark deterministic r=cucaroach a=cucaroach

Previously we seeded RNG with time and benchmark results varied widely.
In order to make sure this doesn't make noise when comparing different
versions make the seed a constant.

Fixes: #88919

Release note: None


89184: sql: delete function name key from schema if no overload left after drop r=chengxiong-ruan a=chengxiong-ruan

Backport fixes: #89046
Previously we just remove an overload from the slice when dropping a function. This is problematic if there's zero overloads left after the drop because it pretends that there is some function with the name but actually nothing. So we need to delete the key if there is not overload for the name.

Release note: None
Release justification: GA blocker bug fix.

89189: opgen: ensure GC jobs for temp indexes have proper description r=postamar a=postamar

Fixes #82169.

Release note: None

Co-authored-by: Tommy Reilly <[email protected]>
Co-authored-by: Chengxiong Ruan <[email protected]>
Co-authored-by: Marius Posta <[email protected]>
@craig craig bot closed this as completed in #89189 Oct 3, 2022
@blathers-crl blathers-crl bot mentioned this issue Oct 3, 2022
Merged
blathers-crl bot pushed a commit that referenced this issue Oct 3, 2022
opgen: ensure GC jobs for temp indexes have proper description
5259e8c 
Fixes #82169.

Release note: None
postamar pushed a commit to postamar/cockroach that referenced this issue Oct 20, 2022
schemachanger: add & adopt data elements
74b4a88 
This commit attaches db/table/index GC jobs to elements representing
their data. This allows leveraging the rules system to create a minimum
of necessary GC jobs in the same non-revertible mutation stage.

Fixes cockroachdb#82169.

Release note: None
postamar pushed a commit to postamar/cockroach that referenced this issue Oct 27, 2022
schemachanger: add & adopt data elements
74bc9ad 
This commit attaches db/table/index GC jobs to elements representing
their data. This allows leveraging the rules system to create a minimum
of necessary GC jobs in the same non-revertible mutation stage.

Fixes cockroachdb#82169.

Release note: None
postamar pushed a commit to postamar/cockroach that referenced this issue Oct 27, 2022
schemachanger: add & adopt data elements
24127a3 
This commit attaches db/table/index GC jobs to elements representing
their data. This allows leveraging the rules system to create a minimum
of necessary GC jobs in the same non-revertible mutation stage.

Fixes cockroachdb#82169.

Release note: None
@exalate-issue-sync exalate-issue-sync bot reopened this May 10, 2023
@exalate-issue-sync exalate-issue-sync bot added T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions) and removed T-sql-schema-deprecated Use T-sql-foundations instead labels May 10, 2023
@rafiss rafiss closed this as completed May 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@postamar postamar

Labels
branch-release-22.2 Used to mark GA and release blockers, technical advisories, and bugs for 22.2 C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) E-easy Easy issue to tackle, requires little or no CockroachDB experience GA-blocker T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions)
Projects
None yet
Milestone
No milestone
3 participants
@rafiss @ajwerner @postamar