sql: delete function name key from schema if no overload left after drop #89184
Conversation
|
This change is |
There was a problem hiding this comment.
Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @chengxiong-ruan)
There was a problem hiding this comment.
Nice! Thanks for fixing this.
Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status:
Backport fixes: cockroachdb#89046 Previously we just remove an overload from the slice when dropping a function. This is problematic if there's zero overloads left after the drop because it pretends that there is some function with the name but actually nothing. So we need to delete the key if there is not overload for the name. Release note: None Release justification: GA blocker bug fix.
chengxiong-ruan
force-pushed
the
udf-delete-fn-name-key-if-no-overload
branch
from
7a9e8b6 to
5ae9e2c
Compare
|
TFTR! |
|
Build succeeded: |
|
Encountered an error creating backports. Some common things that can go wrong:
You might need to create your backport manually using the backport tool. error creating merge commit from 5ae9e2c to blathers/backport-release-22.2-89184: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict [] you may need to manually resolve merge conflicts with the backport tool. Backport to branch 22.2.x failed. See errors above. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan. |
Backport fixes: #89046
Previously we just remove an overload from the slice when dropping a function. This is problematic if there's zero overloads left after the drop because it pretends that there is some function with the name but actually nothing. So we need to delete the key if there is not overload for the name.
Release note: None
Release justification: GA blocker bug fix.