Allow passing arguments to the docker image as env var

[dvarrazzo]

The Github Actions system allows to run services to support CI jobs.

I haven't been able to use CockroachDB as a job service because, in order to run a database, the image requires certain arguments, for instance:

docker run --rm --name crdb -p 26257:26257 cockroachdb/cockroach:v21.2.14 start-single-node --insecure

Gitlab CI doesn't seem to allow to specify args. This is arguably a shortcoming of theirs and it would be nice if they improved Actions, but, in the meantime CockroachDB could make use of Action services if it was possible to specify the arguments as an env var. For instance, if specifying CRDB_ARGS was equivalent to starting the container with /cockroach/cockroach.sh $CRDB_ARGS then it would be possible to use Github Actions using an entry such as:

    services:
      crdb:
        image: cockroachdb/cockroach:latest-v22.1
        env:
          CRDB_ARGS: start-single-node --insecure
        ports:
          - 26257:26257

I don't know if there are hacks I haven't considered to kick Actions into running a container with args, I couldn't find anything by googling and reading docker run --help.

Of course an optimal solution was for Github to extend their service syntax but that would likely take longer than adding the feature to your cockroach.sh.

Jira issue: CRDB-19119

[blathers-crl]

Hello, I am Blathers. I am here to help you get the issue triaged.

It looks like you have not filled out the issue in the format of any of our templates. To best assist you, we advise you to use one of these templates.

I was unable to automatically find someone to ping.

If we have not gotten back to your issue within a few business days, you can try the following:

• Join our community slack channel and ask on #cockroachdb.
• Try find someone from here if you know they worked closely on the area and CC them.

_{🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan.}

[jwoertink]

We're seeing more users checking out CockraochDB with Lucky, but we have a lot of bugs coming up with small differences between this and postgres. I'd love to add Cockroach as a first-class support with Lucky if we can make sure specs pass on the CI. If anyone happens to know how to make that happen, I'd appreciate some tips!