feat: allow starting docker container via env variable #98899
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #87043 by allowing you to specify args via the
COCKROACH_ARGS
env value instead of a command. This is required to be able to use the official cockroach image with GitHub actions via a service. More details in the issue.Note, do to weirdness with merging commands and env values, I decided that setting the
COCKROACH_ARGS
would ignore any command given. This should reduce issues with people trying to use both ways of specifying args and instead force them to pick one.Release note (general change): Allow setting docker command args via the
COCKROACH_ARGS
environment variable.