COCKROACH_ARGS environment variable not working as expected

[DennieDev]

Using COCKROACH_ARGS with flags instead of just a single command results in a failure.
This is due to a fault in /cockroach/cockroach.sh.

Error:

ERROR: unknown command "start --insecure" for "cockroach"

Please describe the issue you observed, and any steps we can take to reproduce it:

To Reproduce

1. Start a docker container using the COCKROACH_ARGS variable as 'start --insecure'

Example:

version: "3.9"
services:
   
  cockroach:
    hostname: "node_{{.Node.Hostname}}"
    image: cockroachdb/cockroach:v23.2.4
    network_mode: host
    environment:
      COCKROACH_ARGS: 'start --insecure'
    deploy:
      replicas: 1
    ports:
      - 26257:26257
      - 26357:26357
      - 18080:8080

Expected behavior
It should just pass the flags as normal instead of matching it all as a single command, this is due to a fault in the /cockroach/cockroach.sh file.

Additional context
The fix is changing:

if [[ -n "$COCKROACH_ARGS" ]]; then
  _main "$COCKROACH_ARGS"
else
  _main "$@"
fi

To:

if [[ -n "$COCKROACH_ARGS" ]]; then
  _main $COCKROACH_ARGS
else
  _main "$@"
fi

Because of the "" it's matching the entire variable as a single command.

Jira issue: CRDB-37892

[blathers-crl]

Hello, I am Blathers. I am here to help you get the issue triaged.

It looks like you have not filled out the issue in the format of any of our templates. To best assist you, we advise you to use one of these templates.

I was unable to automatically find someone to ping.

If we have not gotten back to your issue within a few business days, you can try the following:

• Join our community slack channel and ask on #cockroachdb.
• Try find someone from here if you know they worked closely on the area and CC them.

_{🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.}

[xinhaoz]

Tagged @cockroach-dev-inf given this PR but feel free to reassign if this is not your area of ownership!

[WhyAsh5114]

Hey @rail, I tried to run the latest docker image as a service in a GitHub actions workflow, and still encountered this error:

ERROR: unknown command "start-single-node --insecure" for "cockroach"
Failed running "cockroach"

Is the PR not yet deployed to the latest image or something?

[rail]

It will be available in 24.2