Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sql: remove no longer used channel in createStatsNode #99750

Merged
merged 1 commit into from
Mar 30, 2023
Merged

sql: remove no longer used channel in createStatsNode #99750

merged 1 commit into from
Mar 30, 2023

Conversation

yuzefovich
Copy link
Member

This hasn't been used as of fe6377c. Also mark create_stats.go as owned by SQL Queries.

Epic: None

Release note: None

@yuzefovich yuzefovich requested review from rytaft and a team March 28, 2023 02:03
@yuzefovich yuzefovich requested a review from a team as a code owner March 28, 2023 02:03
@blathers-crl
Copy link

blathers-crl bot commented Mar 28, 2023

It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR?

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@cockroach-teamcity
Copy link
Member

This change is Reviewable

rytaft
rytaft approved these changes Mar 28, 2023
View reviewed changes
Copy link
Collaborator

@rytaft rytaft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @yuzefovich)

-- commits line 2 at r1:
nit: createStateNode -> createStatsNode (also update PR title)

@yuzefovich
sql: remove no longer used channel in createStatsNode
ab10d6c 
This hasn't been used as of fe6377c.
Also mark `create_stats.go` as owned by SQL Queries.

Epic: None

Release note: None
@yuzefovich yuzefovich changed the title sql: remove no longer used channel in createStateNode sql: remove no longer used channel in createStatsNode Mar 28, 2023
yuzefovich
yuzefovich commented Mar 28, 2023
View reviewed changes
Copy link
Member Author

@yuzefovich yuzefovich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TFTR!

bors r+

Reviewable status: :shipit: complete! 0 of 0 LGTMs obtained (and 1 stale) (waiting on @yuzefovich)

@craig
Copy link
Contributor

craig bot commented Mar 28, 2023

Build failed (retrying...):

@craig
Copy link
Contributor

craig bot commented Mar 28, 2023

Build failed (retrying...):

@craig
Copy link
Contributor

craig bot commented Mar 29, 2023

Build failed (retrying...):

@craig
Copy link
Contributor

craig bot commented Mar 29, 2023

Build failed (retrying...):

@craig
Copy link
Contributor

craig bot commented Mar 29, 2023

Build failed (retrying...):

@craig
Copy link
Contributor

craig bot commented Mar 29, 2023

Build failed (retrying...):

@craig
Copy link
Contributor

craig bot commented Mar 30, 2023

Build succeeded:

@craig craig bot merged commit 331a672 into cockroachdb:master Mar 30, 2023
@yuzefovich yuzefovich deleted the results-ch branch March 30, 2023 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rytaft rytaft rytaft approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yuzefovich @cockroach-teamcity @rytaft