ui: drop index with space #99690
Merged
ui: drop index with space #99690
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
THardy98
suggested changes
Mar 28, 2023
maryliag
commented
Mar 29, 2023
THardy98
approved these changes
Mar 29, 2023
There was a problem hiding this comment.
Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @maryliag)
Previously, if the index had a space on its name, it would fail to drop. This commit adds quotes so it can be executed. Fixes cockroachdb#97988 Release note (bug fix): Index recommendation to DROP an index that have a space on its name can now be properly executed.
|
bors r+ |
maryliag
added
backport-22.2.x
backport-23.1.x
|
Build succeeded: |
|
Encountered an error creating backports. Some common things that can go wrong:
You might need to create your backport manually using the backport tool. error creating merge commit from e439695 to blathers/backport-release-22.2-99690: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict [] you may need to manually resolve merge conflicts with the backport tool. Backport to branch 22.2.x failed. See errors above. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, if the index had a space on its name,
it would fail to drop.
This commit adds quotes so it can be executed.
Fixes #97988
Schema Insights
https://www.loom.com/share/04363b7f83484b5da19c760eb8d0de21
Table Details page
https://www.loom.com/share/1519b897a14440ddb066fb2ab03feb2d
Release note (bug fix): Index recommendation to DROP an index that have a space on its name can now be properly executed.