Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: implement run_json_test for bazel bazed jobs #71930

Closed
rail opened this issue Oct 25, 2021 · 0 comments · Fixed by #72611
Closed

ci: implement run_json_test for bazel bazed jobs #71930

rail opened this issue Oct 25, 2021 · 0 comments · Fixed by #72611
Assignees
@rail
Labels
A-build-system A-ci Continuous Integration C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. T-dev-inf

Comments

@rail
Copy link
Member

rail commented Oct 25, 2021

Current CI uses run_json_test in order to report some issues to GitHub. It's used in many tests.

We need to implement something similar for Bazel based tests.

Epic CRDB-8306
@rail rail added C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. A-build-system T-dev-inf A-ci Continuous Integration labels Oct 25, 2021
@rail rail mentioned this issue Oct 25, 2021
Merged
rail added a commit to rail/cockroach that referenced this issue Oct 25, 2021
@rail
bazel: run acceptance tests under Bazel
8dfbcef 
This patch makes the acceptance test work under Bazel.

* Add `AbsCertsDir()` in order to keep track of certificate path for
  cases when tests change the working directory.
* docker-compose tests to use interpolation and environment variables in
  order to override `CERTS_DIR` and `COCKROACH_BINARY`.
* Add `copyRunfiles()` in order to copy Bazel-generated symlinked
  runfiles as regular files to make them available in docker mounted
  volumes.

Related: cockroachdb#71932, cockroachdb#71930
Fixes cockroachdb#59446

Release note: None
rail added a commit to rail/cockroach that referenced this issue Oct 25, 2021
@rail
bazel: run acceptance tests under Bazel
e8fedf8 
This patch makes the acceptance test work under Bazel.

* Add `AbsCertsDir()` in order to keep track of certificate path for
  cases when tests change the working directory.
* docker-compose tests to use interpolation and environment variables in
  order to override `CERTS_DIR` and `COCKROACH_BINARY`.
* Add `copyRunfiles()` in order to copy Bazel-generated symlinked
  runfiles as regular files to make them available in docker mounted
  volumes.

Related: cockroachdb#71932, cockroachdb#71930
Fixes cockroachdb#59446

Release note: None
@rail rail mentioned this issue Nov 10, 2021
Merged
rail added a commit to rail/cockroach that referenced this issue Nov 12, 2021
@rail
bazel, ci: use test2json format for nightly logging
e047827 
Fixes cockroachdb#71930

Previously, bazel based nightlies didn't report errors as github issues.

This PR adds a patch for `rules_go` to support `test2json` output
format, that can be used by `github-post` and `testfilter`.

Release note: None
rail added a commit to rail/cockroach that referenced this issue Nov 23, 2021
@rail
bazel: run acceptance tests under Bazel
ccf0dd9 
This patch makes the acceptance test work under Bazel.

* Add `AbsCertsDir()` in order to keep track of certificate path for
  cases when tests change the working directory.
* docker-compose tests to use interpolation and environment variables in
  order to override `CERTS_DIR` and `COCKROACH_BINARY`.
* Add `copyRunfiles()` in order to copy Bazel-generated symlinked
  runfiles as regular files to make them available in docker mounted
  volumes.

Related: cockroachdb#71932, cockroachdb#71930
Fixes cockroachdb#59446

Release note: None
craig bot pushed a commit that referenced this issue Nov 23, 2021
@rail @rickystewart
Merge #71770 #72574 #73055 #73080
2ac3cf4 
71770: bazel: run acceptance tests under Bazel r=rickystewart a=rail

This patch makes the acceptance test work under Bazel.

* Add `AbsCertsDir()` in order to keep track of certificate path for
  cases when tests change the working directory.
* docker-compose tests to use interpolation and environment variables in
  order to override `CERTS_DIR` and `COCKROACH_BINARY`.
* Add `copyRunfiles()` in order to copy Bazel-generated symlinked
  runfiles as regular files to make them available in docker mounted
  volumes.

Related: #71932, #71930
Fixes: #59446

Release note: None

72574: ci: add bazel roachtest gce teamcity job r=rail a=rickystewart

Release note: None

73055: ui: prevent undefined axis label on custom chart r=zachlite a=zachlite

Release note (bug fix): Y-axis labels on custom charts no longer display 'undefined'.

@thtruo, this fix addresses the issue as described in #72115.

Now, when the user selects a new unit from the dropdown, the user will experience up to a 10 second delay before the axis label refreshes.  @nathanstilwell and I investigated this last week, and we'd need more time to think of a solution that doesn't create long term maintenance headaches.  The benefit of this PR as it stands is that the Y-axis label is noticeably less broken. FYI.





73080: bazel: don't shard `kvserver` test r=rail a=rickystewart

The `exclusive` tag here prevents the shards from running concurrently.
See #65407, #65582.

Release note: None

Co-authored-by: Rail Aliiev <[email protected]>
Co-authored-by: Ricky Stewart <[email protected]>
Co-authored-by: Zach Lite <[email protected]>
craig bot pushed a commit that referenced this issue Dec 2, 2021
@rail
Merge #72611
328b2e8 
72611: bazel, ci: use test2json format for nightly logging r=rickystewart a=rail

Fixes #71930

Previously, bazel based nightlies didn't report errors as github issues.

This PR uses a custom feature of `rules_go` to save the log output in
`test2json` format. A new shell function is added to post-process the
generated log and ports the `run_json_test` features to submit failures
to GitHub.

Release note: None

Co-authored-by: Rail Aliiev <[email protected]>
@craig craig bot closed this as completed in c1861d3 Dec 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rail rail

Labels
A-build-system A-ci Continuous Integration C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. T-dev-inf
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

bazel, ci: use test2json format for nightly logging rail/cockroach
1 participant
@rail