bazel, ci: use test2json format for nightly logging #72611
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rail
added
C-enhancement
|
This change is |
rail
force-pushed
the
json_output_file_rules_go
branch
5 times, most recently
from
34668fc to
e047827
Compare
rickystewart
requested changes
Nov 16, 2021
rail
force-pushed
the
json_output_file_rules_go
branch
15 times, most recently
from
e268940 to
9c2511c
Compare
Fixes cockroachdb#71930 Previously, bazel based nightlies didn't report errors as github issues. This PR uses a custom feature of `rules_go` to save the log output in `test2json` format. A new shell function is added to post-process the generated log and ports the `run_json_test` features to submit failures to GitHub. Release note: None
rail
force-pushed
the
json_output_file_rules_go
branch
from
9c2511c to
c1861d3
Compare
|
I think this is ready to be reviewed. I pushed this rules_go change to the release-0.29 branch, so we can save logs in To be tested (in production): This is how it behaves when there is a test failure: artifacts And there is also a green test: artifacts |
rickystewart
approved these changes
Dec 2, 2021
|
bors r=rickystewart |
|
Build failed (retrying...): |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #71930
Previously, bazel based nightlies didn't report errors as github issues.
This PR uses a custom feature of
rules_goto save the log output intest2jsonformat. A new shell function is added to post-process thegenerated log and ports the
run_json_testfeatures to submit failuresto GitHub.
Release note: None