Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ui: DB Console custom chart incorrectly displays "undefined" for the y-axis for time-based metrics #72115

Closed
thtruo opened this issue Oct 28, 2021 · 1 comment
Closed

ui: DB Console custom chart incorrectly displays "undefined" for the y-axis for time-based metrics #72115

thtruo opened this issue Oct 28, 2021 · 1 comment
Assignees
@zachlite
Labels
C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.

Comments

@thtruo
Copy link
Contributor

thtruo commented Oct 28, 2021 •
edited by exalate-issue-sync bot
Loading

Describe the problem

Currently, the y-axis for custom charts will label the y-axis as "undefined" when attempting to display time-based metrics, e.g. sql.service.latency-p99.999

We should display "latency (ms)" like we do in our main metrics dashboard.

To Reproduce

  • Load the custom chart page within DB Console
  • Add a time-based metric, e.g. sql.service.latency-p99.999
  • Notice the y-axis reads "undefined"

Image 2021-10-28 at 2 33 29 PM

Environment:

  • 21.1.11 roachprod

Epic CRDB-8038
@thtruo thtruo added C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. T-cluster-ui labels Oct 28, 2021
@thtruo
Copy link
Contributor Author

thtruo commented Oct 28, 2021

cc @mikeczabator for awareness

@zachlite zachlite mentioned this issue Nov 22, 2021
Merged
craig bot pushed a commit that referenced this issue Nov 23, 2021
@rail @rickystewart
Merge #71770 #72574 #73055 #73080
2ac3cf4 
71770: bazel: run acceptance tests under Bazel r=rickystewart a=rail

This patch makes the acceptance test work under Bazel.

* Add `AbsCertsDir()` in order to keep track of certificate path for
  cases when tests change the working directory.
* docker-compose tests to use interpolation and environment variables in
  order to override `CERTS_DIR` and `COCKROACH_BINARY`.
* Add `copyRunfiles()` in order to copy Bazel-generated symlinked
  runfiles as regular files to make them available in docker mounted
  volumes.

Related: #71932, #71930
Fixes: #59446

Release note: None

72574: ci: add bazel roachtest gce teamcity job r=rail a=rickystewart

Release note: None

73055: ui: prevent undefined axis label on custom chart r=zachlite a=zachlite

Release note (bug fix): Y-axis labels on custom charts no longer display 'undefined'.

@thtruo, this fix addresses the issue as described in #72115.

Now, when the user selects a new unit from the dropdown, the user will experience up to a 10 second delay before the axis label refreshes.  @nathanstilwell and I investigated this last week, and we'd need more time to think of a solution that doesn't create long term maintenance headaches.  The benefit of this PR as it stands is that the Y-axis label is noticeably less broken. FYI.





73080: bazel: don't shard `kvserver` test r=rail a=rickystewart

The `exclusive` tag here prevents the shards from running concurrently.
See #65407, #65582.

Release note: None

Co-authored-by: Rail Aliiev <[email protected]>
Co-authored-by: Ricky Stewart <[email protected]>
Co-authored-by: Zach Lite <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zachlite zachlite

Labels
C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@thtruo @zachlite