-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: add bazel roachtest gce teamcity job #72574
Conversation
1ca5d2a
to
f0e20ab
Compare
f0e20ab
to
adb1e02
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 9 of 9 files at r2, all commit messages.
Reviewable status: complete! 0 of 0 LGTMs obtained (waiting on @rickystewart)
build/teamcity/cockroach/nightlies/roachtest_nightly_impl.sh, line 101 at r2 (raw file):
Teamcity has a 1300 minute timeout
I think you can remove this comment and timeout
, see #72601
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM on the roachtest portion. Left some comments on the rest too but will defer to @rail for that part of the PR.
Done. |
adb1e02
to
e0be8f9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 5 of 5 files at r3, all commit messages.
Reviewable status: complete! 1 of 0 LGTMs obtained (waiting on @rickystewart and @tbg)
Release note: None
e0be8f9
to
56260ba
Compare
TFTR! bors r=rail |
Build failed (retrying...): |
Build succeeded: |
Release note: None