Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add bazel roachtest gce teamcity job #72574

Merged
merged 1 commit into from
Nov 23, 2021

Conversation

rickystewart
Copy link
Collaborator

Release note: None

@rickystewart rickystewart requested a review from a team as a code owner November 9, 2021 16:17
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@rickystewart rickystewart force-pushed the roachtest_gce branch 12 times, most recently from 1ca5d2a to f0e20ab Compare November 11, 2021 18:53
@rickystewart rickystewart requested a review from a team as a code owner November 11, 2021 18:53
@rickystewart rickystewart requested review from stevendanna and removed request for a team November 11, 2021 18:53
@rickystewart rickystewart requested review from rail and removed request for stevendanna November 11, 2021 23:02
@rickystewart
Copy link
Collaborator Author

Sample run.

Copy link
Member

@rail rail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 9 of 9 files at r2, all commit messages.
Reviewable status: :shipit: complete! 0 of 0 LGTMs obtained (waiting on @rickystewart)


build/teamcity/cockroach/nightlies/roachtest_nightly_impl.sh, line 101 at r2 (raw file):

Teamcity has a 1300 minute timeout

I think you can remove this comment and timeout, see #72601

Copy link
Member

@tbg tbg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM on the roachtest portion. Left some comments on the rest too but will defer to @rail for that part of the PR.

@rickystewart
Copy link
Collaborator Author

Teamcity has a 1300 minute timeout

I think you can remove this comment and timeout, see #72601

Done.

Copy link
Member

@rail rail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 5 of 5 files at r3, all commit messages.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @rickystewart and @tbg)

@tbg tbg removed their request for review November 23, 2021 10:28
@rickystewart
Copy link
Collaborator Author

TFTR!

bors r=rail

@craig
Copy link
Contributor

craig bot commented Nov 23, 2021

Build failed (retrying...):

@craig
Copy link
Contributor

craig bot commented Nov 23, 2021

Build succeeded:

@craig craig bot merged commit 2ac3cf4 into cockroachdb:master Nov 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants