Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

roachtest: schemachange/invertedindex failed [unsafe tscache update] #61060

Closed
cockroach-teamcity opened this issue Feb 24, 2021 · 2 comments · Fixed by #61130
Closed

roachtest: schemachange/invertedindex failed [unsafe tscache update] #61060

cockroach-teamcity opened this issue Feb 24, 2021 · 2 comments · Fixed by #61130
Assignees
Labels
branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-roachtest O-robot Originated from a bot. release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked.

Comments

@cockroach-teamcity
Copy link
Member

(roachtest).schemachange/invertedindex failed on master@ec011620c7cf299fdbb898db692b36454defc4a2:

		  | main.registerSchemaChangeInvertedIndex.func1
		  | 	/home/agent/work/.go/src/github.com/cockroachdb/cockroach/pkg/cmd/roachtest/inverted_index.go:27
		  | main.(*testRunner).runTest.func2
		  | 	/home/agent/work/.go/src/github.com/cockroachdb/cockroach/pkg/cmd/roachtest/test_runner.go:767
		Wraps: (2) monitor failure
		Wraps: (3) attached stack trace
		  -- stack trace:
		  | main.(*monitor).wait.func2
		  | 	/home/agent/work/.go/src/github.com/cockroachdb/cockroach/pkg/cmd/roachtest/cluster.go:2732
		Wraps: (4) monitor task failed
		Wraps: (5) attached stack trace
		  -- stack trace:
		  | main.init
		  | 	/home/agent/work/.go/src/github.com/cockroachdb/cockroach/pkg/cmd/roachtest/cluster.go:2646
		  | runtime.doInit
		  | 	/usr/local/go/src/runtime/proc.go:5652
		  | runtime.main
		  | 	/usr/local/go/src/runtime/proc.go:191
		  | runtime.goexit
		  | 	/usr/local/go/src/runtime/asm_amd64.s:1374
		Wraps: (6) t.Fatal() was called
		Error types: (1) *withstack.withStack (2) *errutil.withPrefix (3) *withstack.withStack (4) *errutil.withPrefix (5) *withstack.withStack (6) *errutil.leafError

	cluster.go:1667,context.go:140,cluster.go:1656,test_runner.go:848: dead node detection: /home/agent/work/.go/src/github.com/cockroachdb/cockroach/bin/roachprod monitor teamcity-2712399-1614149800-82-n5cpu4 --oneshot --ignore-empty-nodes: exit status 1 5: skipped
		2: 4666
		1: dead
		4: 4442
		3: 4469
		Error: UNCLASSIFIED_PROBLEM: 1: dead
		(1) UNCLASSIFIED_PROBLEM
		Wraps: (2) attached stack trace
		  -- stack trace:
		  | main.glob..func14
		  | 	/home/agent/work/.go/src/github.com/cockroachdb/cockroach/pkg/cmd/roachprod/main.go:1147
		  | main.wrap.func1
		  | 	/home/agent/work/.go/src/github.com/cockroachdb/cockroach/pkg/cmd/roachprod/main.go:271
		  | github.com/spf13/cobra.(*Command).execute
		  | 	/home/agent/work/.go/src/github.com/cockroachdb/cockroach/vendor/github.com/spf13/cobra/command.go:830
		  | github.com/spf13/cobra.(*Command).ExecuteC
		  | 	/home/agent/work/.go/src/github.com/cockroachdb/cockroach/vendor/github.com/spf13/cobra/command.go:914
		  | github.com/spf13/cobra.(*Command).Execute
		  | 	/home/agent/work/.go/src/github.com/cockroachdb/cockroach/vendor/github.com/spf13/cobra/command.go:864
		  | main.main
		  | 	/home/agent/work/.go/src/github.com/cockroachdb/cockroach/pkg/cmd/roachprod/main.go:1852
		  | runtime.main
		  | 	/usr/local/go/src/runtime/proc.go:204
		  | runtime.goexit
		  | 	/usr/local/go/src/runtime/asm_amd64.s:1374
		Wraps: (3) 1: dead
		Error types: (1) errors.Unclassified (2) *withstack.withStack (3) *errutil.leafError

More

Artifacts: /schemachange/invertedindex
Related:

See this test on roachdash
powered by pkg/cmd/internal/issues

@cockroach-teamcity cockroach-teamcity added branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-roachtest O-robot Originated from a bot. release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked. labels Feb 24, 2021
@thoszhang
Copy link
Contributor

From node 1:

F210224 11:55:51.207007 170 kv/kvserver/replica_tscache.go:69 ⋮ [n1,s1,r47/1:‹/{Table/53/1/2…-Max}›] 678  Unsafe timestamp cache update! Cannot add timestamp 1614167741.253837393,2 to timestamp cache after evaluating Put [‹/Table/53/1/2595000/0›,‹/Min›), Put [‹/Table/53/1/2595001/0›,‹/Min›), Put [‹/Table/53/1/2595002/0›,‹/Min›), Put [‹/Table/53/1/2595003/0›,‹/Min›), Put [‹/Table/53/1/2595004/0›,‹/Min›), Put [‹/Table/53/1/2595005/0›,‹/Min›), Put [‹/Table/53/1/2595006/0›,‹/Min›), Put [‹/Table/53/1/2595007/0›,‹/Min›), Put [‹/Table/53/1/2595008/0›,‹/Min›), Put [‹/Table/53/1/2595009/0›,‹/Min›), Put [‹/Table/53/1/2595010/0›,‹/Min›), Put [‹/Table/53/1/2595011/0›,‹/Min›), Put [‹/Table/53/1/2595012/0›,‹/Min›), Put [‹/Table/53/1/2595013/0›,‹/Min›), Put [‹/Table/53/1/2595014/0›,‹/Min›), Put [‹/Table/53/1/2595015/0›,‹/Min›), Put [‹/Table/53/1/2595016/0›,‹/Min›), Put [‹/Table/53/1/2595017/0›,‹/Min›), Put [‹/Table/53/1/2595018/0›,‹/Min›), Put [‹/Table/53/1/2595019/0›,‹/Mi
F210224 11:55:51.207007 170 kv/kvserver/replica_tscache.go:69 ⋮ [n1,s1,r47/1:‹/{Table/53/1/2…-Max}›] 678 |n›),... 976 skipped ..., Put [‹/Table/53/1/2595996/0›,‹/Min›), Put [‹/Table/53/1/2595997/0›,‹/Min›), Put [‹/Table/53/1/2595998/0›,‹/Min›), Put [‹/Table/53/1/2595999/0›,‹/Min›), EndTxn(commit:true) [‹/Table/53/1/2595000/0›], [txn: 78b043f3], [can-forward-ts] (resp=‹(err: <nil>), *roachpb.PutResponse, *roachpb.PutResponse, *roachpb.PutResponse, *roachpb.PutResponse, *roachpb.PutResponse, *roachpb.PutResponse, *roachpb.PutResponse, *roachpb.PutResponse, *roachpb.PutResponse, *roachpb.PutResponse, *roachpb.PutResponse, *roachpb.PutResponse, *roachpb.PutResponse, *roachpb.PutResponse, *roachpb.PutResponse, *roachpb.PutResponse, *roachpb.PutResponse, *roachpb.PutResponse, *roachpb.PutResponse, *roachpb.PutResponse, ... 976 skipped ..., *roachpb.PutResponse, *roachpb.PutResponse, *roachpb.PutResponse, *roachpb.PutResponse, *roachpb.EndTxnResponse›; err=<nil>) with local hlc clock at timestamp 1614167740.056937032,0. Non-synthetic timestamps should always lag the local hlc cl
F210224 11:55:51.207007 170 kv/kvserver/replica_tscache.go:69 ⋮ [n1,s1,r47/1:‹/{Table/53/1/2…-Max}›] 678 |ock.

@nvanbenschoten I think this is the same failure as in #60779.

@tbg tbg changed the title roachtest: schemachange/invertedindex failed roachtest: schemachange/invertedindex failed [unsafe tscache update] Feb 25, 2021
@cockroach-teamcity
Copy link
Member Author

(roachtest).schemachange/invertedindex failed on master@c7e088826bc079620dfd3b5ae75d1c15cd9cd16d:

		  | Error types: (1) *exec.ExitError
		Wraps: (5) context canceled
		Error types: (1) *withstack.withStack (2) *errutil.withPrefix (3) *main.withCommandDetails (4) *secondary.withSecondaryError (5) *errors.errorString

	cluster.go:2688,inverted_index.go:76,inverted_index.go:27,test_runner.go:767: monitor failure: unexpected node event: 4: dead
		(1) attached stack trace
		  -- stack trace:
		  | main.(*monitor).WaitE
		  | 	/home/agent/work/.go/src/github.com/cockroachdb/cockroach/pkg/cmd/roachtest/cluster.go:2676
		  | main.(*monitor).Wait
		  | 	/home/agent/work/.go/src/github.com/cockroachdb/cockroach/pkg/cmd/roachtest/cluster.go:2684
		  | main.runSchemaChangeInvertedIndex
		  | 	/home/agent/work/.go/src/github.com/cockroachdb/cockroach/pkg/cmd/roachtest/inverted_index.go:76
		  | main.registerSchemaChangeInvertedIndex.func1
		  | 	/home/agent/work/.go/src/github.com/cockroachdb/cockroach/pkg/cmd/roachtest/inverted_index.go:27
		  | main.(*testRunner).runTest.func2
		  | 	/home/agent/work/.go/src/github.com/cockroachdb/cockroach/pkg/cmd/roachtest/test_runner.go:767
		  | runtime.goexit
		  | 	/usr/local/go/src/runtime/asm_amd64.s:1374
		Wraps: (2) monitor failure
		Wraps: (3) unexpected node event: 4: dead
		Error types: (1) *withstack.withStack (2) *errutil.withPrefix (3) *errors.errorString

	cluster.go:1667,context.go:140,cluster.go:1656,test_runner.go:848: dead node detection: /home/agent/work/.go/src/github.com/cockroachdb/cockroach/bin/roachprod monitor teamcity-2716822-1614236552-51-n5cpu4 --oneshot --ignore-empty-nodes: exit status 1 5: skipped
		4: dead
		1: 9976
		2: 8818
		3: 9724
		Error: UNCLASSIFIED_PROBLEM: 4: dead
		(1) UNCLASSIFIED_PROBLEM
		Wraps: (2) attached stack trace
		  -- stack trace:
		  | main.glob..func14
		  | 	/home/agent/work/.go/src/github.com/cockroachdb/cockroach/pkg/cmd/roachprod/main.go:1147
		  | main.wrap.func1
		  | 	/home/agent/work/.go/src/github.com/cockroachdb/cockroach/pkg/cmd/roachprod/main.go:271
		  | github.com/spf13/cobra.(*Command).execute
		  | 	/home/agent/work/.go/src/github.com/cockroachdb/cockroach/vendor/github.com/spf13/cobra/command.go:830
		  | github.com/spf13/cobra.(*Command).ExecuteC
		  | 	/home/agent/work/.go/src/github.com/cockroachdb/cockroach/vendor/github.com/spf13/cobra/command.go:914
		  | github.com/spf13/cobra.(*Command).Execute
		  | 	/home/agent/work/.go/src/github.com/cockroachdb/cockroach/vendor/github.com/spf13/cobra/command.go:864
		  | main.main
		  | 	/home/agent/work/.go/src/github.com/cockroachdb/cockroach/pkg/cmd/roachprod/main.go:1852
		  | runtime.main
		  | 	/usr/local/go/src/runtime/proc.go:204
		  | runtime.goexit
		  | 	/usr/local/go/src/runtime/asm_amd64.s:1374
		Wraps: (3) 4: dead
		Error types: (1) errors.Unclassified (2) *withstack.withStack (3) *errutil.leafError

More

Artifacts: /schemachange/invertedindex
Related:

See this test on roachdash
powered by pkg/cmd/internal/issues

craig bot pushed a commit that referenced this issue Feb 26, 2021
61113: ui: show replica type on the range report page r=aayushshah15 a=aayushshah15

Resolves #59677 

Release justification: observability improvement

Release note (ui change): the range report page on the admin ui will now
also show each of the replica's types

61128: jobs: introduce jobspb.JobID r=lucy-zhang a=lucy-zhang

This commit introduces a `jobspb.JobID` int64 type and uses it in most
places where we were previously using an int64.

Closes #61121.

Release justification: Low-risk change to existing functionality.

Release note: None

61129: geo/wkt: update parsing of dimensions for empty geometrycollections r=otan,rafiss a=andyyang890

Previously, the data structure used for storing geometry collections
was unable to store a layout, which made it impossible to distinguish
empty geometry collections of different layouts. That issue has since
been fixed and this patch updates the parser accordingly.

Resolves #61035.

Refs: #53091

Release justification: bug fix for new functionality
Release note: None

61130: kv: disable timestamp cache + current clock assertion r=nvanbenschoten a=nvanbenschoten

Closes #60580.
Closes #60736.
Closes #60779.
Closes #61060.

This was added in 218a5a3. The check was more of a sanity check that we have and
always have had an understand of the timestamps that can enter the timestamp
cache. The fact that it's failing is a clear indication that there were issues
in past releases, because a lease transfer used to only be safe if the outgoing
leaseholder's clock was above the time of any read in its timestamp cache. We
now ship a snapshot of the timestamp cache on lease transfers, so that invariant
is less important.

I'd still like to get to the bottom of this, but I'll do so on my own branch,
off of master where it's causing disruption.

Release justification: avoid assertion failures

61155: jobs: make sure we finish spans if canceled before starting job r=ajwerner a=ajwerner

Was seeing:
```
    testcluster.go:135: condition failed to evaluate within 45s: unexpectedly found active spans:
             0.000ms      0.000ms    === operation:job _unfinished:1 intExec:create-stats
        goroutine 84 [running]:
        runtime/debug.Stack(0xc0086b1890, 0x792e940, 0xc009ac37e0)
        	/usr/local/go/src/runtime/debug/stack.go:24 +0xab
```

In roachprod stressrace with a big cluster. This seemed to fix it.

Release justification: bug fixes and low-risk updates to new functionality.

Release note: None

Co-authored-by: Aayush Shah <[email protected]>
Co-authored-by: Lucy Zhang <[email protected]>
Co-authored-by: Andy Yang <[email protected]>
Co-authored-by: Nathan VanBenschoten <[email protected]>
Co-authored-by: Andrew Werner <[email protected]>
@craig craig bot closed this as completed in 54f29fe Feb 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-roachtest O-robot Originated from a bot. release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants