Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jobs: introduce JobID type #61121

Closed
thoszhang opened this issue Feb 25, 2021 · 0 comments · Fixed by #61128
Closed

jobs: introduce JobID type #61121

thoszhang opened this issue Feb 25, 2021 · 0 comments · Fixed by #61128
Labels
A-jobs C-cleanup Tech debt, refactors, loose ends, etc. Solution not expected to significantly change behavior.

Comments

@thoszhang
Copy link
Contributor

We should introduce this in jobs or jobspb:

type JobID int64

const InvalidJobID JobID = 0

Replacing all the existing usages will be mechanical but annoying. A good start would be to just replace the IDs in the jobs packages themselves, though we use job IDs in many other places, including in proto messages (for table descriptors, etc.).
@thoszhang thoszhang added C-cleanup Tech debt, refactors, loose ends, etc. Solution not expected to significantly change behavior. A-jobs labels Feb 25, 2021
@thoszhang thoszhang mentioned this issue Feb 25, 2021
Merged
@craig craig bot closed this as completed in #61128 Feb 26, 2021
@craig craig bot closed this as completed in 8f612b4 Feb 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-jobs C-cleanup Tech debt, refactors, loose ends, etc. Solution not expected to significantly change behavior.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

jobs: introduce jobspb.JobID thoszhang/cockroach
1 participant
@thoszhang