jobs: introduce jobspb.JobID #61128
Merged
jobs: introduce jobspb.JobID #61128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
|
I wasn't originally planning to do this right now, but I got too deep into it. There are probably still some tests that need to be fixed. |
thoszhang
force-pushed
the
job-id-type
branch
from
faa9a21 to
5a36b80
Compare
ajwerner
approved these changes
Feb 25, 2021
There was a problem hiding this comment.
Reviewed 69 of 69 files at r1.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @ajwerner and @pbardea)
thoszhang
force-pushed
the
job-id-type
branch
4 times, most recently
from
7456700 to
6101124
Compare
|
TFTR bors r+ |
|
Merge conflict. |
This commit introduces a `jobspb.JobID` int64 type and uses it in most places where we were previously using an int64. Release justification: Low-risk change to existing functionality. Release note: None
thoszhang
force-pushed
the
job-id-type
branch
from
6101124 to
1e3f1b7
Compare
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit introduces a
jobspb.JobIDint64 type and uses it in mostplaces where we were previously using an int64.
Closes #61121.
Release justification: Low-risk change to existing functionality.
Release note: None