Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

roachtest: alterpk-bank failed [unsafe ts cache update] #60736

Closed
cockroach-teamcity opened this issue Feb 18, 2021 · 4 comments · Fixed by #61130
Closed

roachtest: alterpk-bank failed [unsafe ts cache update] #60736

cockroach-teamcity opened this issue Feb 18, 2021 · 4 comments · Fixed by #61130
Assignees
Labels
branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-roachtest O-robot Originated from a bot. release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked.

Comments

@cockroach-teamcity
Copy link
Member

(roachtest).alterpk-bank failed on master@3c223f5f5162103110a790743b687ef2bf952489:

The test failed on branch=master, cloud=gce:
test artifacts and logs in: /home/agent/work/.go/src/github.com/cockroachdb/cockroach/artifacts/alterpk-bank/run_1
	alterpk.go:52,cluster.go:2665,errgroup.go:57: output in run_070543.264_n4_workload_init_bank: /home/agent/work/.go/src/github.com/cockroachdb/cockroach/bin/roachprod run teamcity-2688408-1613631814-02-n4cpu4:4 -- ./workload init bank --drop --rows 1000000 {pgurl:1-3} returned: context canceled
		(1) attached stack trace
		  -- stack trace:
		  | main.(*cluster).RunE
		  | 	/home/agent/work/.go/src/github.com/cockroachdb/cockroach/pkg/cmd/roachtest/cluster.go:2331
		  | main.registerAlterPK.func2.1
		  | 	/home/agent/work/.go/src/github.com/cockroachdb/cockroach/pkg/cmd/roachtest/alterpk.go:51
		  | main.(*monitor).Go.func1
		  | 	/home/agent/work/.go/src/github.com/cockroachdb/cockroach/pkg/cmd/roachtest/cluster.go:2665
		  | golang.org/x/sync/errgroup.(*Group).Go.func1
		  | 	/home/agent/work/.go/src/github.com/cockroachdb/cockroach/vendor/golang.org/x/sync/errgroup/errgroup.go:57
		  | runtime.goexit
		  | 	/usr/local/go/src/runtime/asm_amd64.s:1374
		Wraps: (2) output in run_070543.264_n4_workload_init_bank
		Wraps: (3) /home/agent/work/.go/src/github.com/cockroachdb/cockroach/bin/roachprod run teamcity-2688408-1613631814-02-n4cpu4:4 -- ./workload init bank --drop --rows 1000000 {pgurl:1-3} returned
		  | stderr:
		  |
		  | stdout:
		Wraps: (4) secondary error attachment
		  | signal: killed
		  | (1) signal: killed
		  | Error types: (1) *exec.ExitError
		Wraps: (5) context canceled
		Error types: (1) *withstack.withStack (2) *errutil.withPrefix (3) *main.withCommandDetails (4) *secondary.withSecondaryError (5) *errors.errorString

	test_runner.go:826: test timed out (10h0m0s)

More

Artifacts: /alterpk-bank
Related:

See this test on roachdash
powered by pkg/cmd/internal/issues

@cockroach-teamcity cockroach-teamcity added branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-roachtest O-robot Originated from a bot. release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked. labels Feb 18, 2021
@jordanlewis
Copy link
Member

@nvanbenschoten is this one of the KV issues you've been triaging recently?

@nvanbenschoten
Copy link
Member

It doesn't look like it, unfortunately, based on the timing.

@jordanlewis
Copy link
Member

cc @ajwerner

@thoszhang
Copy link
Contributor

@nvanbenschoten This also looks like #60779:

F210218 07:05:54.914646 149 kv/kvserver/replica_tscache.go:69 â‹® [n1,s1,r37/1:‹/{Table/53-Max}›] 289  Unsafe timestamp cache update! Cannot add timestamp 1613631951.490620506,2 to timestamp cache after evaluating ConditionalPut [‹/Table/53/1/169000/0›,‹/Min›), ConditionalPut [‹/Table/53/1/169001/0›,‹/Min›), ConditionalPut [‹/Table/53/1/169002/0›,‹/Min›), ConditionalPut [‹/Table/53/1/169003/0›,‹/Min›), ConditionalPut [‹/Table/53/1/169004/0›,‹/Min›), ConditionalPut [‹/Table/53/1/169005/0›,‹/Min›), ConditionalPut [‹/Table/53/1/169006/0›,‹/Min›), ConditionalPut [‹/Table/53/1/169007/0›,‹/Min›), ConditionalPut [‹/Table/53/1/169008/0›,‹/Min›), ConditionalPut [‹/Table/53/1/169009/0›,‹/Min›), ConditionalPut [‹/Table/53/1/169010/0›,‹/Min›), ConditionalPut [‹/Table/53/1/169011/0›,‹/Min›), ConditionalPut [‹/Table/53/1/169012/0›,‹/Min›), ConditionalPut [‹/Table/53/1/169013/0›,‹/Min›), ConditionalPut [‹/Table/53/1/169014/0›,‹/Min›), ConditionalPut [‹/Table/53/1/169015/0›,‹/Min›), ConditionalPut [â
F210218 07:05:54.914646 149 kv/kvserver/replica_tscache.go:69 â‹® [n1,s1,r37/1:‹/{Table/53-Max}›] 289 |€¹/Table/53/1/169016/0›,‹/Min›), ConditionalPut [‹/Table/53/1/169017/0›,‹/Min›), ConditionalPut [‹/Table/53/1/169018/0›,‹/Min›), ConditionalPut [‹/Table/53/1/169019/0›,‹/Min›),... 976 skipped ..., ConditionalPut [‹/Table/53/1/169996/0›,‹/Min›), ConditionalPut [‹/Table/53/1/169997/0›,‹/Min›), ConditionalPut [‹/Table/53/1/169998/0›,‹/Min›), ConditionalPut [‹/Table/53/1/169999/0›,‹/Min›), EndTxn(commit:true) [‹/Table/53/1/169000/0›], [txn: cc64b55a], [can-forward-ts] (resp=‹(err: <nil>), *roachpb.ConditionalPutResponse, *roachpb.ConditionalPutResponse, *roachpb.ConditionalPutResponse, *roachpb.ConditionalPutResponse, *roachpb.ConditionalPutResponse, *roachpb.ConditionalPutResponse, *roachpb.ConditionalPutResponse, *roachpb.ConditionalPutResponse, *roachpb.ConditionalPutResponse, *roachpb.ConditionalPutResponse, *roachpb.ConditionalPutResponse, *roachpb.ConditionalPutResponse, *roachpb.ConditionalPutResponse, *roachpb.ConditionalPutResponse, *roa
F210218 07:05:54.914646 149 kv/kvserver/replica_tscache.go:69 ⋮ [n1,s1,r37/1:‹/{Table/53-Max}›] 289 |chpb.ConditionalPutResponse, *roachpb.ConditionalPutResponse, *roachpb.ConditionalPutResponse, *roachpb.ConditionalPutResponse, *roachpb.ConditionalPutResponse, *roachpb.ConditionalPutResponse, ... 976 skipped ..., *roachpb.ConditionalPutResponse, *roachpb.ConditionalPutResponse, *roachpb.ConditionalPutResponse, *roachpb.ConditionalPutResponse, *roachpb.EndTxnResponse›; err=<nil>) with local hlc clock at timestamp 1613631951.213529105,0. Non-synthetic timestamps should always lag the local hlc clock.

I'll move this to the KV backlog for now.

@tbg tbg changed the title roachtest: alterpk-bank failed roachtest: alterpk-bank failed [unsafe ts cache update] Feb 25, 2021
craig bot pushed a commit that referenced this issue Feb 26, 2021
61113: ui: show replica type on the range report page r=aayushshah15 a=aayushshah15

Resolves #59677 

Release justification: observability improvement

Release note (ui change): the range report page on the admin ui will now
also show each of the replica's types

61128: jobs: introduce jobspb.JobID r=lucy-zhang a=lucy-zhang

This commit introduces a `jobspb.JobID` int64 type and uses it in most
places where we were previously using an int64.

Closes #61121.

Release justification: Low-risk change to existing functionality.

Release note: None

61129: geo/wkt: update parsing of dimensions for empty geometrycollections r=otan,rafiss a=andyyang890

Previously, the data structure used for storing geometry collections
was unable to store a layout, which made it impossible to distinguish
empty geometry collections of different layouts. That issue has since
been fixed and this patch updates the parser accordingly.

Resolves #61035.

Refs: #53091

Release justification: bug fix for new functionality
Release note: None

61130: kv: disable timestamp cache + current clock assertion r=nvanbenschoten a=nvanbenschoten

Closes #60580.
Closes #60736.
Closes #60779.
Closes #61060.

This was added in 218a5a3. The check was more of a sanity check that we have and
always have had an understand of the timestamps that can enter the timestamp
cache. The fact that it's failing is a clear indication that there were issues
in past releases, because a lease transfer used to only be safe if the outgoing
leaseholder's clock was above the time of any read in its timestamp cache. We
now ship a snapshot of the timestamp cache on lease transfers, so that invariant
is less important.

I'd still like to get to the bottom of this, but I'll do so on my own branch,
off of master where it's causing disruption.

Release justification: avoid assertion failures

61155: jobs: make sure we finish spans if canceled before starting job r=ajwerner a=ajwerner

Was seeing:
```
    testcluster.go:135: condition failed to evaluate within 45s: unexpectedly found active spans:
             0.000ms      0.000ms    === operation:job _unfinished:1 intExec:create-stats
        goroutine 84 [running]:
        runtime/debug.Stack(0xc0086b1890, 0x792e940, 0xc009ac37e0)
        	/usr/local/go/src/runtime/debug/stack.go:24 +0xab
```

In roachprod stressrace with a big cluster. This seemed to fix it.

Release justification: bug fixes and low-risk updates to new functionality.

Release note: None

Co-authored-by: Aayush Shah <[email protected]>
Co-authored-by: Lucy Zhang <[email protected]>
Co-authored-by: Andy Yang <[email protected]>
Co-authored-by: Nathan VanBenschoten <[email protected]>
Co-authored-by: Andrew Werner <[email protected]>
@craig craig bot closed this as completed in 54f29fe Feb 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-roachtest O-robot Originated from a bot. release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants