-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
all: update dependencies #30774
Comments
I don't think so. I was planning to do it this time but forgot about it. I'll try to get to it. |
Are you thinking of github.com/dt/depdiff?
…On Wed, Dec 5, 2018 at 7:17 AM Tobias Grieger ***@***.***> wrote:
We need to audit all the commits we're picking up. I remember that @tamird
<https://github.com/tamird> had some script to do this automatically.
@tamird <https://github.com/tamird>, do you remember where that went?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#30774 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AA15IMK5xWpjsSm2w87wpQfOtgsN8PK0ks5u17logaJpZM4W_C1y>
.
|
That's exactly it, thanks! |
Great! I will try to do it in multiple batches, and separate out the more important packages (like gRPC), so we can at least bisect if there's a problem. |
Note that @benesch and I are bumping RocksDB (which is a massive pain). |
Informs cockroachdb#30774. Release note: None
32805: parser: batch some allocations in the scanner r=RaduBerinde a=RaduBerinde The scanner allocates copies of all uppercase identifiers; preallocate a buffer (proportional to the size of the query) to save some of these allocations. Benchmark: ``` name old time/op new time/op delta Parse 33.8µs ± 1% 33.7µs ± 1% ~ (p=0.699 n=6+6) name old alloc/op new alloc/op delta Parse 5.54kB ± 0% 5.68kB ± 0% +2.60% (p=0.002 n=6+6) name old allocs/op new allocs/op delta Parse 92.0 ± 0% 81.0 ± 0% -11.96% (p=0.002 n=6+6) ``` Release note: None 32866: update cloud storage deps r=RaduBerinde a=RaduBerinde Informs #30774. Release note: None googleapis/google-cloud-go@0fd7230...0ebda48 Azure/azure-pipeline-go@7571e8e...b8e3409 aws/aws-sdk-go@ee1f179...ddc06f9 I ran all the ccl tests with `customenv.mk`. The Azure keys are no longer valid, all other tests passed. Co-authored-by: Radu Berinde <[email protected]>
Changes: golang/dep@bbe56e5...22125cf golang/lint@6aaf7c3...883fe33 golang/protobuf@b4deda0...aa810b6 golang/snappy@553a641...2e65f85 Informs cockroachdb#30774. Release note: None
32883: update golang deps r=RaduBerinde a=RaduBerinde Changes: golang/dep@bbe56e5...22125cf golang/lint@6aaf7c3...883fe33 golang/protobuf@b4deda0...aa810b6 golang/snappy@553a641...2e65f85 Informs #30774. Release note: None Co-authored-by: Radu Berinde <[email protected]>
Changes: - golang/crypto@3d3f9f4...505ab14 - golang/net@c73622c...351d144 - golang/oauth2@6881fee...d668ce9 - golang/perf@4469e6c...6e6d33e - golang/sync@8e0aa68...42b3178 - golang/sys@95c6576...a5c9d58 - golang/time@6dc1736...85acf8d - golang/tools@90b807a...22934f0 Informs cockroachdb#30774. Release note: None
32922: Update golang.org/x deps r=RaduBerinde a=RaduBerinde Changes: - golang/crypto@3d3f9f4...505ab14 - golang/net@c73622c...351d144 - golang/oauth2@6881fee...d668ce9 - golang/perf@4469e6c...6e6d33e - golang/sync@8e0aa68...42b3178 - golang/sys@95c6576...a5c9d58 - golang/time@6dc1736...85acf8d - golang/tools@90b807a...22934f0 Informs #30774. Release note: None Co-authored-by: Radu Berinde <[email protected]>
This change updates the protobuf deps and makes various fixes. Most fixes are related to new `XXX_` fields. In particular, the new fields interfere with JSON marshaling and printing with `%v`. Note that the new fields could be omitted but that is undesirable: `XXX_NoUnkeyedLiteral` is a good idea and there would be a performance cost associated with removing `XXX_sizecache`. Some more info on important protobuf changes here: https://groups.google.com/forum/#!topic/golang-nuts/F5xFHTfwRnY Change lists: gogo/protobuf@1adfc12...936d59a googleapis/go-genproto@f676e0f...a1fde74 Note that gogo/protobuf was forked under cockroachdb, and I made a fix in our fork. This commit should be reviewed: gogo/protobuf@d0154be Informs cockroachdb#30774. Release note: None
This change updates the protobuf deps and makes various fixes. Most fixes are related to new `XXX_` fields. In particular, the new fields interfere with JSON marshaling and printing with `%v`. Note that the new fields could be omitted but that is undesirable: `XXX_NoUnkeyedLiteral` is a good idea and there would be a performance cost associated with removing `XXX_sizecache`. Some more info on important protobuf changes here: https://groups.google.com/forum/#!topic/golang-nuts/F5xFHTfwRnY Change lists: gogo/protobuf@1adfc12...936d59a googleapis/go-genproto@f676e0f...a1fde74 Note that gogo/protobuf was forked under cockroachdb, and I made a fix in our fork. This commit should be reviewed: cockroachdb/gogoproto@d26e6ac Informs cockroachdb#30774. Release note: None
33329: *: update protobuf-related deps r=RaduBerinde a=RaduBerinde This change updates the protobuf deps and makes various fixes. Most fixes are related to new `XXX_` fields. In particular, the new fields interfere with JSON marshaling and printing with `%v`. Note that the new fields could be omitted but that is undesirable: `XXX_NoUnkeyedLiteral` is a good idea and there would be a performance cost associated with removing `XXX_sizecache`. Some more info on important protobuf changes here: https://groups.google.com/forum/#!topic/golang-nuts/F5xFHTfwRnY Change lists: gogo/protobuf@1adfc12...936d59a googleapis/go-genproto@f676e0f...a1fde74 Note that gogo/protobuf was forked under cockroachdb, and I made a fix in our fork. This commit should be reviewed: gogo/protobuf@d0154be Informs #30774. Release note: None I ran some before/after tests with a KV workload, didn't see any difference beyond the usual variations. Co-authored-by: Radu Berinde <[email protected]>
I believe that I updated all dependencies, except I will keep the issue open as a reminder to update deps periodically. |
Update all deps except: - errcheck (due to kisielk/errcheck#162) - honnef.co/go/tools (requires refactoring) - some `github.com/cockroachdb/` deps which have been updated for go1.11. Changes: Azure/azure-storage-blob-go@5152f14...45d0c5e IBM/sarama@bbdbe64...879f631 aws/aws-sdk-go@ddc06f9...1f8a246 axiomhq/hyperloglog@e8c19f1...4b99d0c cenkalti/backoff@62661b4...1e4cf3d cockroachdb/circuitbreaker@4f5b168...3e861b2 distribution/distribution@40b7b58...91b0f05 moby/moby@a4a816b...b4842cf go-ole/go-ole@a41e3c4...39dc848 go-sql-driver/mysql@60d456a...c45f530 google/go-github@35781f7...a5cb647 google/pprof@3ea8567...e84dfd6 googleapis/gax-go@b001040...c8a15ba grpc-ecosystem/grpc-gateway@9258377...aeab1d9 jmespath/go-jmespath@0b12d6b...c2b33e8 linkedin/goavro@1beee2a...af12b3c mattn/go-runewidth@ce7b0b5...3ee7d81 montanaflynn/stats@db72e6c...945b007 pkg/errors@645ef00...ba968bf prometheus/client_model@5c3871d...f287a10 prometheus/common@4724e92...2998b13 prometheus/procfs@1dc9a6c...b1a0a9a shirou/gopsutil@0f70a4a...ccc1c10 sirupsen/logrus@bcd833d...e1e72e9 stretchr/testify@f35b8ab...ffdc059 etcd-io/etcd@1900a8e...fae6e92 golang/crypto@505ab14...ff983b9 golang/net@351d144...1e06a53 golang/sync@42b3178...37e7f08 golang/sys@70b957f...48ac38b golang/tools@bcd4e47...d30e00c googleapis/google-api-go-client@9c79dee...19e022d golang/appengine@150dc57...e9657d8 Informs cockroachdb#30774. Release note: None
Update all deps except: - errcheck (due to kisielk/errcheck#162) - honnef.co/go/tools (requires refactoring) - some `github.com/cockroachdb/` deps which have been updated for go1.11. Changes: Azure/azure-storage-blob-go@5152f14...45d0c5e IBM/sarama@bbdbe64...879f631 aws/aws-sdk-go@ddc06f9...1f8a246 axiomhq/hyperloglog@e8c19f1...4b99d0c cenkalti/backoff@62661b4...1e4cf3d cockroachdb/circuitbreaker@4f5b168...3e861b2 distribution/distribution@40b7b58...91b0f05 moby/moby@a4a816b...b4842cf go-ole/go-ole@a41e3c4...39dc848 go-sql-driver/mysql@60d456a...c45f530 google/go-github@35781f7...a5cb647 google/pprof@3ea8567...e84dfd6 googleapis/gax-go@b001040...c8a15ba grpc-ecosystem/grpc-gateway@9258377...aeab1d9 jmespath/go-jmespath@0b12d6b...c2b33e8 linkedin/goavro@1beee2a...af12b3c mattn/go-runewidth@ce7b0b5...3ee7d81 montanaflynn/stats@db72e6c...945b007 pkg/errors@645ef00...ba968bf prometheus/client_model@5c3871d...f287a10 prometheus/common@4724e92...2998b13 prometheus/procfs@1dc9a6c...b1a0a9a shirou/gopsutil@0f70a4a...ccc1c10 sirupsen/logrus@bcd833d...e1e72e9 stretchr/testify@f35b8ab...ffdc059 etcd-io/etcd@1900a8e...fae6e92 golang/crypto@505ab14...ff983b9 golang/net@351d144...1e06a53 golang/sync@42b3178...37e7f08 golang/sys@70b957f...48ac38b golang/tools@bcd4e47...d30e00c googleapis/google-api-go-client@9c79dee...19e022d golang/appengine@150dc57...e9657d8 Informs cockroachdb#30774. Release note: None
33628: *: update deps r=RaduBerinde a=RaduBerinde Update all deps except honnef.co/go/tools (will be updated separately) and some `github.com/cockroachdb/` deps which have been updated for go1.11. Changes: - [x] Azure/azure-storage-blob-go@5152f14...45d0c5e - [x] IBM/sarama@bbdbe64...879f631 - [x] aws/aws-sdk-go@ddc06f9...1f8a246 - [x] axiomhq/hyperloglog@e8c19f1...4b99d0c - [x] cenkalti/backoff@62661b4...1e4cf3d - [x] cockroachdb/circuitbreaker@4f5b168...3e861b2 - [x] distribution/distribution@40b7b58...91b0f05 - [x] moby/moby@a4a816b...b4842cf - [x] go-ole/go-ole@a41e3c4...39dc848 - [x] go-sql-driver/mysql@60d456a...c45f530 - [x] google/go-github@35781f7...a5cb647 - [x] google/pprof@3ea8567...e84dfd6 - [x] googleapis/gax-go@b001040...c8a15ba - [x] grpc-ecosystem/grpc-gateway@9258377...aeab1d9 - [x] jmespath/go-jmespath@0b12d6b...c2b33e8 - [x] linkedin/goavro@1beee2a...af12b3c - [x] mattn/go-runewidth@ce7b0b5...3ee7d81 - [x] montanaflynn/stats@db72e6c...945b007 - [x] pkg/errors@645ef00...ba968bf - [x] prometheus/client_model@5c3871d...f287a10 - [x] prometheus/common@4724e92...2998b13 - [x] prometheus/procfs@1dc9a6c...b1a0a9a - [x] shirou/gopsutil@0f70a4a...ccc1c10 - [x] sirupsen/logrus@bcd833d...e1e72e9 - [x] stretchr/testify@f35b8ab...ffdc059 - [x] etcd-io/etcd@1900a8e...fae6e92 (only 23731bf touches raft) - [x] golang/crypto@505ab14...ff983b9 - [x] golang/net@351d144...1e06a53 - [x] golang/sync@42b3178...37e7f08 - [x] golang/sys@70b957f...48ac38b - [x] golang/tools@bcd4e47...d30e00c - [x] googleapis/google-api-go-client@9c79dee...19e022d - [x] golang/appengine@150dc57...e9657d8 - [x] googleapis/go-genproto@a1fde74...6909d8a Informs #30774. Release note: None 33665: roachtest: fix start args in upgrade test r=petermattis a=tbg They were all supposed to be removed, but we removed them only in one instance. Fixes #33663. Release note: None Co-authored-by: Radu Berinde <[email protected]> Co-authored-by: Tobias Schottdorf <[email protected]>
We have marked this issue as stale because it has been inactive for |
We haven't updated our vendored dependencies in a while.
The text was updated successfully, but these errors were encountered: