lint: update linter libraries #34015
Conversation
This change updates `honnef.co/go/tools` and `errcheck`. We were running into problems with the new releases with go 1.10, but they work fine with go 1.11. Our lint code had to be changed to work the new release of `honnef.co/go/tools`. This change also includes some code fixes for lint issues that are detected only by the new versions. Changes: - kisielk/errcheck@55d8f50...e14f8d5 - dominikh/go-tools@d73ab98...c2f93a9 - new indirect dependency https://github.com/BurntSushi/toml Release note: None
|
This change is |
|
The CI build is behaving as if it's running go 1.10.. |
|
Never mind, it is running 1.11. Not sure what the difference is, locally all the lint tests pass in ~3 minutes. |
RaduBerinde
force-pushed
the
update-honnef-2
branch
from
95b8f71 to
2753d4f
Compare
|
Not sure what to do. We could increase the builders RAM, but I don't like making things slower and use more memory just in the name of using newer bits. Maybe I should file an issue to investigate why it's using so much more. |
|
I filed dominikh/go-tools#394. |
|
I will pull the code fixes in a separate PR, as this will probably won't merge any time soon. |
|
Closing this for now; we will stay with the old version for now given the unacceptable memory usage increase with the new version. Copied the diff into a gist for potential reuse later, just in case I accidentally nuke the branch: https://gist.github.com/RaduBerinde/3f8c7f7cc1b35bacd8791b4635d49a48 |
This change updates
honnef.co/go/toolsanderrcheck. We wererunning into problems with the new releases with go 1.10, but they
work fine with go 1.11.
Our lint code had to be changed to work the new release of
honnef.co/go/tools.This change also includes some code fixes for lint issues that are
detected only by the new versions.
Changes:
Informs #30774.
Release note: None