roachtest: fix start args in upgrade test #33665
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They were all supposed to be removed, but we removed them only in one instance. Fixes cockroachdb#33663. Release note: None
|
This change is |
complete! 1 of 0 LGTMs obtained
|
bors r=petermattis |
craig bot
pushed a commit
that referenced
this pull request
Jan 11, 2019
33628: *: update deps r=RaduBerinde a=RaduBerinde Update all deps except honnef.co/go/tools (will be updated separately) and some `github.com/cockroachdb/` deps which have been updated for go1.11. Changes: - [x] Azure/azure-storage-blob-go@5152f14...45d0c5e - [x] IBM/sarama@bbdbe64...879f631 - [x] aws/aws-sdk-go@ddc06f9...1f8a246 - [x] axiomhq/hyperloglog@e8c19f1...4b99d0c - [x] cenkalti/backoff@62661b4...1e4cf3d - [x] cockroachdb/circuitbreaker@4f5b168...3e861b2 - [x] distribution/distribution@40b7b58...91b0f05 - [x] moby/moby@a4a816b...b4842cf - [x] go-ole/go-ole@a41e3c4...39dc848 - [x] go-sql-driver/mysql@60d456a...c45f530 - [x] google/go-github@35781f7...a5cb647 - [x] google/pprof@3ea8567...e84dfd6 - [x] googleapis/gax-go@b001040...c8a15ba - [x] grpc-ecosystem/grpc-gateway@9258377...aeab1d9 - [x] jmespath/go-jmespath@0b12d6b...c2b33e8 - [x] linkedin/goavro@1beee2a...af12b3c - [x] mattn/go-runewidth@ce7b0b5...3ee7d81 - [x] montanaflynn/stats@db72e6c...945b007 - [x] pkg/errors@645ef00...ba968bf - [x] prometheus/client_model@5c3871d...f287a10 - [x] prometheus/common@4724e92...2998b13 - [x] prometheus/procfs@1dc9a6c...b1a0a9a - [x] shirou/gopsutil@0f70a4a...ccc1c10 - [x] sirupsen/logrus@bcd833d...e1e72e9 - [x] stretchr/testify@f35b8ab...ffdc059 - [x] etcd-io/etcd@1900a8e...fae6e92 (only 23731bf touches raft) - [x] golang/crypto@505ab14...ff983b9 - [x] golang/net@351d144...1e06a53 - [x] golang/sync@42b3178...37e7f08 - [x] golang/sys@70b957f...48ac38b - [x] golang/tools@bcd4e47...d30e00c - [x] googleapis/google-api-go-client@9c79dee...19e022d - [x] golang/appengine@150dc57...e9657d8 - [x] googleapis/go-genproto@a1fde74...6909d8a Informs #30774. Release note: None 33665: roachtest: fix start args in upgrade test r=petermattis a=tbg They were all supposed to be removed, but we removed them only in one instance. Fixes #33663. Release note: None Co-authored-by: Radu Berinde <[email protected]> Co-authored-by: Tobias Schottdorf <[email protected]>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They were all supposed to be removed, but we removed them only in one
instance.
Fixes #33663.
Release note: None