Update raft dep #32938
Merged
Update raft dep #32938
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
|
commit 1900a8e commit bd332b3 commit bfaae1b commit 6c649de commit 5c209d6 commit 1569f48 |
|
Fixed. |
tbg
approved these changes
Dec 7, 2018
There was a problem hiding this comment.
PS, the repo is at https://github.com/etcd-io/etcd/tree/master/raft. The vanity import path is annoying.
|
Good point, used |
|
bors r+ |
craig bot
pushed a commit
that referenced
this pull request
Dec 7, 2018
32938: Update raft dep r=RaduBerinde a=RaduBerinde go.etcd.io/etcd (024f3df -> 1900a8e) Release note: None I doin't know where I can find a web interface to show the commits. I pasted the log below. ``` commit 1900a8e Merge: 8a9a2a1 bfaae1b Author: Xiang Li <[email protected]> Date: Thu Dec 6 10:58:22 2018 -0800 Merge pull request #10308 from tbg/fix/progress-after-snap raft: enter ProgressStateReplica immediately after snapshot commit bd332b3 Author: Tobias Schottdorf <[email protected]> Date: Thu Dec 6 19:02:47 2018 +0100 raft: add (*RawNode).WithProgress Calls to Status can be frequent and currently incur three heap allocations, but often the caller has no intention to hold on to the returned status. Add StatusWithoutProgress and WithProgress to allow avoiding heap allocations altogether. StatusWithoutProgress does what's on the tin and additionally returns a value (instead of a pointer) to avoid the associated heap allocation. By not returning a Progress map, it avoids all other allocations that Status incurs. To still introspect the Progress map, add WithProgress, which uses a simple visitor pattern. Add benchmarks to verify that this is indeed allocation free. ``` BenchmarkStatusProgress/members=1/Status-8 5000000 353 ns/op 784 B/op 3 allocs/op BenchmarkStatusProgress/members=1/Status-example-8 5000000 372 ns/op 784 B/op 3 allocs/op BenchmarkStatusProgress/members=1/StatusWithoutProgress-8 100000000 17.6 ns/op 0 B/op 0 allocs/op BenchmarkStatusProgress/members=1/WithProgress-8 30000000 48.6 ns/op 0 B/op 0 allocs/op BenchmarkStatusProgress/members=1/WithProgress-example-8 30000000 42.9 ns/op 0 B/op 0 allocs/op BenchmarkStatusProgress/members=3/Status-8 5000000 395 ns/op 784 B/op 3 allocs/op BenchmarkStatusProgress/members=3/Status-example-8 3000000 449 ns/op 784 B/op 3 allocs/op BenchmarkStatusProgress/members=3/StatusWithoutProgress-8 100000000 18.7 ns/op 0 B/op 0 allocs/op BenchmarkStatusProgress/members=3/WithProgress-8 20000000 78.1 ns/op 0 B/op 0 allocs/op BenchmarkStatusProgress/members=3/WithProgress-example-8 20000000 70.7 ns/op 0 B/op 0 allocs/op BenchmarkStatusProgress/members=5/Status-8 3000000 470 ns/op 784 B/op 3 allocs/op BenchmarkStatusProgress/members=5/Status-example-8 3000000 544 ns/op 784 B/op 3 allocs/op BenchmarkStatusProgress/members=5/StatusWithoutProgress-8 100000000 19.7 ns/op 0 B/op 0 allocs/op BenchmarkStatusProgress/members=5/WithProgress-8 20000000 105 ns/op 0 B/op 0 allocs/op BenchmarkStatusProgress/members=5/WithProgress-example-8 20000000 94.0 ns/op 0 B/op 0 allocs/op BenchmarkStatusProgress/members=100/Status-8 100000 11903 ns/op 22663 B/op 12 allocs/op BenchmarkStatusProgress/members=100/Status-example-8 100000 13330 ns/op 22669 B/op 12 allocs/op BenchmarkStatusProgress/members=100/StatusWithoutProgress-8 50000000 20.9 ns/op 0 B/op 0 allocs/op BenchmarkStatusProgress/members=100/WithProgress-8 1000000 1731 ns/op 0 B/op 0 allocs/op BenchmarkStatusProgress/members=100/WithProgress-example-8 1000000 1571 ns/op 0 B/op 0 allocs/op ``` commit bfaae1b Author: Tobias Schottdorf <[email protected]> Date: Thu Dec 6 11:09:46 2018 +0100 raft: enter ProgressStateReplica immediately after snapshot When a follower requires a snapshot and the snapshot is sent at the committed (and last) index in an otherwise idle Raft group, the follower would previously remain in ProgressStateProbe even though it had been caught up completely. In a busy Raft group this wouldn't be an issue since the next round of MsgApp would update the state, but in an idle group there's nothing that rectifies the status (since there's nothing to append or update). The reason this matters is that the state is exposed through `RaftStatus()`. Concretely, in CockroachDB, we use the Raft status to make sharding decisions (since it's dangerous to make rapid changes to a fragile Raft group), and had to work around this problem[1]. [1]: https://github.com/cockroachdb/cockroach/blob/91b11dae416f3d9b55fadd2a4b096e94d874176c/pkg/storage/split_delay_helper.go#L138-L141 commit 6c649de Merge: f28945b 1569f48 Author: Xiang Li <[email protected]> Date: Sat Nov 24 11:48:16 2018 +0800 Merge pull request #10281 from tbg/print-hint-reject-app-resp raft: print RejectHint of zero on MsgAppResp commit 5c209d6 Author: Tobias Schottdorf <[email protected]> Date: Fri Nov 23 17:57:36 2018 +0100 raft: ensure leader is in ProgressStateReplicate The leader perpetually kept itself in ProgressStateProbe even though of course it has perfect knowledge of its log. This wasn't usually an issue because it also doesn't care about its own Progress, but it's better to keep this data correctly maintained, especially since this is part of raft.Status and thus becomes visible to applications using the Raft library. (Concretely, in CockroachDB we use the Progress to inform log truncations). commit 1569f48 Author: Tobias Schottdorf <[email protected]> Date: Fri Nov 23 11:06:38 2018 +0100 raft: print RejectHint of zero on MsgAppResp A zero RejectHint on MsgAppResp is still used, and so should be reflected in the message description. ``` Co-authored-by: Radu Berinde <[email protected]>
Is there something preventing us from importing it from github instead? |
Build succeeded |
|
Informs #30774. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
go.etcd.io/etcd (024f3df -> 1900a8e)
Release note: None
I doin't know where I can find a web interface to show the commits. I pasted the log below.