Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

roachtest: failover/chaos/read-only failed #107865

Closed
cockroach-teamcity opened this issue Jul 30, 2023 · 3 comments · Fixed by #108115
Closed

roachtest: failover/chaos/read-only failed #107865

cockroach-teamcity opened this issue Jul 30, 2023 · 3 comments · Fixed by #108115
Assignees
@andrewbaptist
Labels
A-testing Testing tools and infrastructure branch-release-23.1 Used to mark GA and release blockers, technical advisories, and bugs for 23.1 C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. C-test-failure Broken test (automatically or manually discovered). O-roachtest O-robot Originated from a bot. T-testeng TestEng Team X-infra-flake the automatically generated issue was closed due to an infrastructure problem not a product issue
Milestone
23.1

Comments

@cockroach-teamcity
Copy link
Member

cockroach-teamcity commented Jul 30, 2023 •
edited by cockroach-jira-scripts
Loading

roachtest.failover/chaos/read-only failed with artifacts on release-23.1 @ 8b970683af4630cbb30b4c92f0be86cfadd97993:

(cluster.go:2249).Run: output in run_124106.058283365_n1-10_echo-0-sudo-blockdev: echo "0 $(sudo blockdev --getsz /dev/sdb) linear /dev/sdb 0" | sudo dmsetup create data1 returned: COMMAND_PROBLEM: exit status 1
(cluster.go:2249).Run: cluster.RunE: context canceled
(cluster.go:2249).Run: cluster.RunE: context canceled
(cluster.go:2249).Run: cluster.RunE: context canceled
test artifacts and logs in: /artifacts/failover/chaos/read-only/run_1

Parameters: ROACHTEST_arch=amd64 , ROACHTEST_cloud=gce , ROACHTEST_cpu=2 , ROACHTEST_encrypted=false , ROACHTEST_fs=ext4 , ROACHTEST_localSSD=false , ROACHTEST_ssd=0

Help

See: roachtest README

See: How To Investigate (internal)

/cc @cockroachdb/kv-triage

This test on roachdash | Improve this report!

Jira issue: CRDB-30230
@cockroach-teamcity cockroach-teamcity added branch-release-23.1 Used to mark GA and release blockers, technical advisories, and bugs for 23.1 C-test-failure Broken test (automatically or manually discovered). O-roachtest O-robot Originated from a bot. release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked. T-kv KV Team labels Jul 30, 2023
@cockroach-teamcity cockroach-teamcity added this to the 23.1 milestone Jul 30, 2023
@erikgrinaker
Copy link
Contributor 

4: device-mapper: reload ioctl on data1  failed: Device or resource busy

This is the same issue as #107052, and also happened during initial test setup, so it seems likely to be interference from a previous test.

@pav-kv pav-kv added X-infra-flake the automatically generated issue was closed due to an infrastructure problem not a product issue C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. A-testing Testing tools and infrastructure T-testeng TestEng Team labels Aug 1, 2023
@blathers-crl
Copy link

blathers-crl bot commented Aug 1, 2023

cc @cockroachdb/test-eng

@pav-kv
Copy link
Collaborator

pav-kv commented Aug 1, 2023 •
edited
Loading

@cockroachdb/test-eng PTAL, this is the same as #107052 - there seems to be interference between consecutive test runs.
cc @srosenberg

andrewbaptist added a commit to andrewbaptist/cockroach that referenced this issue Aug 3, 2023
@andrewbaptist
roachtest: don't reuse clusters that mount/unmount
ed7f423 
Certain tests need to modify the blockdevice and they are prone to
failures during setup that the device is still busy. Ideally we would
figure out what is still holding onto the dish handle, but it is safer
to simply not reuse clusters that perform this by adding
`spec.ReuseNone()`

Fixes: cockroachdb#107865
Epic: none

Release note: None
@andrewbaptist andrewbaptist mentioned this issue Aug 3, 2023
Merged
@andrewbaptist andrewbaptist self-assigned this Aug 3, 2023
@nvanbenschoten nvanbenschoten removed release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked. T-kv KV Team labels Aug 3, 2023
craig bot pushed a commit that referenced this issue Aug 4, 2023
@andrewbaptist @koorosh @jaylim-crl
Merge #108115 #108165 #108192
cbf623e 
108115: roachtest: don't reuse clusters that call dmsetup r=erikgrinaker,srosenberg a=andrewbaptist

Certain tests need to modify the blockdevice and they are prone to failures during setup that the device is still busy. Ideally we would figure out what is still holding onto the dish handle, but it is safer to simply not reuse clusters that perform this by adding `spec.ReuseNone()`

Fixes: #107865
Epic: none

Release note: None

108165: sql: fix insight integration test for contention r=koorosh a=koorosh

This change lowers the latency threshold for which statement is considered slow to make sure it detects contention.
Previous value was set to 100ms which is default. New value is set to 30ms to be the same as overridden
value in other tests.

Release note: None

Resolves: #108020

108192: ccl/sqlproxyccl: deflake TestConnectionMigration r=darinpp a=jaylim-crl

Fixes #106885.

This test flake seems extremely rare, and it's unclear why it occurred in the
first place. The past 1000 runs (all of what TC has) have been successful.
Regardless, this commit attempts at deflaking TestConnectionMigration. Given
that some subtests transfer connections through `transferConnWithRetries`, it
is possible that the transfer was retried, causing the metric to be
incremented.

Release note: None

Epic: none

Co-authored-by: Andrew Baptist <[email protected]>
Co-authored-by: Andrii Vorobiov <[email protected]>
Co-authored-by: Jay <[email protected]>
craig bot pushed a commit that referenced this issue Aug 7, 2023
@andrewbaptist
Merge #108115
3e7991d 
108115: roachtest: don't reuse clusters that call dmsetup r=erikgrinaker,srosenberg a=andrewbaptist

Certain tests need to modify the blockdevice and they are prone to failures during setup that the device is still busy. Ideally we would figure out what is still holding onto the dish handle, but it is safer to simply not reuse clusters that perform this by adding `spec.ReuseNone()`

Fixes: #107865
Epic: none

Release note: None

Co-authored-by: Andrew Baptist <[email protected]>
@craig craig bot closed this as completed in 704e6e9 Aug 7, 2023
@erikgrinaker erikgrinaker mentioned this issue Aug 7, 2023
Merged
erikgrinaker pushed a commit to erikgrinaker/cockroach that referenced this issue Aug 7, 2023
@andrewbaptist @erikgrinaker
roachtest: don't reuse clusters that call dmsetup
543a79e 
Certain tests need to modify the blockdevice and they are prone to
failures during setup that the device is still busy. Ideally we would
figure out what is still holding onto the dish handle, but it is safer
to simply not reuse clusters that perform this by adding
`spec.ReuseNone()`

Fixes: cockroachdb#107865
Epic: none

Release note: None
erikgrinaker pushed a commit to erikgrinaker/cockroach that referenced this issue Aug 8, 2023
@andrewbaptist @erikgrinaker
roachtest: don't reuse clusters that call dmsetup
099bd82 
Certain tests need to modify the blockdevice and they are prone to
failures during setup that the device is still busy. Ideally we would
figure out what is still holding onto the dish handle, but it is safer
to simply not reuse clusters that perform this by adding
`spec.ReuseNone()`

Fixes: cockroachdb#107865
Epic: none

Release note: None
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andrewbaptist andrewbaptist

Labels
A-testing Testing tools and infrastructure branch-release-23.1 Used to mark GA and release blockers, technical advisories, and bugs for 23.1 C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. C-test-failure Broken test (automatically or manually discovered). O-roachtest O-robot Originated from a bot. T-testeng TestEng Team X-infra-flake the automatically generated issue was closed due to an infrastructure problem not a product issue
Projects
None yet
Milestone
23.1
Development

Successfully merging a pull request may close this issue.

roachtest: don't reuse clusters that call dmsetup andrewbaptist/cockroach
5 participants
@erikgrinaker @pav-kv @nvanbenschoten @cockroach-teamcity @andrewbaptist