Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ccl/sqlproxyccl: TestConnectionMigration failed #106885

Closed
cockroach-teamcity opened this issue Jul 16, 2023 · 0 comments · Fixed by #108192
Closed

ccl/sqlproxyccl: TestConnectionMigration failed #106885

cockroach-teamcity opened this issue Jul 16, 2023 · 0 comments · Fixed by #108192
Assignees
@jaylim-crl
Labels
branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot. T-serverless
Milestone
23.2

Comments

@cockroach-teamcity
Copy link
Member

cockroach-teamcity commented Jul 16, 2023 •
edited by cockroach-jira-scripts
Loading

ccl/sqlproxyccl.TestConnectionMigration failed with artifacts on master @ c609b823b0a1fda5b7d605e4645cd452a6009961:

=== RUN   TestConnectionMigration
    test_log_scope.go:167: test logs captured to: /artifacts/tmp/_tmp/a455c59caed0cf9d0a0298ad88bfe7a2/logTestConnectionMigration603786213
    test_log_scope.go:81: use -show-logs to present logs inline
=== CONT  TestConnectionMigration
    proxy_handler_test.go:2303: -- test log scope end --
test logs left over in: /artifacts/tmp/_tmp/a455c59caed0cf9d0a0298ad88bfe7a2/logTestConnectionMigration603786213
--- FAIL: TestConnectionMigration (24.68s)
=== RUN   TestConnectionMigration/successful
    --- FAIL: TestConnectionMigration/successful (9.44s)
=== RUN   TestConnectionMigration/successful/failed_transfers_with_tx
    proxy_handler_test.go:2149: 
        	Error Trace:	github.com/cockroachdb/cockroach/pkg/ccl/sqlproxyccl/proxy_handler_test.go:2149
        	Error:      	Not equal: 
        	            	expected: 5
        	            	actual  : 6
        	Test:       	TestConnectionMigration/successful/failed_transfers_with_tx
        --- FAIL: TestConnectionMigration/successful/failed_transfers_with_tx (0.04s)
=== RUN   TestConnectionMigration/successful/normal_transfer
    proxy_handler_test.go:2105: 
        	Error Trace:	github.com/cockroachdb/cockroach/pkg/ccl/sqlproxyccl/proxy_handler_test.go:2105
        	Error:      	Not equal: 
        	            	expected: 0
        	            	actual  : 1
        	Test:       	TestConnectionMigration/successful/normal_transfer
        --- FAIL: TestConnectionMigration/successful/normal_transfer (6.26s)
Help

See also: How To Investigate a Go Test Failure (internal)

/cc @cockroachdb/sql-foundations @cockroachdb/server

This test on roachdash | Improve this report!

Jira issue: CRDB-29752
@cockroach-teamcity cockroach-teamcity added branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot. T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions) labels Jul 16, 2023
@cockroach-teamcity cockroach-teamcity added this to the 23.2 milestone Jul 16, 2023
@rafiss rafiss added T-serverless and removed T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions) labels Jul 17, 2023
@jaylim-crl jaylim-crl self-assigned this Aug 4, 2023
@jaylim-crl jaylim-crl mentioned this issue Aug 4, 2023
Merged
craig bot pushed a commit that referenced this issue Aug 4, 2023
@andrewbaptist @koorosh @jaylim-crl
Merge #108115 #108165 #108192
cbf623e 
108115: roachtest: don't reuse clusters that call dmsetup r=erikgrinaker,srosenberg a=andrewbaptist

Certain tests need to modify the blockdevice and they are prone to failures during setup that the device is still busy. Ideally we would figure out what is still holding onto the dish handle, but it is safer to simply not reuse clusters that perform this by adding `spec.ReuseNone()`

Fixes: #107865
Epic: none

Release note: None

108165: sql: fix insight integration test for contention r=koorosh a=koorosh

This change lowers the latency threshold for which statement is considered slow to make sure it detects contention.
Previous value was set to 100ms which is default. New value is set to 30ms to be the same as overridden
value in other tests.

Release note: None

Resolves: #108020

108192: ccl/sqlproxyccl: deflake TestConnectionMigration r=darinpp a=jaylim-crl

Fixes #106885.

This test flake seems extremely rare, and it's unclear why it occurred in the
first place. The past 1000 runs (all of what TC has) have been successful.
Regardless, this commit attempts at deflaking TestConnectionMigration. Given
that some subtests transfer connections through `transferConnWithRetries`, it
is possible that the transfer was retried, causing the metric to be
incremented.

Release note: None

Epic: none

Co-authored-by: Andrew Baptist <[email protected]>
Co-authored-by: Andrii Vorobiov <[email protected]>
Co-authored-by: Jay <[email protected]>
craig bot pushed a commit that referenced this issue Aug 4, 2023
@adityamaru @jaylim-crl
Merge #108029 #108192
a1c86ea 
108029: upgrademanager: unskip TestMigrationFailure r=msbutler a=adityamaru

The test no longer fails with our change in #107570.

Fixes: #106648
Fixes: #106762
Release note: None

108192: ccl/sqlproxyccl: deflake TestConnectionMigration r=darinpp a=jaylim-crl

Fixes #106885.

This test flake seems extremely rare, and it's unclear why it occurred in the
first place. The past 1000 runs (all of what TC has) have been successful.
Regardless, this commit attempts at deflaking TestConnectionMigration. Given
that some subtests transfer connections through `transferConnWithRetries`, it
is possible that the transfer was retried, causing the metric to be
incremented.

Release note: None

Epic: none

Co-authored-by: adityamaru <[email protected]>
Co-authored-by: Jay <[email protected]>
@craig craig bot closed this as completed in ee9ea9a Aug 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jaylim-crl jaylim-crl

Labels
branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot. T-serverless
Projects
None yet
Milestone
23.2
Development

Successfully merging a pull request may close this issue.

ccl/sqlproxyccl: deflake TestConnectionMigration jaylim-crl/cockroach
3 participants
@rafiss @cockroach-teamcity @jaylim-crl