Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pkg/sql/sqlstats/insights/integration/integration_test: TestInsightsIntegrationForContention failed #108020

Closed
cockroach-teamcity opened this issue Aug 2, 2023 · 0 comments · Fixed by #108165
Closed

pkg/sql/sqlstats/insights/integration/integration_test: TestInsightsIntegrationForContention failed #108020

cockroach-teamcity opened this issue Aug 2, 2023 · 0 comments · Fixed by #108165
Assignees
@j82w
Labels
branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot.
Milestone
23.2

Comments

@cockroach-teamcity
Copy link
Member

cockroach-teamcity commented Aug 2, 2023 •
edited by cockroach-jira-scripts
Loading

pkg/sql/sqlstats/insights/integration/integration_test.TestInsightsIntegrationForContention failed with artifacts on master @ 54a3a3876b108884301e5be26baef05b407959af:

=== RUN   TestInsightsIntegrationForContention
    test_log_scope.go:167: test logs captured to: /artifacts/tmp/_tmp/8db7e2fbdb77cb910d7e66552998132e/logTestInsightsIntegrationForContention3404264044
    test_log_scope.go:81: use -show-logs to present logs inline
    test_server_shim.go:98: 
        Test server was configured to route SQL queries to a secondary tenant (virtual cluster).
        If you are only seeing a test failure when this message appears, there may be a problem
        specific to cluster virtualization or multi-tenancy.
        
        To investigate, consider using "COCKROACH_TEST_TENANT=true" to force-enable just
        the secondary tenant in all runs (or, alternatively, "false" to force-disable), or use
        "COCKROACH_INTERNAL_DISABLE_METAMORPHIC_TESTING=false" to disable all random test variables altogether.
*
* WARNING: test tenant requested by configuration, but code organization prevents start!
* OSS binaries do not include enterprise features
*
    insights_test.go:566: condition failed to evaluate within 5s: node_execution_insights did not return any rows
    panic.go:522: -- test log scope end --
test logs left over in: /artifacts/tmp/_tmp/8db7e2fbdb77cb910d7e66552998132e/logTestInsightsIntegrationForContention3404264044
--- FAIL: TestInsightsIntegrationForContention (8.30s)
Help

See also: How To Investigate a Go Test Failure (internal)

Same failure on other branches

/cc @cockroachdb/cluster-observability

This test on roachdash | Improve this report!

Jira issue: CRDB-30292
@cockroach-teamcity cockroach-teamcity added branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot. T-cluster-observability labels Aug 2, 2023
@cockroach-teamcity cockroach-teamcity added this to the 23.2 milestone Aug 2, 2023
@j82w j82w self-assigned this Aug 2, 2023
@j82w j82w mentioned this issue Aug 4, 2023
Closed
@koorosh koorosh mentioned this issue Aug 4, 2023
Merged
craig bot pushed a commit that referenced this issue Aug 4, 2023
@andrewbaptist @koorosh @jaylim-crl
Merge #108115 #108165 #108192
cbf623e 
108115: roachtest: don't reuse clusters that call dmsetup r=erikgrinaker,srosenberg a=andrewbaptist

Certain tests need to modify the blockdevice and they are prone to failures during setup that the device is still busy. Ideally we would figure out what is still holding onto the dish handle, but it is safer to simply not reuse clusters that perform this by adding `spec.ReuseNone()`

Fixes: #107865
Epic: none

Release note: None

108165: sql: fix insight integration test for contention r=koorosh a=koorosh

This change lowers the latency threshold for which statement is considered slow to make sure it detects contention.
Previous value was set to 100ms which is default. New value is set to 30ms to be the same as overridden
value in other tests.

Release note: None

Resolves: #108020

108192: ccl/sqlproxyccl: deflake TestConnectionMigration r=darinpp a=jaylim-crl

Fixes #106885.

This test flake seems extremely rare, and it's unclear why it occurred in the
first place. The past 1000 runs (all of what TC has) have been successful.
Regardless, this commit attempts at deflaking TestConnectionMigration. Given
that some subtests transfer connections through `transferConnWithRetries`, it
is possible that the transfer was retried, causing the metric to be
incremented.

Release note: None

Epic: none

Co-authored-by: Andrew Baptist <[email protected]>
Co-authored-by: Andrii Vorobiov <[email protected]>
Co-authored-by: Jay <[email protected]>
@craig craig bot closed this as completed in 5cfe9fe Aug 5, 2023
@blathers-crl blathers-crl bot mentioned this issue Aug 5, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@j82w j82w

Labels
branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot.
Projects
None yet
Milestone
23.2
Development

Successfully merging a pull request may close this issue.

sql: fix insight integration test for contention koorosh/cockroach
2 participants
@j82w @cockroach-teamcity