Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-23.1: roachtest: don't reuse clusters that call dmsetup #108274

Merged

Conversation

erikgrinaker
Copy link
Contributor

Backport 1/1 commits from #108115.

/cc @cockroachdb/release


Certain tests need to modify the blockdevice and they are prone to failures during setup that the device is still busy. Ideally we would figure out what is still holding onto the dish handle, but it is safer to simply not reuse clusters that perform this by adding spec.ReuseNone()

Fixes: #107865
Epic: none

Release note: None

@erikgrinaker erikgrinaker requested a review from a team as a code owner August 7, 2023 11:19
@erikgrinaker erikgrinaker self-assigned this Aug 7, 2023
@erikgrinaker erikgrinaker requested review from herkolategan and renatolabs and removed request for a team August 7, 2023 11:19
@blathers-crl
Copy link

blathers-crl bot commented Aug 7, 2023

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Collaborator

@andrewbaptist andrewbaptist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Certain tests need to modify the blockdevice and they are prone to
failures during setup that the device is still busy. Ideally we would
figure out what is still holding onto the dish handle, but it is safer
to simply not reuse clusters that perform this by adding
`spec.ReuseNone()`

Fixes: cockroachdb#107865
Epic: none

Release note: None
@erikgrinaker erikgrinaker merged commit fe57847 into cockroachdb:release-23.1 Aug 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants