Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

schemachanger: Support CREATE DATABASE #103324

Closed
Xiang-Gu opened this issue May 15, 2023 · 1 comment · Fixed by #103607 or #117292
Closed

schemachanger: Support CREATE DATABASE #103324

Xiang-Gu opened this issue May 15, 2023 · 1 comment · Fixed by #103607 or #117292
Assignees
@Xiang-Gu
Labels
C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions)

Comments

@Xiang-Gu
Copy link
Contributor

Xiang-Gu commented May 15, 2023 •
edited by exalate-issue-sync bot
Loading

We should support CREATE DATABASE as much as we can in the declarative schema changer.

Jira issue: CRDB-27948

Epic CRDB-25313
@Xiang-Gu Xiang-Gu added the C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. label May 15, 2023
@Xiang-Gu Xiang-Gu self-assigned this May 15, 2023
@blathers-crl blathers-crl bot added the T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions) label May 15, 2023
@exalate-issue-sync exalate-issue-sync bot removed the T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions) label May 15, 2023
@Xiang-Gu Xiang-Gu mentioned this issue May 18, 2023
Merged
@exalate-issue-sync exalate-issue-sync bot added the T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions) label May 22, 2023
@rafiss rafiss mentioned this issue Nov 30, 2023
Closed
@craig craig bot closed this as completed in 61ada72 Dec 19, 2023
@rafiss
Copy link
Collaborator

rafiss commented Dec 20, 2023

re-opening since the PR is being reverted due to these flakes:

@rafiss rafiss reopened this Dec 20, 2023
@rafiss rafiss mentioned this issue Dec 20, 2023
Merged
craig bot pushed a commit that referenced this issue Dec 20, 2023
@dt @fqazi
Merge #116874 #116879
7a7bbff 
116874: scripts/bump-pebble: markdown format commit list links r=dt a=dt

Release note: none.
Epic: none.

116879: Revert "schemachanger: Implement CREATE DATABASE" r=fqazi a=fqazi

fixes #116840
fixes #116837
fixes #116829

informs #103324
This reverts commit 77372a6.

Co-authored-by: David Taylor <[email protected]>
Co-authored-by: Faizan Qazi <[email protected]>
@Xiang-Gu Xiang-Gu mentioned this issue Jan 3, 2024
Merged
craig bot pushed a commit that referenced this issue Jan 4, 2024
@Xiang-Gu
Merge #117292
e4067f1 
117292: schemachanger: Implement CREATE DATABASE in declarative schema changer r=Xiang-Gu a=Xiang-Gu

This PR implements CREATE DATABASE in declarative schema changer.
It falls back to legacy schema changer if the database is requested to be
multi-region.

Epic: [CRDB-25312](https://cockroachlabs.atlassian.net/browse/CRDB-25312)
Fix: #103324
Inform: #103607
Release note: None

Co-authored-by: Xiang Gu <[email protected]>
@craig craig bot closed this as completed in #117292 Jan 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Xiang-Gu Xiang-Gu

Labels
C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions)
Projects
No open projects
SQL Foundations
Archived in project
Milestone
No milestone
2 participants
@rafiss @Xiang-Gu