schemachanger: Implement CREATE DATABASE in declarative schema changer #117292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, we used a `map` to store all descriptors we want to create within one stage, and just iterate over that map to actually call functions to add them. The iteration ordering is non-deterministic so it can cause flakes in end-to-end test where we assert a particular order of desc upsertion. This commit fixes it by ensuring we always create descs in the ascending order of their ID. Release note: None
This commit supports CREATE DATABASE in declarative schema changer. It falls back to legacy schema changer if the database is requested to be multi-region. Release note: None
![blathers[crl]](https://avatars.githubusercontent.com/in/59700?s=40&u=373d9101a12edc3847d2fb6ae78e3adcfb4ca41e&v=4){kind=avatar}
|
Your pull request contains more than 1000 changes. It is strongly encouraged to split big PRs into smaller chunks. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
|
This change is |
Xiang-Gu
requested review from
herkolategan and
renatolabs
and removed request for
a team
|
TFTR! bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements CREATE DATABASE in declarative schema changer.
It falls back to legacy schema changer if the database is requested to be
multi-region.
Epic: CRDB-25312
Fix: #103324
Inform: #103607
Release note: None