Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scripts/bump-pebble: markdown format commit list links #116874

Merged
merged 3 commits into from
Dec 20, 2023

Conversation

dt
Copy link
Member

@dt dt commented Dec 20, 2023

Release note: none.
Epic: none.

@dt dt requested a review from RaduBerinde December 20, 2023 18:09
@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Member

@RaduBerinde RaduBerinde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @dt)


scripts/bump-pebble.sh line 5 at r1 (raw file):

# NOTE: After a new release has been cut, update this to the appropriate
# Cockroach branch name (i.e. release-23.2, etc.), and corresponding Pebble
# branch name (e.g. crl-release-23.2, etc.).

This comment should stay.

Copy link
Member Author

@dt dt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @RaduBerinde)


scripts/bump-pebble.sh line 5 at r1 (raw file):

Previously, RaduBerinde wrote…

This comment should stay.

huh, I have no idea how this removal got in here.

Copy link
Member

@RaduBerinde RaduBerinde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @dt)


scripts/bump-pebble.sh line 5 at r1 (raw file):

Previously, dt (David Taylor) wrote…

huh, I have no idea how this removal got in here.

It was recently added, maybe some snafu during rebase

dt added 3 commits December 20, 2023 18:19

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Release note: none.
Epic: none.
Release note: none.
Epic: none.
Release note: none.
Epic: none.
Copy link
Member

@RaduBerinde RaduBerinde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r6, all commit messages.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @dt)

@dt
Copy link
Member Author

dt commented Dec 20, 2023

TFTR!

bors r+

@craig
Copy link
Contributor

craig bot commented Dec 20, 2023

Build succeeded:

@craig craig bot merged commit 7a7bbff into cockroachdb:master Dec 20, 2023
8 of 9 checks passed
@dt dt deleted the bump-pebble branch December 20, 2023 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants