Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "schemachanger: Implement CREATE DATABASE" #116879

Merged
merged 1 commit into from
Dec 20, 2023
Merged

Revert "schemachanger: Implement CREATE DATABASE" #116879

merged 1 commit into from
Dec 20, 2023

Conversation

fqazi
Copy link
Collaborator

@fqazi fqazi commented Dec 20, 2023 •
edited by rafiss
Loading

fixes #116840
fixes #116837
fixes #116829

informs #103324
This reverts commit 77372a6.

@fqazi fqazi requested review from a team as code owners December 20, 2023 19:10
@fqazi fqazi requested review from herkolategan and DarrylWong and removed request for a team December 20, 2023 19:10
@blathers-crl blathers[crl]
Copy link

blathers-crl bot commented Dec 20, 2023

Your pull request contains more than 1000 changes. It is strongly encouraged to split big PRs into smaller chunks.

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@fqazi
Copy link
Collaborator Author

fqazi commented Dec 20, 2023

Only unrelated flakes here.

bors r+

@craig
Copy link
Contributor

craig bot commented Dec 20, 2023

Build succeeded:

@craig craig bot merged commit 7a7bbff into cockroachdb:master Dec 20, 2023
6 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rafiss rafiss rafiss approved these changes

@herkolategan herkolategan Awaiting requested review from herkolategan herkolategan is a code owner automatically assigned from cockroachdb/test-eng

@DarrylWong DarrylWong Awaiting requested review from DarrylWong DarrylWong is a code owner automatically assigned from cockroachdb/test-eng

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@fqazi @cockroach-teamcity @rafiss