Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable i18n with ja(Japanese) for website #521

Merged
merged 18 commits into from
Jan 9, 2024
Merged

Conversation

hhiroshell
Copy link
Contributor

@hhiroshell hhiroshell commented Dec 19, 2023

This PR makes Japanese available in the language selection menu. It also localizes the top page and the titles of each page into Japanese for the Japanese site.
For content that has not been translated, I have copied the English content as is, following the discussion in #492.

  • Enable i18n by update website/config.toml and website/i18n/ja.toml
  • Copy all contents to content/ja
  • Translate some key pages (e.g. content/ja/_index.md)
  • Local test done
  • Reviews by Japanese speakers

To Japanese Reviewers:
Please see the link below to review parts translated into Japanese.

Thank you for the pioneering work in Chinese and Korean translations.

Copy link

netlify bot commented Dec 19, 2023

Deploy Preview for tag-app-delivery ready!

Name Link
🔨 Latest commit 3676c15
🔍 Latest deploy log https://app.netlify.com/sites/tag-app-delivery/deploys/6597f1c7ef91f000089bd2fd
😎 Deploy Preview https://deploy-preview-521--tag-app-delivery.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@joshgav joshgav added the website Related to TAG website. label Dec 19, 2023
</div>
<div class="col-lg-6">
<div class="lead">
TAG App Deliveryは、構築、実行、管理、運用を含む、クラウドネイティブアプリケーションのデリバリーに関連するプロジェクトや取り組みの支援を行います。
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Projects and initiatives related to delivering cloud-native applications, including building, packaging, deploying, managing, and operating them.

原文だとpackagingも列挙していますが、入ってないのは意図的でしょうか。
(config.tomlのdescriptionだと原文もpackagingが列挙されてないので、それに合わせているのであれば問題ないと思います。)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

レビューありがとうございます。

config.tomlの訳文をそのまま持ってきたためにもれてしまいました。原文を尊重して「パッケージング」を追加しようと思います。

Copy link
Contributor Author

@hhiroshell hhiroshell Dec 25, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

修正しました 3c0a8f5

Copy link

@MasayaAoyama MasayaAoyama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

サイドバーの順番が変わってるので、weightなどを指定して英語版と順番を合わせておきたい気がしました。
image


このTAGは、チャーターに関連するプロジェクトを支援しています。これには、[アプリケーションの定義とイメージのビルド](https://landscape.cncf.io/card-mode?category=application-definition-image-build&project=hosted)、[継続的インテグレーションとデリバリー](https://landscape.cncf.io/card-mode?category=continuous-integration-delivery&project=hosted)、[コンテナレジストリ](https://landscape.cncf.io/card-mode?category=container-registry&project=hosted)の領域における[CNCFランドスケープ](https://landscape.cncf.io/card-mode)内のプロジェクトが含まれます。

現在2つのワーキンググループ(WG)が活動しています。[プラットフォームWG](./wgs/platforms/)と[アーティファクトWG](./wgs/artifacts/)です。

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TAG App Delivery などは英字のままなので、プラットフォームWGなども Platform WG などのままの方がわかりやすい気がします。

Copy link
Contributor Author

@hhiroshell hhiroshell Dec 25, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

少し考えてみたのですが、原文では「Platforms Working Group」となっているところに、日本語を「Platform WG」にすると違和感ありそうです(なぜか日本語だとWGと略語になる)。一方で原文に完全にそろえてしまうと、英文そのまま感がでてしまいます。

考え方を変えて、「CNCF TAG App Delivery」の方を「CNCF TAG Appデリバリー」とするのはどう思いますか?中韓はそのような対応をしていました。

  • 中: CNCF 应用交付 TAG
  • 韓: CNCF 앱 딜리버리 TAG

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

中韓がそのようにしているなら、その方向に合わせるのが良さそうですね

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

修正しました。c649407

title: "CNCFプラットフォームホワイトペーパー"
pdf: https://github.com/cncf/tag-app-delivery/raw/main/platforms-whitepaper/v1/assets/platforms-def-v1.0.pdf
version_info: https://github.com/cncf/tag-app-delivery/tree/main/platforms-whitepaper/README.md
description: "This paper intends to support enterprise leaders, enterprise architects and platform team leaders to advocate for, investigate and plan internal platforms for cloud computing. We believe platforms significantly impact enterprises' actual value streams, but only indirectly, so leadership consensus and support is vital to the long-term sustainability and success of platform teams. In this paper we'll enable that support by discussing what the value of platforms is, how to measure it, and how to implement platform teams that maximize it."
Copy link

@MasayaAoyama MasayaAoyama Dec 24, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://deploy-preview-521--tag-app-delivery.netlify.app/ja/wgs/platforms/ あたりが中途半端に略されている状態なので、各descriptionも翻訳しちゃっても良いかもですね。
ただ、各index.mdを翻訳するタイミングでも良い気もします。

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

descriptionも一通り翻訳しました。9d6d547

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm : )


このTAGは、チャーターに関連するプロジェクトを支援しています。これには、[アプリケーションの定義とイメージのビルド](https://landscape.cncf.io/card-mode?category=application-definition-image-build&project=hosted)、[継続的インテグレーションとデリバリー](https://landscape.cncf.io/card-mode?category=continuous-integration-delivery&project=hosted)、[コンテナレジストリ](https://landscape.cncf.io/card-mode?category=container-registry&project=hosted)の領域における[CNCFランドスケープ](https://landscape.cncf.io/card-mode)内のプロジェクトが含まれます。

現在2つのワーキンググループ(WG)が活動しています。[プラットフォームWG](./wgs/platforms/)と[アーティファクトWG](./wgs/artifacts/)です。

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

そしてこれは本家も治すべき話ですが、Operator WG も含めておいた方が良さそうですかね。

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Operator Working Groupの説明に「currently inactive」とあるので、このままにしておこうと思いますー。
https://tag-app-delivery.cncf.io/wgs/operator/

@hhiroshell
Copy link
Contributor Author

hhiroshell commented Dec 25, 2023

@MasayaAoyama

weightなどを指定して英語版と順番を合わせておきたい気がしました。

ご指摘のとおりだと思いますが、中韓もまとめてweightつけたいので別PRにしようと思います。

翻訳ではないですが、ちょうど日中韓またいで修正したい箇所(主に英語コンテンツでの最新の修正への追従)があるので、その時に合わせて実施しようかと。

Comment on lines 71 to 72
title = "CNCF TAG App Delivery"
description = "TAG App Deliveryは、構築、実行、管理、運用を含む、クラウドネイティブアプリケーションのデリバリーに関連するプロジェクトや取り組みの支援を行います。"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

こちらも「CNCF TAG Appデリバリー」ですね。

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ご指摘ありがとうございます。見落としていました。

Copy link
Contributor

@naonishijima naonishijima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joshgav
Copy link
Contributor

joshgav commented Jan 8, 2024

Thank you all for the work here! I'm working on reviewing now.

Copy link
Contributor

@joshgav joshgav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rubber stamp LGTM from me, thank you @hhiroshell for the work and @kaitoii11, @MasayaAoyama and @naonishijima for the reviews!

@joshgav joshgav merged commit 1dd3c19 into cncf:main Jan 9, 2024
5 checks passed
abangser pushed a commit to abangser/tag-app-delivery that referenced this pull request Jan 11, 2024
* add Japanese contents
* copy the English contents to the Japanese directory
* translate website/config.toml and website/i18n/ja.toml
* Introduce taxonomy for blog pages under content/ja.
c.f. cncf#518
* translate the titles of each page and the descriptions of second-level pages
* translate the top page of the website
* translate "Initiative " to 「取り組み」
* add contributions pages to the jp contents
c.f. cncf#519
* Copy new en blog contents to content/ja/
c.f. cncf#523
* correct the omission in the translation of 'packaging'.
* translate "TAG App Delivery" to 「TAG Appデリバリー」
* translate "TAG App Delivery" to 「TAG Appデリバリー」
* remove the "url" property to prevent overwriting the default language with the translated version.
* translate descriptions of each page to jp.
* fix for slack channel name
c.f. hhiroshell@f3a4854
---------

Signed-off-by: Hiroshi Hayakawa <[email protected]>
sysnet4admin pushed a commit to sysnet4admin/tag-app-delivery that referenced this pull request Feb 24, 2024
* add Japanese contents
* copy the English contents to the Japanese directory
* translate website/config.toml and website/i18n/ja.toml
* Introduce taxonomy for blog pages under content/ja.
c.f. cncf#518
* translate the titles of each page and the descriptions of second-level pages
* translate the top page of the website
* translate "Initiative " to 「取り組み」
* add contributions pages to the jp contents
c.f. cncf#519
* Copy new en blog contents to content/ja/
c.f. cncf#523
* correct the omission in the translation of 'packaging'.
* translate "TAG App Delivery" to 「TAG Appデリバリー」
* translate "TAG App Delivery" to 「TAG Appデリバリー」
* remove the "url" property to prevent overwriting the default language with the translated version.
* translate descriptions of each page to jp.
* fix for slack channel name
c.f. hhiroshell@f3a4854
---------

Signed-off-by: Hiroshi Hayakawa <[email protected]>
Signed-off-by: Hoon Jo <[email protected]>
@hhiroshell hhiroshell deleted the i18n-jp branch March 20, 2024 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
translation website Related to TAG website.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants