-
Notifications
You must be signed in to change notification settings - Fork 205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable i18n with ja(Japanese) for website #521
Conversation
✅ Deploy Preview for tag-app-delivery ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Signed-off-by: Hiroshi Hayakawa <[email protected]>
Signed-off-by: Hiroshi Hayakawa <[email protected]>
Signed-off-by: Hiroshi Hayakawa <[email protected]>
c.f. cncf#518 Signed-off-by: Hiroshi Hayakawa <[email protected]>
…l pages Signed-off-by: Hiroshi Hayakawa <[email protected]>
Signed-off-by: Hiroshi Hayakawa <[email protected]>
Signed-off-by: Hiroshi Hayakawa <[email protected]>
c.f. cncf#519 Signed-off-by: Hiroshi Hayakawa <[email protected]>
It contains the diffs from cncf@369970d
c.f. cncf#523 Signed-off-by: Hiroshi Hayakawa <[email protected]>
website/content/ja/_index.md
Outdated
</div> | ||
<div class="col-lg-6"> | ||
<div class="lead"> | ||
TAG App Deliveryは、構築、実行、管理、運用を含む、クラウドネイティブアプリケーションのデリバリーに関連するプロジェクトや取り組みの支援を行います。 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Projects and initiatives related to delivering cloud-native applications, including building, packaging, deploying, managing, and operating them.
原文だとpackagingも列挙していますが、入ってないのは意図的でしょうか。
(config.tomlのdescriptionだと原文もpackagingが列挙されてないので、それに合わせているのであれば問題ないと思います。)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
レビューありがとうございます。
config.tomlの訳文をそのまま持ってきたためにもれてしまいました。原文を尊重して「パッケージング」を追加しようと思います。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
修正しました 3c0a8f5
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
||
このTAGは、チャーターに関連するプロジェクトを支援しています。これには、[アプリケーションの定義とイメージのビルド](https://landscape.cncf.io/card-mode?category=application-definition-image-build&project=hosted)、[継続的インテグレーションとデリバリー](https://landscape.cncf.io/card-mode?category=continuous-integration-delivery&project=hosted)、[コンテナレジストリ](https://landscape.cncf.io/card-mode?category=container-registry&project=hosted)の領域における[CNCFランドスケープ](https://landscape.cncf.io/card-mode)内のプロジェクトが含まれます。 | ||
|
||
現在2つのワーキンググループ(WG)が活動しています。[プラットフォームWG](./wgs/platforms/)と[アーティファクトWG](./wgs/artifacts/)です。 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TAG App Delivery などは英字のままなので、プラットフォームWGなども Platform WG などのままの方がわかりやすい気がします。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
少し考えてみたのですが、原文では「Platforms Working Group」となっているところに、日本語を「Platform WG」にすると違和感ありそうです(なぜか日本語だとWGと略語になる)。一方で原文に完全にそろえてしまうと、英文そのまま感がでてしまいます。
考え方を変えて、「CNCF TAG App Delivery」の方を「CNCF TAG Appデリバリー」とするのはどう思いますか?中韓はそのような対応をしていました。
- 中: CNCF 应用交付 TAG
- 韓: CNCF 앱 딜리버리 TAG
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
中韓がそのようにしているなら、その方向に合わせるのが良さそうですね
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
修正しました。c649407
title: "CNCFプラットフォームホワイトペーパー" | ||
pdf: https://github.com/cncf/tag-app-delivery/raw/main/platforms-whitepaper/v1/assets/platforms-def-v1.0.pdf | ||
version_info: https://github.com/cncf/tag-app-delivery/tree/main/platforms-whitepaper/README.md | ||
description: "This paper intends to support enterprise leaders, enterprise architects and platform team leaders to advocate for, investigate and plan internal platforms for cloud computing. We believe platforms significantly impact enterprises' actual value streams, but only indirectly, so leadership consensus and support is vital to the long-term sustainability and success of platform teams. In this paper we'll enable that support by discussing what the value of platforms is, how to measure it, and how to implement platform teams that maximize it." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://deploy-preview-521--tag-app-delivery.netlify.app/ja/wgs/platforms/ あたりが中途半端に略されている状態なので、各descriptionも翻訳しちゃっても良いかもですね。
ただ、各index.mdを翻訳するタイミングでも良い気もします。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
descriptionも一通り翻訳しました。9d6d547
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm : )
|
||
このTAGは、チャーターに関連するプロジェクトを支援しています。これには、[アプリケーションの定義とイメージのビルド](https://landscape.cncf.io/card-mode?category=application-definition-image-build&project=hosted)、[継続的インテグレーションとデリバリー](https://landscape.cncf.io/card-mode?category=continuous-integration-delivery&project=hosted)、[コンテナレジストリ](https://landscape.cncf.io/card-mode?category=container-registry&project=hosted)の領域における[CNCFランドスケープ](https://landscape.cncf.io/card-mode)内のプロジェクトが含まれます。 | ||
|
||
現在2つのワーキンググループ(WG)が活動しています。[プラットフォームWG](./wgs/platforms/)と[アーティファクトWG](./wgs/artifacts/)です。 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
そしてこれは本家も治すべき話ですが、Operator WG も含めておいた方が良さそうですかね。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Operator Working Groupの説明に「currently inactive」とあるので、このままにしておこうと思いますー。
https://tag-app-delivery.cncf.io/wgs/operator/
ご指摘のとおりだと思いますが、中韓もまとめてweightつけたいので別PRにしようと思います。 翻訳ではないですが、ちょうど日中韓またいで修正したい箇所(主に英語コンテンツでの最新の修正への追従)があるので、その時に合わせて実施しようかと。 |
Signed-off-by: Hiroshi Hayakawa <[email protected]>
Signed-off-by: Hiroshi Hayakawa <[email protected]>
website/config.toml
Outdated
title = "CNCF TAG App Delivery" | ||
description = "TAG App Deliveryは、構築、実行、管理、運用を含む、クラウドネイティブアプリケーションのデリバリーに関連するプロジェクトや取り組みの支援を行います。" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
こちらも「CNCF TAG Appデリバリー」ですね。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ご指摘ありがとうございます。見落としていました。
Signed-off-by: Hiroshi Hayakawa <[email protected]>
… with the translated version. Signed-off-by: Hiroshi Hayakawa <[email protected]>
Signed-off-by: Hiroshi Hayakawa <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
c.f. f3a4854 Signed-off-by: Hiroshi Hayakawa <[email protected]>
Thank you all for the work here! I'm working on reviewing now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rubber stamp LGTM from me, thank you @hhiroshell for the work and @kaitoii11, @MasayaAoyama and @naonishijima for the reviews!
* add Japanese contents * copy the English contents to the Japanese directory * translate website/config.toml and website/i18n/ja.toml * Introduce taxonomy for blog pages under content/ja. c.f. cncf#518 * translate the titles of each page and the descriptions of second-level pages * translate the top page of the website * translate "Initiative " to 「取り組み」 * add contributions pages to the jp contents c.f. cncf#519 * Copy new en blog contents to content/ja/ c.f. cncf#523 * correct the omission in the translation of 'packaging'. * translate "TAG App Delivery" to 「TAG Appデリバリー」 * translate "TAG App Delivery" to 「TAG Appデリバリー」 * remove the "url" property to prevent overwriting the default language with the translated version. * translate descriptions of each page to jp. * fix for slack channel name c.f. hhiroshell@f3a4854 --------- Signed-off-by: Hiroshi Hayakawa <[email protected]>
* add Japanese contents * copy the English contents to the Japanese directory * translate website/config.toml and website/i18n/ja.toml * Introduce taxonomy for blog pages under content/ja. c.f. cncf#518 * translate the titles of each page and the descriptions of second-level pages * translate the top page of the website * translate "Initiative " to 「取り組み」 * add contributions pages to the jp contents c.f. cncf#519 * Copy new en blog contents to content/ja/ c.f. cncf#523 * correct the omission in the translation of 'packaging'. * translate "TAG App Delivery" to 「TAG Appデリバリー」 * translate "TAG App Delivery" to 「TAG Appデリバリー」 * remove the "url" property to prevent overwriting the default language with the translated version. * translate descriptions of each page to jp. * fix for slack channel name c.f. hhiroshell@f3a4854 --------- Signed-off-by: Hiroshi Hayakawa <[email protected]> Signed-off-by: Hoon Jo <[email protected]>
This PR makes Japanese available in the language selection menu. It also localizes the top page and the titles of each page into Japanese for the Japanese site.
For content that has not been translated, I have copied the English content as is, following the discussion in #492.
To Japanese Reviewers:
Please see the link below to review parts translated into Japanese.
Thank you for the pioneering work in Chinese and Korean translations.