Introduce more guidance on getting start contributing #523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have made awesome strides by introducing more contributing guides to the website in cncf#519. This closes cncf#495 by introducing both a detailed blog post and an accompanying issue template which can support organising people's thoughts and provide the TAG with more information to support new ideas. This is heavily modelled after the sandbox template but of course needs to be much more light weight. One thing that has been removed but may need to be re-added is a reference to who owns IP from any contribution. Big thanks to @techmaharaj for a lot of the content and the first review of this PR. Signed-off-by: Abby Bangser <[email protected]>
abangser
requested review from
AloisReitbauer,
AlexsJones,
thschue,
joshgav,
lianmakesthings,
kgamanji,
justincormack and
angellk
as code owners
✅ Deploy Preview for tag-app-delivery canceled.
|
techmaharaj
reviewed
Dec 20, 2023
Co-authored-by: Atulpriya Sharma <[email protected]> Signed-off-by: abangser <[email protected]>
lianmakesthings
requested changes
Dec 20, 2023
|
Very detailed with encouraging guidance. Looks great to me! |
abangser
force-pushed
the
support-for-getting-started
branch
from
c4a9558
to
025e8d5
Compare
|
Doh! @lianmakesthings I made an assumption that it would take some time to get reviews so I post-dated it to Dec 22. This meant it wouldn't show up on the blog. I just updated the date to today and confirmed locally that it shows up now. I expected a preview deploy to occur again but it keeps coming up as canceled 🤔 This may need to be either on trust or verified locally. So sorry! |
Signed-off-by: Abby Bangser <[email protected]>
abangser
force-pushed
the
support-for-getting-started
branch
from
025e8d5
to
aee724e
Compare
No worries. Maybe you could just put the PR in draft mode if you're not ready for an "official" review yet. I tend to try to get reviews out of the way asap, so maybe I'm just too quick (or too thorough 😂 ) |
|
This was definitely ready for review. I just didn't realise that was how the dates worked :til: So there are two things I guess... 1) is the content reasonable and 2) does it show up on the site. Unfortunately the preview deploy isn't coming up for my change and I am not sure why not. So for #2 it unfortunately can only be validated locally 😢 |
|
@joshgav @cjyabraham I remember you were trying to figure out why new commits in a PR don't trigger a rebuild of the deploy preview. Did you come to any solutions? |
|
The deploy preview is here: https://deploy-preview-523--tag-app-delivery.netlify.app/blog/contributing-to-wg-platforms/ I'm not sure why netlify is reporting that the deploy is cancelled since it is built and seems up-to-date to me. You can find the link to deploy previews by inspecting a commit and clicking on "Details": 
|
lianmakesthings
approved these changes
Dec 21, 2023
hhiroshell
added a commit
to hhiroshell/tag-app-delivery
that referenced
this pull request
Dec 22, 2023
c.f. cncf#523 Signed-off-by: Hiroshi Hayakawa <[email protected]>
joshgav
pushed a commit
that referenced
this pull request
Jan 9, 2024
* add Japanese contents * copy the English contents to the Japanese directory * translate website/config.toml and website/i18n/ja.toml * Introduce taxonomy for blog pages under content/ja. c.f. #518 * translate the titles of each page and the descriptions of second-level pages * translate the top page of the website * translate "Initiative " to 「取り組み」 * add contributions pages to the jp contents c.f. #519 * Copy new en blog contents to content/ja/ c.f. #523 * correct the omission in the translation of 'packaging'. * translate "TAG App Delivery" to 「TAG Appデリバリー」 * translate "TAG App Delivery" to 「TAG Appデリバリー」 * remove the "url" property to prevent overwriting the default language with the translated version. * translate descriptions of each page to jp. * fix for slack channel name c.f. hhiroshell@f3a4854 --------- Signed-off-by: Hiroshi Hayakawa <[email protected]>
abangser
added a commit
to abangser/tag-app-delivery
that referenced
this pull request
Jan 11, 2024
* Introduce more guidance on getting start contributing We have made awesome strides by introducing more contributing guides to the website in cncf#519. This closes cncf#495 by introducing both a detailed blog post and an accompanying issue template which can support organising people's thoughts and provide the TAG with more information to support new ideas. This is heavily modelled after the sandbox template but of course needs to be much more light weight. One thing that has been removed but may need to be re-added is a reference to who owns IP from any contribution. Big thanks to @techmaharaj for a lot of the content and the first review of this PR. Signed-off-by: Abby Bangser <[email protected]> Co-authored-by: Atulpriya Sharma <[email protected]>
abangser
pushed a commit
to abangser/tag-app-delivery
that referenced
this pull request
Jan 11, 2024
* add Japanese contents * copy the English contents to the Japanese directory * translate website/config.toml and website/i18n/ja.toml * Introduce taxonomy for blog pages under content/ja. c.f. cncf#518 * translate the titles of each page and the descriptions of second-level pages * translate the top page of the website * translate "Initiative " to 「取り組み」 * add contributions pages to the jp contents c.f. cncf#519 * Copy new en blog contents to content/ja/ c.f. cncf#523 * correct the omission in the translation of 'packaging'. * translate "TAG App Delivery" to 「TAG Appデリバリー」 * translate "TAG App Delivery" to 「TAG Appデリバリー」 * remove the "url" property to prevent overwriting the default language with the translated version. * translate descriptions of each page to jp. * fix for slack channel name c.f. hhiroshell@f3a4854 --------- Signed-off-by: Hiroshi Hayakawa <[email protected]>
sysnet4admin
pushed a commit
to sysnet4admin/tag-app-delivery
that referenced
this pull request
Feb 24, 2024
* Introduce more guidance on getting start contributing We have made awesome strides by introducing more contributing guides to the website in cncf#519. This closes cncf#495 by introducing both a detailed blog post and an accompanying issue template which can support organising people's thoughts and provide the TAG with more information to support new ideas. This is heavily modelled after the sandbox template but of course needs to be much more light weight. One thing that has been removed but may need to be re-added is a reference to who owns IP from any contribution. Big thanks to @techmaharaj for a lot of the content and the first review of this PR. Signed-off-by: Abby Bangser <[email protected]> Co-authored-by: Atulpriya Sharma <[email protected]> Signed-off-by: Hoon Jo <[email protected]>
sysnet4admin
pushed a commit
to sysnet4admin/tag-app-delivery
that referenced
this pull request
Feb 24, 2024
* add Japanese contents * copy the English contents to the Japanese directory * translate website/config.toml and website/i18n/ja.toml * Introduce taxonomy for blog pages under content/ja. c.f. cncf#518 * translate the titles of each page and the descriptions of second-level pages * translate the top page of the website * translate "Initiative " to 「取り組み」 * add contributions pages to the jp contents c.f. cncf#519 * Copy new en blog contents to content/ja/ c.f. cncf#523 * correct the omission in the translation of 'packaging'. * translate "TAG App Delivery" to 「TAG Appデリバリー」 * translate "TAG App Delivery" to 「TAG Appデリバリー」 * remove the "url" property to prevent overwriting the default language with the translated version. * translate descriptions of each page to jp. * fix for slack channel name c.f. hhiroshell@f3a4854 --------- Signed-off-by: Hiroshi Hayakawa <[email protected]> Signed-off-by: Hoon Jo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have made awesome strides by introducing more contributing guides to the website in #519.
This closes #495 by introducing both a detailed blog post and an accompanying issue template which can support organising people's thoughts and provide the TAG with more information to support new ideas.
This is heavily modelled after the sandbox template but of course needs to be much more light weight. One thing that has been removed but may need to be re-added is a reference to who owns IP from any contribution.
Big thanks to @techmaharaj for a lot of the content and the first review of this PR.