Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable i18n with ko(Korean) for website #511

Merged
merged 13 commits into from
Dec 3, 2023
Merged

Enable i18n with ko(Korean) for website #511

merged 13 commits into from
Dec 3, 2023

Conversation

Eeap
Copy link
Contributor

@Eeap Eeap commented Nov 28, 2023

Copy link

netlify bot commented Nov 28, 2023

Deploy Preview for tag-app-delivery ready!

Name Link
🔨 Latest commit be5ea3f
🔍 Latest deploy log https://app.netlify.com/sites/tag-app-delivery/deploys/656838d0711f920008430fa9
😎 Deploy Preview https://deploy-preview-511--tag-app-delivery.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@joshgav
Copy link
Contributor

joshgav commented Nov 28, 2023

Thank you for this @Eeap! @sysnet4admin could you take a look too since I'm not fluent in Korean?

@Eeap - it seems you copied the English files (in English we use symlinks). I think it's fine and in fact needed to copy, but could you get the content from the latest directory rather than v1? Latest is here: https://github.com/cncf/tag-app-delivery/tree/main/platforms-whitepaper/latest

Thanks!

@joshgav joshgav added wg-platforms Related to cooperative delivery initiatives. website Related to TAG website. labels Nov 28, 2023
@Eeap
Copy link
Contributor Author

Eeap commented Nov 28, 2023

Thank you for this @Eeap! @sysnet4admin could you take a look too since I'm not fluent in Korean?

@Eeap - it seems you copied the English files (in English we use symlinks). I think it's fine and in fact needed to copy, but could you get the content from the latest directory rather than v1? Latest is here: https://github.com/cncf/tag-app-delivery/tree/main/platforms-whitepaper/latest

Thanks!

Thank you for reviewing ! @joshgav
There are symbolic links with English files, so I copied contents. But I did v1 copy by my mistake, so I have changed it with latest version contents by referring to that link.

Copy link
Contributor

@joshgav joshgav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The technical part looks good to me! I'll wait a bit longer to merge so folks who are fluent in Korean can have a chance to review.

@Eeap
Copy link
Contributor Author

Eeap commented Nov 29, 2023

Okay, thank you @joshgav. Also I will translate other contents into korean if this PR is merged !

Copy link
Contributor

@sysnet4admin sysnet4admin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please take a look.

website/config.toml Outdated Show resolved Hide resolved
website/config.toml Outdated Show resolved Hide resolved
website/content/ko/_index.md Outdated Show resolved Hide resolved
</div>
<div class="col-lg-6">
<div class="lead">
구축, 패키징, 배포, 관리 및 운영을 포함하여 클라우드 네이티브 애플리케이션 제공과 관련된 프로젝트 및 계획입니다.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where is 'initiatives' ??? is not '계획' (plan)
And you may know KO's grammar is

  • several '및' is not good writing.

Copy link
Contributor Author

@Eeap Eeap Nov 29, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've thought about it a lot... It looks like "초기� 계획?" but I don't know how to express this with korean.. Google Translator interpreted it as "이니셔티브".

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Translating is for local people. Best sample is the movie of Deadpool.
The point is fluent read and understand what it the meaning of this.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or I am highly recommend Kubernetes' KO translation team.
https://kubernetes.slack.com/archives/CA1MMR86S
They are super good content in Korean.
It could be great referencing.

Copy link
Contributor Author

@Eeap Eeap Nov 29, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for suggesting. It is difficult to select appropriate words 😭 I will keep trying to find better word
Also how about changing initiatives with "이니셔티브"?? That makes sense than "계획". I will ask to them too!


TAG는 클라우드 네이티브 애플리케이션 개발자, 플랫폼 엔지니어 및 최종 사용자로부터 피드백을 수집하고, 해당 피드백을 해당 도메인의 프로젝트와 공유하며, 최종 사용자를 위한 지침 및 예제를 제공합니다.

TAG는 [애플리케이션 정의 및 이미지 빌드](https://landscape.cncf.io/card-mode?category=application-definition-image-build&project=hosted), [지속적인 통합 및 제공](https://landscape.cncf.io/card-mode?category=continuous-integration-delivery&project=hosted), [컨테이너 저장소](https://landscape.cncf.io/card-mode?category=container-registry&project=hosted)에 있는 [CNCF Landscape](https://landscape.cncf.io/card-mode)의 프로젝트와 같은 헌장과 관련된 프로젝트를 지원합니다.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

chapter is not look like '헌장'...? Why it is '헌장?'
And there is continually '와', '과' = of , so it cannot read properly.

Copy link
Contributor Author

@Eeap Eeap Nov 29, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think charter means like "규범 or 규정", so I have translated it as "헌장" because CNCF is non-profit organization.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you have any idea about charter?? I don't know exactly how to translate it..

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is good to ask them..
What does "charter" mean?? Could you please let me know ?? It is about principle or guidance?? @joshgav

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Eeap
I am sure the charter means https://github.com/cncf/toc/blob/main/tags/app-delivery.md#cncf-tag-app-delivery-charter :)

operations of the CNCF TAG Application Delivery. mission, focus, scope, ... :)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, the "charter" is like a constitution that defines what the group is supposed to work on.

* [줌 회의](https://zoom.us/j/7276783015) (Passcode: 77777)
* [이전 회의 기록본](https://www.youtube.com/playlist?list=PLj6h78yzYM2OHd1Ht3jiZuucWzvouAAci)

## 리더
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

리더 needs to plural due to several.
And it needs to more description in Korean (리더 feel different.)

Copy link
Contributor Author

@Eeap Eeap Nov 29, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

리더 needs to plural due to several. And it needs to more description in Korean (리더 feel different.)

how about "진행자"??

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

리드(leads) 도 괜찮을 것 같습니다.

lead는 한국에서 사용하는 리더 leader와 뉘앙스가 다소 다른 표현인 것으로 알고 있습니다.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

그럼 진행자나 뭐 이런 단어보다 그냥 리드로 쓰는게 더 적절할까요?


### 추가 자료

- [TAG 헌장](https://github.com/cncf/toc/blob/main/tags/app-delivery.md)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is not '헌장' just part of chapter of statement.

Copy link
Contributor Author

@Eeap Eeap Nov 29, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They defines charter like this The charter describes the mission and tactics of the Platforms working group (WG)
https://glossary.cncf.io/ko/

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

운영 원칙(charter)

으로 작성하면 큰 무리가 없을 것 같습니다.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

charter가 여러 곳에서 쓰이는데 다 운영 원칙으로 통일해도 문제 없을까요?? 약간 규칙, 규범 같은 걸로 해석되긴 하는 것 같습니다

website/content/ko/_index.md Outdated Show resolved Hide resolved

- [TAG 헌장](https://github.com/cncf/toc/blob/main/tags/app-delivery.md)
- Slack channel: [#tag-app-delivery](https://cloud-native.slack.com/messages/CL3SL0CP5)
- [CNCF Slack에 자신을 초대하세요](https://slack.cncf.io/)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

EN is okay to invite yourself. but '자신을 초대하세요' is very strange.

Copy link
Contributor Author

@Eeap Eeap Nov 29, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

EN is okay to invite yourself. but '자신을 초대하세요' is very strange.

Then how about "CNCF slack 가입"??

website/content/ko/_index.md Outdated Show resolved Hide resolved
Copy link

@seokho-son seokho-son left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Eeap (@sysnet4admin)
Thanks for this initiation for Korean! :)

I am one of maintainers of the Korean localization in Kubernetes SIG-Docs as well as CNCF Cloud Native Glossary. :)
Based on your help message from the k8s SIG-Docs slack Korean channel,
I've reviewed this PR. PTAL the comments. Hope this review is useful to everyone.
Note: the comments are in Korean for the better discussion experience~! ;)

Comment on lines 64 to 65
title = "CNCF TAG 앱 제공"
decscription = "TAG App Delivery는 구축, 배포, 관리 및 운영을 포함하여 클라우드 네이티브 애플리케이션 제공과 관련된 프로젝트 및 계획을 활성화하는 데 중점을 둡니다."

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
title = "CNCF TAG 앱 제공"
decscription = "TAG App Delivery는 구축, 배포, 관리운영을 포함하여 클라우드 네이티브 애플리케이션 제공과 관련된 프로젝트 및 계획을 활성화하는 데 중점을 둡니다."
title = "CNCF 앱 딜리버리 TAG(TAG App Delivery)"
description = "앱 딜리버리(delivery) TAG(Technology Advisory Group, 기술 자문 그룹)는 구축, 배포, 관리, 운영을 포함하여 클라우드 네이티브 애플리케이션 딜리버리에 관련된 다양한 프로젝트와 구심점 활성화에 중점을 둔다."
  1. @sysnet4admin 님의 코멘트 Because delivery is not 'providing' purpose, it is sorted of defintion of new concept of guard rail for Cloud native application.에 공감합니다. App Delivery 에 명확하게 대응되는 단어가 없는 경우에는 무리하게 한글로 변경하기 보다는, 앞으로 해당 용어가 한국 사람들에게 익숙해질 수 있도록 음차로 표기하고 영문을 병기하는 것이 좋을 것 같다는 생각입니다. 기존에 두 분께서 제안하신 애플리케이션 가이드도 문맥상 문제는 없을 것 같지만, 해당 TAG는 명확한 이름이 있는 그룹의 이름이라, 임의로 "딜리버리"의 의미를 생략해서 부르기에는 무리가 있을 것 같습니다. 앱 관련 다른 TAG (예를 들면, TAG 앱 시큐리티)가 있거나 생기는 경우에는 명칭에 혼돈을 줄 수도 있겠네요.
  2. TAG의 위치를 뒤로 넘겼습니다. 한글의 어순상, 기술 자문 그룹 앱 딜리버리 보다는 앱 딜리버리 자문 그룹. 이 자연스러울 것 같네요.
  3. decscription 오타인것 같습니다. 빌드 오류가 날 수도 있겠네요. 수정 필수입니다.
  4. 이니셔티브는 구심점 으로 표현해보았습니다. 다만 문서상에서 이니셔티브가 매우 많이 나온다면, 이는 단체를 표현하는 의미일 수도 있어서, 문서별로 다른 형태로 번역해야 하는 상황도 있을 것 같네요. 여기서는 구심점이라고 표현하면, 의미가 명확히 전달될 것 같습니다.
  5. 문장을 전반적으로 자연스럽게 수정해보았습니다.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

어투를 평어체로 변경하였습니다. (보통 기술문서에서는 평어체를 사용합니다.)

Copy link
Contributor Author

@Eeap Eeap Nov 29, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

중국 문서를 참고했더니 오류가 났네요 감사합니다 :)
이니셔티브가 뭔가 해석의 여지가 많이 남는 것 같아서 차라리 이니셔티브로 통일하는게 어떨까 싶습니다 !

website/content/ko/_index.md Outdated Show resolved Hide resolved
website/content/ko/_index.md Outdated Show resolved Hide resolved
</div>
</div>

TAG는 클라우드 네이티브 애플리케이션 개발자, 플랫폼 엔지니어 및 최종 사용자로부터 피드백을 수집하고, 해당 피드백을 해당 도메인의 프로젝트와 공유하며, 최종 사용자를 위한 지침 및 예제를 제공합니다.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
TAG는 클라우드 네이티브 애플리케이션 개발자, 플랫폼 엔지니어 및 최종 사용자로부터 피드백을 수집하고, 해당 피드백을 해당 도메인의 프로젝트와 공유하며, 최종 사용자를 위한 지침 및 예제를 제공합니다.
TAG는 클라우드 네이티브 애플리케이션 개발자, 플랫폼 엔지니어 및 최종
사용자로부터 피드백을 수집하고, 수집한 피드백을 관련 도메인의 프로젝트와 공유한다.
또한, 최종 사용자를 위해 지침 및 예시를 생산한다.

는 어떨까요? 참고하시면 되겠습니다.

참고로, 기존 영문의 개행과 유사하게 라인브레이크를 넣어주면 좋을 것 같습니다. :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TAG(Technology Advisory Group, 기술 자문 그룹)는 클라우드 네이티브 애플리케이션 개발자, 플랫폼
엔지니어, 최종 사용자로부터 피드백을 수집한다. 그리고 수집한 피드백을 관련 도메인의 프로젝트와 공유하며,
최종 사용자를 위한 지침과 예시를 제공한다.

보통 영문의 라인브레이크를 따라가는게 좋나요? 요런식은 어떨까요??


TAG는 클라우드 네이티브 애플리케이션 개발자, 플랫폼 엔지니어 및 최종 사용자로부터 피드백을 수집하고, 해당 피드백을 해당 도메인의 프로젝트와 공유하며, 최종 사용자를 위한 지침 및 예제를 제공합니다.

TAG는 [애플리케이션 정의 및 이미지 빌드](https://landscape.cncf.io/card-mode?category=application-definition-image-build&project=hosted), [지속적인 통합 및 제공](https://landscape.cncf.io/card-mode?category=continuous-integration-delivery&project=hosted), [컨테이너 저장소](https://landscape.cncf.io/card-mode?category=container-registry&project=hosted)에 있는 [CNCF Landscape](https://landscape.cncf.io/card-mode)의 프로젝트와 같은 헌장과 관련된 프로젝트를 지원합니다.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Eeap
I am sure the charter means https://github.com/cncf/toc/blob/main/tags/app-delivery.md#cncf-tag-app-delivery-charter :)

operations of the CNCF TAG Application Delivery. mission, focus, scope, ... :)


TAG는 [애플리케이션 정의 및 이미지 빌드](https://landscape.cncf.io/card-mode?category=application-definition-image-build&project=hosted), [지속적인 통합 및 제공](https://landscape.cncf.io/card-mode?category=continuous-integration-delivery&project=hosted), [컨테이너 저장소](https://landscape.cncf.io/card-mode?category=container-registry&project=hosted)에 있는 [CNCF Landscape](https://landscape.cncf.io/card-mode)의 프로젝트와 같은 헌장과 관련된 프로젝트를 지원합니다.

현재 TAG 아래에는 두 개의 활동적인 작업 그룹이 있습니다. - [플랫폼 작업 그룹](./wgs/platforms/) and [아티팩트 작업 그룹](./wgs/artifacts/).

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
현재 TAG 아래에는 두 개의 활동적인 작업 그룹이 있습니다. - [플랫폼 작업 그룹](./wgs/platforms/) and [아티팩트 작업 그룹](./wgs/artifacts/).
현재 TAG에는 두 개의 활발한 작업 그룹(working group)이 포함되어 있다. TAG - [플랫폼 작업 그룹(WG Platforms)](./wgs/platforms/) [아티팩트 작업 그룹(WG Artifacts)](./wgs/artifacts/).

는 어떠실까요?

website/content/ko/_index.md Outdated Show resolved Hide resolved
* [줌 회의](https://zoom.us/j/7276783015) (Passcode: 77777)
* [이전 회의 기록본](https://www.youtube.com/playlist?list=PLj6h78yzYM2OHd1Ht3jiZuucWzvouAAci)

## 리더

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

리드(leads) 도 괜찮을 것 같습니다.

lead는 한국에서 사용하는 리더 leader와 뉘앙스가 다소 다른 표현인 것으로 알고 있습니다.


### 추가 자료

- [TAG 헌장](https://github.com/cncf/toc/blob/main/tags/app-delivery.md)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

운영 원칙(charter)

으로 작성하면 큰 무리가 없을 것 같습니다.

website/content/ko/wgs/platforms/glossary/_index.md Outdated Show resolved Hide resolved
@Eeap
Copy link
Contributor Author

Eeap commented Nov 29, 2023

Thanks for reviewing PR 🙂 @seokho-son @sysnet4admin
I have corrected strange expressions. Could you check again ??

Copy link

@seokho-son seokho-son left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Eeap
I have few minor suggestions. :)

website/content/ko/_index.md Outdated Show resolved Hide resolved
website/content/ko/_index.md Outdated Show resolved Hide resolved
@Eeap
Copy link
Contributor Author

Eeap commented Nov 30, 2023

Thanks @Eeap I have few minor suggestions. :)

Thanks @seokho-son
I have modified what you suggested. :)

@seokho-son
Copy link

LGTM :)
Thanks!

@Eeap
Copy link
Contributor Author

Eeap commented Dec 3, 2023

Hello, @joshgav
I think there is no more to fix. Could you check this again?
Thank you :)

@joshgav
Copy link
Contributor

joshgav commented Dec 3, 2023

Thanks so much @Eeap for your work on this, and thank you @seokho-son and @sysnet4admin for your reviews. Merging now!

@joshgav joshgav merged commit 5f0bedb into cncf:main Dec 3, 2023
5 checks passed
abangser pushed a commit to abangser/tag-app-delivery that referenced this pull request Jan 11, 2024
sysnet4admin pushed a commit to sysnet4admin/tag-app-delivery that referenced this pull request Feb 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
translation website Related to TAG website. wg-platforms Related to cooperative delivery initiatives.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants